From nobody Sun Feb 8 10:21:43 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) client-ip=216.205.24.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1618600390; cv=none; d=zohomail.com; s=zohoarc; b=f/LhAtyTMCT3Af8nIwcTs7TCKUZVYwLHTyFupTbWiuxJRrzUKLGynbQjO0/nGRWe8q7dMO2IQUYDgUuU97SX4OWZWmUmivxzJHiZfBgTNQMdtA6yOlLfi/rpH5enAx/4cnjDk8FxhBJPZVLuqiwgeTvlcquieUjPpFrsrNcZSS4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1618600390; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=r0S4jNo0m9RyHA6CgdVr+owipUpZWhAOAxHJ7hPgigY=; b=W7Y1y7LflNVVGPmAWrZ33iW+tBV6u6aDAwzJ8GLXVXoBOQ4CqgqjcAre0Jdy71/Ob0DQcGwwZzhl/fuHpsFu7ax8Qt36fLRhI2ne85tOlGeJuVU+TAbNd7tLAI5cgrNGkd4RhW+kzrd6KWnz3wKppzSdxQjek3Eg0Ht5DMo2x3E= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.zohomail.com with SMTPS id 1618600390956564.9343706524303; Fri, 16 Apr 2021 12:13:10 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-179-WJ0wY3VBMh6i75kSdlj_Dg-1; Fri, 16 Apr 2021 15:13:07 -0400 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 637458030A1; Fri, 16 Apr 2021 19:13:00 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id D7D625C260; Fri, 16 Apr 2021 19:12:59 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id B01F644A5F; Fri, 16 Apr 2021 19:12:55 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 13GJCrYx028190 for ; Fri, 16 Apr 2021 15:12:53 -0400 Received: by smtp.corp.redhat.com (Postfix) id 5783F5D749; Fri, 16 Apr 2021 19:12:53 +0000 (UTC) Received: from antique-work.redhat.com (unknown [10.40.195.130]) by smtp.corp.redhat.com (Postfix) with ESMTP id CC0DE5D6D3 for ; Fri, 16 Apr 2021 19:12:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1618600389; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=r0S4jNo0m9RyHA6CgdVr+owipUpZWhAOAxHJ7hPgigY=; b=WVrTxv1yVQxoYrO/Rtocw1K1axiht8DYDeAOLOeRnE+yBfjPXWnSDgWEvfXD3UjHJ8ES2O MvN9TL8xvR44Uel7/dxDCJ2+yTQrQdKO/PwMjCP6WegabFTHntoqNEBF1mFshGz7MFKMOd DHmDXh1up6A0kg6enJSeEdidUEYZLlk= X-MC-Unique: WJ0wY3VBMh6i75kSdlj_Dg-1 From: Pavel Hrdina To: libvir-list@redhat.com Subject: [libvirt PATCH 01/17] bridge_driver: fix comment about dnsmasqCaps Date: Fri, 16 Apr 2021 21:12:30 +0200 Message-Id: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" We will never call dnsmasqCapsRefresh() so reflect what actually happens. Signed-off-by: Pavel Hrdina --- src/network/bridge_driver.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/network/bridge_driver.c b/src/network/bridge_driver.c index 1172dbbc18..706a557ee8 100644 --- a/src/network/bridge_driver.c +++ b/src/network/bridge_driver.c @@ -748,7 +748,7 @@ networkStateInitialize(bool privileged, false, getpid())) < 0) goto error; =20 - /* if this fails now, it will be retried later with dnsmasqCapsRefresh= () */ + /* if this fails now, it will be retried later with networkDnsmasqCaps= Refresh() */ network_driver->dnsmasqCaps =3D dnsmasqCapsNewFromBinary(DNSMASQ); =20 if (!(network_driver->networks =3D virNetworkObjListNew())) --=20 2.30.2