From nobody Mon Feb 9 01:50:27 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) client-ip=170.10.129.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1688022637; cv=none; d=zohomail.com; s=zohoarc; b=PhWcPM/JwWYe2l4i50vYotwZWGCvw6CR0kJA0nsM3o+RmAX5hV1wNXMRyp5KicysxrzQqUGEV8yBEK2w7SFPrgA/Fbyo6g3Byr0e6JSO1aGcNdaB5CZ1MfYPsaF58UxVuF7h5srszDlhnh1g+1xtzAExuUQDmxYJKznCANKvGkQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1688022637; h=Content-Type:Content-Transfer-Encoding:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=yW0okNe57cLrduWmGyevL/Eh542VQAn5EXoX9LuNv/A=; b=kfjHF9erhJNMSENOJEowiiNCi5lHQ+clfwpuk+KHL9ucvlhYeIq+GE7PCwcz5y6OXhDvT2yrjRlbU/9i4m+YHsBaWKtHAACv9N4qU2XJneheWi8JTowsaRCSyi5QTHi4SoFvhUrsxNXVD3e9Vnrv/B3MMo740zjNQtWuTmfYBFo= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.zohomail.com with SMTPS id 1688022637123713.5184454610143; Thu, 29 Jun 2023 00:10:37 -0700 (PDT) Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-391-SvPlqmecOuawB_zLP1d7-A-1; Thu, 29 Jun 2023 03:10:32 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 54DCE1C068F5; Thu, 29 Jun 2023 07:10:30 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id ABD88200B680; Thu, 29 Jun 2023 07:10:29 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 826D21946594; Thu, 29 Jun 2023 07:10:28 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 1301D1946589 for ; Thu, 29 Jun 2023 07:10:27 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id B0C6C1121314; Thu, 29 Jun 2023 07:10:27 +0000 (UTC) Received: from localhost.localdomain (unknown [10.43.2.36]) by smtp.corp.redhat.com (Postfix) with ESMTP id 589091121315 for ; Thu, 29 Jun 2023 07:10:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1688022636; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=yW0okNe57cLrduWmGyevL/Eh542VQAn5EXoX9LuNv/A=; b=jIdFGNr1QmCVGT7V7jG2anVho9oi0AVEIf+2HrKbtX4rcg39mBmSPDM303Cd8qXjX9QFb6 4+uy0UN34ORTzGiPor4YAsZKLeGgkJGE4g5ut+a71JH3EQsINY9yYEh7wEcSCivOOcjfAO A9f2TSaCW4QKK4QbtBkR9ERgAyZEDL4= X-MC-Unique: SvPlqmecOuawB_zLP1d7-A-1 X-Original-To: libvir-list@listman.corp.redhat.com From: Michal Privoznik To: libvir-list@redhat.com Subject: [PATCH] Revert "lxc_fuse: Tell FUSE that /proc/meminfo is nonseekable" Date: Thu, 29 Jun 2023 09:10:26 +0200 Message-Id: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.3 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 3.1 on 10.11.54.4 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1688022637583100001 Content-Type: text/plain; charset="utf-8"; x-default="true" After v8.1.0-61-g030faee28d it is no longer necessary to make the /proc/meminfo file nonseekable as our code that fills the file with spoofed values can handle seeking just fine. Previously, `free(1)` was okay with failed lseek(), but this was ages ago and meanwhile the procps project moved to creating a library and moved the file parsing code under an exported function. In attempt to make the function callable multiple times, it can lseek() multiple times and failure to do so is fatal. This reverts commit 766495508650bebd5f4ac23224ecd0a2ee2ca9eb. Resolves: https://gitlab.com/libvirt/libvirt/-/issues/492 Signed-off-by: Michal Privoznik Reviewed-by: J=C3=A1n Tomko --- Ideally, I'd like to merge this in the time for upcoming release, but I don't insist. It's a bug fix after all ;-) src/lxc/lxc_fuse.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/lxc/lxc_fuse.c b/src/lxc/lxc_fuse.c index a11cbbaff7..44bdd1412d 100644 --- a/src/lxc/lxc_fuse.c +++ b/src/lxc/lxc_fuse.c @@ -163,7 +163,6 @@ lxcProcOpen(const char *path, return -EACCES; =20 fi->direct_io =3D 1; - fi->nonseekable =3D 1; return 0; } =20 --=20 2.39.3