From nobody Fri Dec 19 15:49:46 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1741797753086738.6375797863213; Wed, 12 Mar 2025 09:42:33 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 996) id 7229115F5; Wed, 12 Mar 2025 12:42:32 -0400 (EDT) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id 2A94F1CE6; Wed, 12 Mar 2025 12:32:31 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 996) id 1B3401C30; Wed, 12 Mar 2025 12:32:15 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 668B71D02 for ; Wed, 12 Mar 2025 12:31:53 -0400 (EDT) Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-650-A_EsD6uVN32F4fKnQ_OJ4g-1; Wed, 12 Mar 2025 12:31:51 -0400 Received: from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id F0A2A1800265 for ; Wed, 12 Mar 2025 16:31:50 +0000 (UTC) Received: from speedmetal.lan (unknown [10.45.242.6]) by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 286EF1955BCB for ; Wed, 12 Mar 2025 16:31:49 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_HELO_NONE autolearn=unavailable autolearn_force=no version=3.4.4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1741797113; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+/6sE/DJ5p3wKZoPKke+liwFIGjSFKyGInetnzI4uF4=; b=ZvK4mEsM3sbmVbGgL2JgosUgeSKtqwcSrMoqaWIePFDzEi3gY2DS+QFaet0hx522nUK8tb R7upfg+2TPE5D4UlpgErIZ9kon0XhVn07W1WiACm3toPCW4Lw9vdeArI2Dtbm2Mn8HY1nH B1cpSxQd6UF6nD9A09PENwTU3V6lliA= X-MC-Unique: A_EsD6uVN32F4fKnQ_OJ4g-1 X-Mimecast-MFC-AGG-ID: A_EsD6uVN32F4fKnQ_OJ4g_1741797111 From: Peter Krempa To: devel@lists.libvirt.org Subject: [PATCH 15/17] qemu: domain: Remove qemuDomainSupportsCheckpointsBlockjobs Date: Wed, 12 Mar 2025 17:31:25 +0100 Message-ID: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.12 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: RZC3D9LR_RvUYBQZhl8lKdOwXS9Y_oWsl8PrOH3vpvA_1741797111 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: VHXJFC3HQWBRNSHP56JQQSPJFQ4K2VRS X-Message-ID-Hash: VHXJFC3HQWBRNSHP56JQQSPJFQ4K2VRS X-MailFrom: pkrempa@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1741797756877019000 Content-Type: text/plain; charset="utf-8" The function now serves no real purpose. Signed-off-by: Peter Krempa --- src/qemu/qemu_block.c | 3 --- src/qemu/qemu_domain.c | 14 -------------- src/qemu/qemu_domain.h | 4 ---- src/qemu/qemu_driver.c | 6 ------ src/qemu/qemu_snapshot.c | 4 ---- 5 files changed, 31 deletions(-) diff --git a/src/qemu/qemu_block.c b/src/qemu/qemu_block.c index 76e7f4ca83..2468725bf7 100644 --- a/src/qemu/qemu_block.c +++ b/src/qemu/qemu_block.c @@ -3592,9 +3592,6 @@ qemuBlockCommit(virDomainObj *vm, if (qemuDomainDiskBlockJobIsActive(disk)) return NULL; - if (qemuDomainSupportsCheckpointsBlockjobs(vm) < 0) - return NULL; - if (topSource =3D=3D disk->src) { /* XXX Should we auto-pivot when COMMIT_ACTIVE is not specified? */ if (!(flags & VIR_DOMAIN_BLOCK_COMMIT_ACTIVE)) { diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c index ea29765c61..29fac0034e 100644 --- a/src/qemu/qemu_domain.c +++ b/src/qemu/qemu_domain.c @@ -10169,20 +10169,6 @@ qemuDomainDefHasManagedPR(virDomainObj *vm) } -/** - * qemuDomainSupportsCheckpointsBlockjobs: - * @vm: domain object - * - * Checks whether a block job is supported in possible combination with - * checkpoints (qcow2 bitmaps). Returns -1 if unsupported and reports an e= rror - * 0 in case everything is supported. - */ -int -qemuDomainSupportsCheckpointsBlockjobs(virDomainObj *vm G_GNUC_UNUSED) -{ - return 0; -} - /** * qemuDomainInitializePflashStorageSource: * diff --git a/src/qemu/qemu_domain.h b/src/qemu/qemu_domain.h index 04577f1297..8e53a270a7 100644 --- a/src/qemu/qemu_domain.h +++ b/src/qemu/qemu_domain.h @@ -1053,10 +1053,6 @@ int qemuDomainValidateActualNetDef(const virDomainNetDef *net, virQEMUCaps *qemuCaps); -int -qemuDomainSupportsCheckpointsBlockjobs(virDomainObj *vm) - G_GNUC_WARN_UNUSED_RESULT; - int qemuDomainMakeCPUMigratable(virArch arch, virCPUDef *cpu, diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index f974d2fba8..af5445f78d 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -13624,9 +13624,6 @@ qemuDomainBlockPullCommon(virDomainObj *vm, if (virDomainObjCheckActive(vm) < 0) goto endjob; - if (qemuDomainSupportsCheckpointsBlockjobs(vm) < 0) - goto endjob; - if (!(disk =3D qemuDomainDiskByName(vm->def, path))) goto endjob; @@ -14150,9 +14147,6 @@ qemuDomainBlockCopyCommon(virDomainObj *vm, if (virDomainObjCheckActive(vm) < 0) goto endjob; - if (qemuDomainSupportsCheckpointsBlockjobs(vm) < 0) - goto endjob; - if (!(disk =3D qemuDomainDiskByName(vm->def, path))) goto endjob; diff --git a/src/qemu/qemu_snapshot.c b/src/qemu/qemu_snapshot.c index 9556bd1216..9c2ab47c51 100644 --- a/src/qemu/qemu_snapshot.c +++ b/src/qemu/qemu_snapshot.c @@ -1082,7 +1082,6 @@ qemuSnapshotPrepare(virDomainObj *vm, } /* Handle interlocking with 'checkpoints': - * - if the VM is online use qemuDomainSupportsCheckpointsBlockjobs * - if the VM is offline disallow external snapshots as the support f= or * propagating bitmaps into the would-be-created overlay is not yet = implemented */ @@ -1093,9 +1092,6 @@ qemuSnapshotPrepare(virDomainObj *vm, _("support for offline external snapshots while= checkpoint exists was not yet implemented")); return -1; } - } else { - if (qemuDomainSupportsCheckpointsBlockjobs(vm) < 0) - return -1; } /* Alter flags to let later users know what we learned. */ --=20 2.48.1