From nobody Tue Sep 9 03:19:49 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1738604519655126.60417793439831; Mon, 3 Feb 2025 09:41:59 -0800 (PST) Received: by lists.libvirt.org (Postfix, from userid 996) id A250019D5; Mon, 3 Feb 2025 12:41:58 -0500 (EST) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id 5D5BB1A26; Mon, 3 Feb 2025 12:41:24 -0500 (EST) Received: by lists.libvirt.org (Postfix, from userid 996) id 671AB18B9; Mon, 3 Feb 2025 12:41:18 -0500 (EST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id E5F1018B4 for ; Mon, 3 Feb 2025 12:41:17 -0500 (EST) Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-424-o9UySYsrOx6PHK-WnK9jxg-1; Mon, 03 Feb 2025 12:41:16 -0500 Received: from mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.15]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 7B10218009F5 for ; Mon, 3 Feb 2025 17:41:15 +0000 (UTC) Received: from speedmetal.lan (unknown [10.45.242.3]) by mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id A28121956095 for ; Mon, 3 Feb 2025 17:41:14 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-0.7 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_HELO_NONE autolearn=unavailable autolearn_force=no version=3.4.4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1738604477; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=P3igdLFvQuAscPlxrX4oqLda71HYoZbFG970HQu8NH0=; b=YjpY0/Il21Gt8HK7f/LJFPWVipezxSFYsY4slqqy4gzlCFKqrBNk6USbyI3wRD/5fBwPrG EiQ3TvrPGEHYL/M1bONshQVihKtNOwriEvLoTL6cfLDuE8vYfEICwFXU11EkVOsGVAKeTW LYUshGzHT2AMQnvyrJlwHyI+7FAXMaU= X-MC-Unique: o9UySYsrOx6PHK-WnK9jxg-1 X-Mimecast-MFC-AGG-ID: o9UySYsrOx6PHK-WnK9jxg From: Peter Krempa To: devel@lists.libvirt.org Subject: [PATCH 1/3] qemuSnapshotForEachQcow2: Don't initialize 'nrollback' Date: Mon, 3 Feb 2025 18:41:09 +0100 Message-ID: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.15 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: Qwx0aq2dgNBbWo0u7oSxf_W5rnC6Y7_iKlc3qtQxsLs_1738604475 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: MTURWMJQ4NZ737QQWZKFAFP3ZVJ5D2ST X-Message-ID-Hash: MTURWMJQ4NZ737QQWZKFAFP3ZVJ5D2ST X-MailFrom: pkrempa@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1738604521844019100 Content-Type: text/plain; charset="utf-8" The variable holds the amount of disks to roll back the snapshot for. The value must be set before the code jumps to the 'rollback:' label so the best situation is to not initialize it and let the compiler catch errors rather than initialize the unsigned variable to -1 and let it crash. Signed-off-by: Peter Krempa --- src/qemu/qemu_snapshot.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/qemu/qemu_snapshot.c b/src/qemu/qemu_snapshot.c index 7ce018b026..e5226db942 100644 --- a/src/qemu/qemu_snapshot.c +++ b/src/qemu/qemu_snapshot.c @@ -290,7 +290,7 @@ qemuSnapshotForEachQcow2(virDomainDef *def, size_t i; bool skipped =3D false; bool create =3D STREQ(op, "-c"); - size_t nrollback =3D -1; + size_t nrollback; virErrorPtr orig_err; /* pre-checks */ --=20 2.48.1