From nobody Mon Feb 9 05:42:08 2026 Delivered-To: importer@patchew.org Received-SPF: none (zohomail.com: 8.43.85.245 is neither permitted nor denied by domain of lists.libvirt.org) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; spf=none (zohomail.com: 8.43.85.245 is neither permitted nor denied by domain of lists.libvirt.org) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 170905596547495.63816909016293; Tue, 27 Feb 2024 09:46:05 -0800 (PST) Received: by lists.libvirt.org (Postfix, from userid 996) id 541BF1858; Tue, 27 Feb 2024 12:46:04 -0500 (EST) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id 0B8431E57; Tue, 27 Feb 2024 11:42:23 -0500 (EST) Received: by lists.libvirt.org (Postfix, from userid 996) id EE3E719FA; Tue, 27 Feb 2024 11:41:57 -0500 (EST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 1DFED1DB6 for ; Tue, 27 Feb 2024 11:36:54 -0500 (EST) Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-70-J0oyYS1DMF6UfCT5a9tmSg-1; Tue, 27 Feb 2024 11:36:49 -0500 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 9C59A10651E7 for ; Tue, 27 Feb 2024 16:36:49 +0000 (UTC) Received: from speedmetal.redhat.com (unknown [10.45.242.12]) by smtp.corp.redhat.com (Postfix) with ESMTP id 16B1E1C060B1 for ; Tue, 27 Feb 2024 16:36:48 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.4 X-MC-Unique: J0oyYS1DMF6UfCT5a9tmSg-1 From: Peter Krempa To: devel@lists.libvirt.org Subject: [PATCH 21/25] qemu: command: Don't downgrade to '-usb' for x86 based machines Date: Tue, 27 Feb 2024 17:36:23 +0100 Message-ID: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.7 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Message-ID-Hash: KWRC3T2CO4SNKZPBMP62LEUKUNE37J5S X-Message-ID-Hash: KWRC3T2CO4SNKZPBMP62LEUKUNE37J5S X-MailFrom: pkrempa@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZM-MESSAGEID: 1709055966798100001 - 'microvm' and 'q35' machine types already explicitly forbid fallback - 'isapc' never supported USB and '-usb' is ignored - 'i440fx' does support '-usb' and translates it into 'piix3-uhci' which is identical to what libvirt selects Attempting to start an 'pc' (i440fx) machine with -usb when 'piix3-uhci' is compiled out will fail and in any other case libvirt will use the proper explicitly selected controller. Drop the '-usb' downgrade for x86 arch. Signed-off-by: Peter Krempa --- src/qemu/qemu_command.c | 3 +- ...ault-unavailable-i440fx.x86_64-latest.args | 33 ------------------- ...fault-unavailable-i440fx.x86_64-latest.err | 1 + ...ntroller-implicit-isapc.x86_64-latest.args | 1 - tests/qemuxmlconftest.c | 6 ++-- 5 files changed, 6 insertions(+), 38 deletions(-) delete mode 100644 tests/qemuxmlconfdata/usb-controller-default-unavailabl= e-i440fx.x86_64-latest.args create mode 100644 tests/qemuxmlconfdata/usb-controller-default-unavailabl= e-i440fx.x86_64-latest.err diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index d0fa31a506..d6328af70b 100644 --- a/src/qemu/qemu_command.c +++ b/src/qemu/qemu_command.c @@ -2922,8 +2922,7 @@ qemuBuildControllerDevProps(const virDomainDef *domai= nDef, static bool qemuBuildDomainForbidLegacyUSBController(const virDomainDef *def) { - if (qemuDomainIsQ35(def) || - qemuDomainIsMicrovm(def) || + if (ARCH_IS_X86(def->os.arch) || qemuDomainIsARMVirt(def) || qemuDomainIsRISCVVirt(def)) return true; diff --git a/tests/qemuxmlconfdata/usb-controller-default-unavailable-i440f= x.x86_64-latest.args b/tests/qemuxmlconfdata/usb-controller-default-unavail= able-i440fx.x86_64-latest.args deleted file mode 100644 index c8de26e4ee..0000000000 --- a/tests/qemuxmlconfdata/usb-controller-default-unavailable-i440fx.x86_6= 4-latest.args +++ /dev/null @@ -1,33 +0,0 @@ -LC_ALL=3DC \ -PATH=3D/bin \ -HOME=3D/var/lib/libvirt/qemu/domain--1-QEMUGuest1 \ -USER=3Dtest \ -LOGNAME=3Dtest \ -XDG_DATA_HOME=3D/var/lib/libvirt/qemu/domain--1-QEMUGuest1/.local/share \ -XDG_CACHE_HOME=3D/var/lib/libvirt/qemu/domain--1-QEMUGuest1/.cache \ -XDG_CONFIG_HOME=3D/var/lib/libvirt/qemu/domain--1-QEMUGuest1/.config \ -/usr/bin/qemu-system-x86_64 \ --name guest=3DQEMUGuest1,debug-threads=3Don \ --S \ --object '{"qom-type":"secret","id":"masterKey0","format":"raw","file":"/va= r/lib/libvirt/qemu/domain--1-QEMUGuest1/master-key.aes"}' \ --machine pc,usb=3Doff,dump-guest-core=3Doff,memory-backend=3Dpc.ram,acpi= =3Doff \ --accel tcg \ --cpu qemu64 \ --m size=3D219136k \ --object '{"qom-type":"memory-backend-ram","id":"pc.ram","size":224395264}'= \ --overcommit mem-lock=3Doff \ --smp 1,sockets=3D1,cores=3D1,threads=3D1 \ --uuid c7a5fdbd-edaf-9455-926a-d65c16db1809 \ --display none \ --no-user-config \ --nodefaults \ --chardev socket,id=3Dcharmonitor,fd=3D1729,server=3Don,wait=3Doff \ --mon chardev=3Dcharmonitor,id=3Dmonitor,mode=3Dcontrol \ --rtc base=3Dutc \ --no-shutdown \ --boot strict=3Don \ --usb \ --audiodev '{"id":"audio1","driver":"none"}' \ --device '{"driver":"virtio-balloon-pci","id":"balloon0","bus":"pci.0","add= r":"0x2"}' \ --sandbox on,obsolete=3Ddeny,elevateprivileges=3Ddeny,spawn=3Ddeny,resource= control=3Ddeny \ --msg timestamp=3Don diff --git a/tests/qemuxmlconfdata/usb-controller-default-unavailable-i440f= x.x86_64-latest.err b/tests/qemuxmlconfdata/usb-controller-default-unavaila= ble-i440fx.x86_64-latest.err new file mode 100644 index 0000000000..7a71aa107d --- /dev/null +++ b/tests/qemuxmlconfdata/usb-controller-default-unavailable-i440fx.x86_6= 4-latest.err @@ -0,0 +1 @@ +unsupported configuration: no model provided for USB controller diff --git a/tests/qemuxmlconfdata/usb-controller-implicit-isapc.x86_64-lat= est.args b/tests/qemuxmlconfdata/usb-controller-implicit-isapc.x86_64-lates= t.args index 62dc26ee8b..cf8a176cd8 100644 --- a/tests/qemuxmlconfdata/usb-controller-implicit-isapc.x86_64-latest.args +++ b/tests/qemuxmlconfdata/usb-controller-implicit-isapc.x86_64-latest.args @@ -26,7 +26,6 @@ XDG_CONFIG_HOME=3D/var/lib/libvirt/qemu/domain--1-QEMUGue= st1/.config \ -rtc base=3Dutc \ -no-shutdown \ -boot strict=3Don \ --usb \ -audiodev '{"id":"audio1","driver":"none"}' \ -sandbox on,obsolete=3Ddeny,elevateprivileges=3Ddeny,spawn=3Ddeny,resource= control=3Ddeny \ -msg timestamp=3Don diff --git a/tests/qemuxmlconftest.c b/tests/qemuxmlconftest.c index 11fcaf2660..417b5e5900 100644 --- a/tests/qemuxmlconftest.c +++ b/tests/qemuxmlconftest.c @@ -1867,13 +1867,15 @@ mymain(void) DO_TEST_CAPS_ARCH_LATEST("usb-controller-default-mac99", "ppc64"); DO_TEST_CAPS_ARCH_LATEST("usb-controller-default-mac99ppc", "ppc"); DO_TEST_CAPS_ARCH_LATEST("usb-controller-default-powernv9", "ppc64"); - /* i440fx downgrades to use '-usb' if the explicit controller is not p= resent */ + /* Until qemu-8.1 (see commit 6fe4464c05f) it was possible to compile + * out USB support from i440fx; the implicit -usb controller still fai= led */ DO_TEST_FULL("usb-controller-default-unavailable-i440fx", ".x86_64-lat= est", ARG_CAPS_ARCH, "x86_64", ARG_CAPS_VER, "latest", + ARG_FLAGS, FLAG_EXPECT_FAILURE, ARG_QEMU_CAPS_DEL, QEMU_CAPS_PIIX3_USB_UHCI, QEMU_CAPS_LA= ST, ARG_END); - /* q35 fails instead */ + /* The implicit controller can be compiled out for q35; initialization= fails though */ DO_TEST_FULL("usb-controller-default-unavailable-q35", ".x86_64-latest= ", ARG_CAPS_ARCH, "x86_64", ARG_CAPS_VER, "latest", --=20 2.43.0 _______________________________________________ Devel mailing list -- devel@lists.libvirt.org To unsubscribe send an email to devel-leave@lists.libvirt.org