From nobody Sun Feb 8 19:21:19 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1652882532; cv=none; d=zohomail.com; s=zohoarc; b=XFCHhmPnPB97214q55It9z5iC88tOgOUS0yk3eEt0pcG6+Hep+GFPQMaXDD9c+d1xM5y817S9xYf8eVTXHS5E6u3d2cFmI0fbkiMiyaOS3I3Yx/oW1ATZkuv+X2P1N/zm8wa0D2MYvFWTY0SN+vwjzACcCHyP1j95s7gdfi2j9o= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1652882532; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=jPISToqsEgp7hiE5cFpfksUAC6Ngk/JnezebiJWBRa4=; b=TWj03OJOflIDSN/tUYCze0AdKQvHgw1FGZeZfWzgmthIBUO/Vs+p+i8doApi7C36maL7LF6WYFoq1V5ZdeELcPKhB48rPW95Cd3ksmzaiCxgcDV0x90XY/tyL3RxGKAH+fXDho0hFeKWo/dwYOR5/PCJOXpsBVSihIQDiViM4Hg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1652882532991663.5654128464181; Wed, 18 May 2022 07:02:12 -0700 (PDT) Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-287-3aUoTTTBMYKToWBYNxvOoQ-1; Wed, 18 May 2022 10:01:28 -0400 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 0A50F29AB442; Wed, 18 May 2022 14:01:10 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (unknown [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id E95351410F36; Wed, 18 May 2022 14:01:09 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 9D66E1947B91; Wed, 18 May 2022 14:01:09 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 61B021947B8F for ; Wed, 18 May 2022 14:01:03 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id 53B6F492CA2; Wed, 18 May 2022 14:01:03 +0000 (UTC) Received: from hjs.redhat.com (unknown [10.43.2.85]) by smtp.corp.redhat.com (Postfix) with ESMTP id EEB5C492C3B for ; Wed, 18 May 2022 14:01:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1652882532; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=jPISToqsEgp7hiE5cFpfksUAC6Ngk/JnezebiJWBRa4=; b=LvWT1P6ud28uxpYwfpjcxaJhh6OHL4NZQlWksoWqxwWkk+EvN1KrHA2q2gkrZTTccRAxeI xO61yfhhHCfMyW+oiS5cXJDCIT2ZrK+tW+YL4pwY30I7ZHOLNVO8nogaAmiuYZh+kFe4MA k80EFk0XuPHysz3TE/HIZIgIS6Yccwk= X-MC-Unique: 3aUoTTTBMYKToWBYNxvOoQ-1 X-Original-To: libvir-list@listman.corp.redhat.com From: =?UTF-8?q?J=C3=A1n=20Tomko?= To: libvir-list@redhat.com Subject: [libvirt PATCH 2/5] src: QemuMonitorCommandWithFiles: report error when fd passing is unsupported Date: Wed, 18 May 2022 16:00:57 +0200 Message-Id: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.85 on 10.11.54.9 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 2.85 on 10.11.54.7 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1652882534421100001 The result of the <=3D 0 comparison was assigned to 'rc', rendering the if (rc =3D=3D 0) condition dead code. Signed-off-by: J=C3=A1n Tomko --- src/libvirt-qemu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/libvirt-qemu.c b/src/libvirt-qemu.c index 5020b5dc1b..ace91e8ada 100644 --- a/src/libvirt-qemu.c +++ b/src/libvirt-qemu.c @@ -161,7 +161,7 @@ virDomainQemuMonitorCommandWithFiles(virDomainPtr domai= n, if (ninfiles > 0 || outfiles) { int rc; if ((rc =3D VIR_DRV_SUPPORTS_FEATURE(conn->driver, conn, - VIR_DRV_FEATURE_FD_PASSING) <= =3D 0)) { + VIR_DRV_FEATURE_FD_PASSING)) <= =3D 0) { if (rc =3D=3D 0) virReportError(VIR_ERR_ARGUMENT_UNSUPPORTED, "%s", _("fd passing is not supported by this conn= ection")); --=20 2.34.1