From nobody Wed Dec 17 04:12:41 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) client-ip=170.10.129.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1681733356; cv=none; d=zohomail.com; s=zohoarc; b=AMVzrIHTJDPArrwC04Naz3iDnXDP1TTWlGCdI4KrwkbdLdSLsUPIeA/BOK88VV0u43y+gCDvjKSe6yJjx1Y4zfjtTs7VV1H9NvfaAyVJESzPwij/nD4euLIjPYU0dT9JhzOKvgWthuhDV33XMKgcyTGmxn8NNfee2hOXCw8viwA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1681733356; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=evkfEd/f/RKFwfqrAeYRfYJ0YydynKpRfKjUXzsF6lk=; b=AHsI6BSt2Yjk3vhSHHUb8AB5x0pusB7hGdDe7BYRqVChA4uXUwOtH+6yPC5uVgY16dZvE1fEvQ87mMjLKPuRThOA8rp/nSYuXkeDQbBMFQ7ZixuWeJcheqEdnjbGP0bQJ3vBgCRTAe7iiqSRYpF2cZizBTpv12IpxeWsrCmLn/A= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.zohomail.com with SMTPS id 1681733356780532.8275514481495; Mon, 17 Apr 2023 05:09:16 -0700 (PDT) Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-201--eHnJdf9Ni-7Fr0fn25-kw-1; Mon, 17 Apr 2023 08:09:11 -0400 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 8B2CF3C1069A; Mon, 17 Apr 2023 12:09:08 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (unknown [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id 74B2C40CE2D4; Mon, 17 Apr 2023 12:09:08 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 594A3194658D; Mon, 17 Apr 2023 12:09:08 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 9A3C0194658C for ; Mon, 17 Apr 2023 12:09:06 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id 7FA91492B03; Mon, 17 Apr 2023 12:09:06 +0000 (UTC) Received: from localhost.localdomain (unknown [10.43.2.39]) by smtp.corp.redhat.com (Postfix) with ESMTP id 27121492B10 for ; Mon, 17 Apr 2023 12:09:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1681733355; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=evkfEd/f/RKFwfqrAeYRfYJ0YydynKpRfKjUXzsF6lk=; b=U0+3issQfSfjtDSq0u29Rgjfaiyb87sYbjYnXYmsq/zhA85fHHOxOJajdv+zSFyS0H7GDe LaS36ifaUomHVUTfzqlYk1Nl/8u2piAjnMYkcHJ3QZJKpYcYuVDp7j6PtSRVY6clvtxSRl 95Hn/G+itt7vtU+fok/LXeO4LRAKGQ4= X-MC-Unique: -eHnJdf9Ni-7Fr0fn25-kw-1 X-Original-To: libvir-list@listman.corp.redhat.com From: Michal Privoznik To: libvir-list@redhat.com Subject: [PATCH 3/3] networkRefreshDhcpDaemon: Get dnsmasq's PID once Date: Mon, 17 Apr 2023 14:09:03 +0200 Message-Id: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.10 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 3.1 on 10.11.54.1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1681733358200100005 Content-Type: text/plain; charset="utf-8"; x-default="true" This is a relict of v3.7.0-rc1~132 when getter/setter APIs for dnsmasq's PID were introduced. Previously, obj->dnsmasqPid was accessed directly. But the aforementioned commit introduced two calls to virNetworkObjGetDnsmasqPid() even though the result of the first call is stored in a variable. Remove the second call as it's unnecessary. Signed-off-by: Michal Privoznik --- src/network/bridge_driver.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/network/bridge_driver.c b/src/network/bridge_driver.c index 7f2298a15e..9eb543a0a3 100644 --- a/src/network/bridge_driver.c +++ b/src/network/bridge_driver.c @@ -1599,7 +1599,6 @@ networkRefreshDhcpDaemon(virNetworkDriverState *drive= r, if (dnsmasqSave(dctx) < 0) return -1; =20 - dnsmasqPid =3D virNetworkObjGetDnsmasqPid(obj); return kill(dnsmasqPid, SIGHUP); =20 } --=20 2.39.2