From nobody Tue Sep 9 03:19:43 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=reject dis=none) header.from=lists.libvirt.org ARC-Seal: i=1; a=rsa-sha256; t=1747814861; cv=none; d=zohomail.com; s=zohoarc; b=gCSZE7E/llZhrNlkaygML5ux4VPZhIxyY1uylF87mYdzxlR14hQ0lNTPN7vxOACFQTEsOib5g5G4TjWgr06jhtpb4xkeOvU3wE9vgshs5l3qDxIGzVqRVGwFkTQaLEGhsAU/EkyxWqjAGPmdyUETtRPh0llERJZhNlO5BPEn7V4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1747814861; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Subject:Subject:To:To:Message-Id:Cc; bh=HJi9TshpQ8eBD21x04lDcVKzwm4s97b6eQnvaB9NVyI=; b=BjF2FbaOhlpd0ANcpCK7nFlVlp5am/aqfrxqoBiXX0rDvsN1t884aBk3IkYIKOWSTp+Q8WTFgBgFps+00RQT+8ZUfwHa8E/qNXoK8m3k/hV7bc+98kmJPUD1wCT6At+N4vo10wFXnnS+ueDiDqv7RCdYL1ay3a1tr/V+Jbv6jjo= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1747814861579301.1179852338395; Wed, 21 May 2025 01:07:41 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 996) id 9169F145C; Wed, 21 May 2025 04:07:40 -0400 (EDT) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id 96FC71878; Wed, 21 May 2025 04:06:47 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 996) id DBC0E1413; Wed, 21 May 2025 04:06:39 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 82A701458 for ; Wed, 21 May 2025 04:06:39 -0400 (EDT) Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-687-OFrdbXvkN9ykORTxiULvFQ-1; Wed, 21 May 2025 04:06:38 -0400 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 57C571956046 for ; Wed, 21 May 2025 08:06:37 +0000 (UTC) Received: from speedmetal.lan (unknown [10.44.22.37]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 86DEA180049D for ; Wed, 21 May 2025 08:06:36 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_HELO_NONE autolearn=unavailable autolearn_force=no version=3.4.4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1747814799; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=sT2uCY9XpUJ4L16zqrClXFK3B49llgmaVq3RBrmqjAw=; b=PsYJFEuom6z2bP3cg27Cdjd28x0u+v73uJpTU/GaO19Vsw4X9Aj+hylk8GUcBmP04Au7j7 sl5ZhoDbeXetqkHjEbniru6KD+HbPkXF98n2tyVaxQXJuooxszXrCvxzSok/BjP4MZeFG4 u5wZ9NXAwbUZepEh9YmWajg1E4gRNU4= X-MC-Unique: OFrdbXvkN9ykORTxiULvFQ-1 X-Mimecast-MFC-AGG-ID: OFrdbXvkN9ykORTxiULvFQ_1747814797 To: devel@lists.libvirt.org Subject: [PATCH 2/2] qemuMonitorJSONMigrate: Drop 'detach' QMP option Date: Wed, 21 May 2025 10:06:32 +0200 Message-ID: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: SWB6TN8iJzgE-kAVlEGR1DyF-BTWAykvcvEL0zSu72A_1747814797 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: ZRXCWIFGMMTB2CGFN7AETVPWKNR4XG3B X-Message-ID-Hash: ZRXCWIFGMMTB2CGFN7AETVPWKNR4XG3B X-MailFrom: pkrempa@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: From: Peter Krempa via Devel Reply-To: Peter Krempa X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1747814861916116600 Content-Type: text/plain; charset="utf-8" From: Peter Krempa The argument was always ignored by qemu [1], as of qemu-10.1 it will be deprecated. As it was always unused/ignored we can drop it without any extra logic. [1] qemu docs state: 3. The user Monitor's "detach" argument is invalid in QMP and should not be used. Signed-off-by: Peter Krempa --- src/qemu/qemu_monitor_json.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/qemu/qemu_monitor_json.c b/src/qemu/qemu_monitor_json.c index 3c2b35575e..a6fb2a2013 100644 --- a/src/qemu/qemu_monitor_json.c +++ b/src/qemu/qemu_monitor_json.c @@ -3198,7 +3198,6 @@ int qemuMonitorJSONMigrate(qemuMonitor *mon, { bool resume =3D !!(flags & QEMU_MONITOR_MIGRATE_RESUME); g_autoptr(virJSONValue) cmd =3D qemuMonitorJSONMakeCommand("migrate", - "b:detach", t= rue, "b:resume", r= esume, "s:uri", uri, NULL); --=20 2.49.0