From nobody Mon Feb 9 10:15:49 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1725540320731424.6510856556648; Thu, 5 Sep 2024 05:45:20 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 996) id 99D75164E; Thu, 5 Sep 2024 08:45:19 -0400 (EDT) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id 9D7881730; Thu, 5 Sep 2024 08:44:14 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 996) id 84F1E162A; Thu, 5 Sep 2024 08:44:06 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 17AE715E1 for ; Thu, 5 Sep 2024 08:44:06 -0400 (EDT) Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-298-CtagcTX2PVGy8Md5Md5IrQ-1; Thu, 05 Sep 2024 08:44:04 -0400 Received: from mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.40]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 719FD1944AA9 for ; Thu, 5 Sep 2024 12:44:03 +0000 (UTC) Received: from speedmetal.redhat.com (unknown [10.45.242.24]) by mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id B3F021955F44 for ; Thu, 5 Sep 2024 12:44:02 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: *** X-Spam-Status: No, score=3.0 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,RCVD_IN_SBL_CSS,SPF_HELO_NONE, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1725540245; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=TlDl9YEeNp/ccVrBSf9njAxXsd8qmRXaDOd7dc+21Ic=; b=GA/GVCiVgkd5oWBUYXnYzIQKZv/EyWLEKp2ZlCYDL3K4r7kSmyDUngEQ4MAln1bbjXSNox aUIfEIzzNodQfUQ0p2pRqdwdAHlyRL/ssdZFFisg3p2BBkkcNbp10bvdz3Ukc2QfmS7pMo uvxN0WXe2bZdDE1Q+x7XE1shAdOpR1U= X-MC-Unique: CtagcTX2PVGy8Md5Md5IrQ-1 From: Peter Krempa To: devel@lists.libvirt.org Subject: [PATCH 3/3] virshtest: Add test case for script friendly options Date: Thu, 5 Sep 2024 14:43:57 +0200 Message-ID: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.40 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: D6UXUGJSJHNPS2DRKDON4J3FDQOGGZ2D X-Message-ID-Hash: D6UXUGJSJHNPS2DRKDON4J3FDQOGGZ2D X-MailFrom: pkrempa@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1725540322881116600 Content-Type: text/plain; charset="utf-8" Add a bunch of tests verifying that script-friendly options of certain commands are not changed incompatibly thus potentially breaking user scripts. Signed-off-by: Peter Krempa --- This sample represents what 'libvirt-guests' uses and what I thought off. Feel free to suggest more. tests/virshtest.c | 2 ++ .../virshtestdata/script-friendly-options.in | 11 +++++++ .../virshtestdata/script-friendly-options.out | 33 +++++++++++++++++++ 3 files changed, 46 insertions(+) create mode 100644 tests/virshtestdata/script-friendly-options.in create mode 100644 tests/virshtestdata/script-friendly-options.out diff --git a/tests/virshtest.c b/tests/virshtest.c index b86c39285a..a7f62df563 100644 --- a/tests/virshtest.c +++ b/tests/virshtest.c @@ -352,6 +352,8 @@ mymain(void) "checkpoint-create test --redefine checkpoint-c2.xml ;" "checkpoint-info test c2"); + DO_TEST_SCRIPT("script-friendly-options", NULL, VIRSH_CUSTOM); + /* completion doesn't work on non-readline builds */ need_readline =3D true; diff --git a/tests/virshtestdata/script-friendly-options.in b/tests/virshte= stdata/script-friendly-options.in new file mode 100644 index 0000000000..08d2a87474 --- /dev/null +++ b/tests/virshtestdata/script-friendly-options.in @@ -0,0 +1,11 @@ +echo "Following script-friendly outputs of commands must not change" +list --uuid; +list --uuid --all; +list --name; +list --name --all; +list --uuid --name --all; +domstate fv0 +domstate fv0 --reason +domname ef861801-45b9-11cb-88e3-afbfe5370493 +domid fv0 +domstats fv0 diff --git a/tests/virshtestdata/script-friendly-options.out b/tests/virsht= estdata/script-friendly-options.out new file mode 100644 index 0000000000..2ab1ba0e71 --- /dev/null +++ b/tests/virshtestdata/script-friendly-options.out @@ -0,0 +1,33 @@ +Following script-friendly outputs of commands must not change +4dea22b3-1d52-d8f3-2516-782e98ab3fa0 +ef861801-45b9-11cb-88e3-afbfe5370493 +08721f99-3d1d-4aec-96eb-97803297bb36 + +4dea22b3-1d52-d8f3-2516-782e98ab3fa0 +ef861801-45b9-11cb-88e3-afbfe5370493 +08721f99-3d1d-4aec-96eb-97803297bb36 + +fv0 +fc4 +fc5 + +fv0 +fc4 +fc5 + +4dea22b3-1d52-d8f3-2516-782e98ab3fa0 fv0 +ef861801-45b9-11cb-88e3-afbfe5370493 fc4 +08721f99-3d1d-4aec-96eb-97803297bb36 fc5 + +running + +running (unknown) + +fc4 + +1 + +Domain: 'fv0' + state.state=3D1 + state.reason=3D0 + --=20 2.46.0