From nobody Sun Feb 8 06:04:41 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 207.211.31.81 as permitted sender) client-ip=207.211.31.81; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-1.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 207.211.31.81 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com Return-Path: Received: from us-smtp-delivery-1.mimecast.com (us-smtp-2.mimecast.com [207.211.31.81]) by mx.zohomail.com with SMTPS id 1580207541492804.7465233045388; Tue, 28 Jan 2020 02:32:21 -0800 (PST) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-419-TMMWa2F0Mmetv3BAMeF6GQ-1; Tue, 28 Jan 2020 05:32:18 -0500 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 5D8CB18C43C7; Tue, 28 Jan 2020 10:32:12 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 3523A60BE0; Tue, 28 Jan 2020 10:32:12 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id CD1F585977; Tue, 28 Jan 2020 10:32:11 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 00SAVdwM014030 for ; Tue, 28 Jan 2020 05:31:39 -0500 Received: by smtp.corp.redhat.com (Postfix) id 811AB5C3FA; Tue, 28 Jan 2020 10:31:39 +0000 (UTC) Received: from lpt.redhat.com (unknown [10.43.2.17]) by smtp.corp.redhat.com (Postfix) with ESMTP id 0C4165C21B for ; Tue, 28 Jan 2020 10:31:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1580207540; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=JjimbbMTNG6e+gyAQll3IbidkCEn+A+RYF4KAt6V7x8=; b=fE9S63ZCZwhokNmo9CQ4+26b5JLFe1chKX2uYdgi2ep736lAx0bWRYsMrBK59FY4v3jlSC 9PKDVxR5Bw7eB5R/D8mYekrpirA5NNw6eM+kzL81LfAiXTO5vyficY9p3EWWcFC2LnU+b2 53pbBnx4C9nINuhTbBtPcpdn4A48S2U= From: =?UTF-8?q?J=C3=A1n=20Tomko?= To: libvir-list@redhat.com Subject: [libvirt PATCH 06/10] conf: remove outdated comments Date: Tue, 28 Jan 2020 11:31:22 +0100 Message-Id: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-MC-Unique: TMMWa2F0Mmetv3BAMeF6GQ-1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" Some *ParseXML functions have comments stating what kind of device they parse with an outdated list of parameters, with the exception of virDomainFSDefParseXML which claims to parse a disk. Remove them, assuming the function names are descriptive enough. Signed-off-by: J=C3=A1n Tomko Reviewed-by: Peter Krempa --- src/conf/domain_conf.c | 17 ----------------- 1 file changed, 17 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 853cfddf1b..70501c4ffc 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -7598,9 +7598,6 @@ virDomainDeviceAliasIsUserAlias(const char *aliasStr) } =20 =20 -/* Parse the XML definition for a device address - * @param node XML nodeset to parse for device address definition - */ static int virDomainDeviceInfoParseXML(virDomainXMLOptionPtr xmlopt G_GNUC_UNUSED, xmlNodePtr node, @@ -10040,9 +10037,6 @@ virDomainDiskDefParsePrivateData(xmlXPathContextPtr= ctxt, #define VENDOR_LEN 8 #define PRODUCT_LEN 16 =20 -/* Parse the XML definition for a disk - * @param node XML nodeset to parse for disk definition - */ static virDomainDiskDefPtr virDomainDiskDefParseXML(virDomainXMLOptionPtr xmlopt, xmlNodePtr node, @@ -10721,9 +10715,6 @@ virDomainControllerModelTypeToString(virDomainContr= ollerDefPtr def, } =20 =20 -/* Parse the XML definition for a controller - * @param node XML nodeset to parse for controller definition - */ static virDomainControllerDefPtr virDomainControllerDefParseXML(virDomainXMLOptionPtr xmlopt, xmlNodePtr node, @@ -11094,9 +11085,6 @@ virDomainNetGenerateMAC(virDomainXMLOptionPtr xmlop= t, } =20 =20 -/* Parse the XML definition for a disk - * @param node XML nodeset to parse for disk definition - */ static virDomainFSDefPtr virDomainFSDefParseXML(virDomainXMLOptionPtr xmlopt, xmlNodePtr node, @@ -11521,10 +11509,6 @@ virDomainChrSourceReconnectDefParseXML(virDomainCh= rSourceReconnectDefPtr def, } =20 =20 -/* Parse the XML definition for a network interface - * @param node XML nodeset to parse for net definition - * @return 0 on success, -1 on failure - */ static virDomainNetDefPtr virDomainNetDefParseXML(virDomainXMLOptionPtr xmlopt, xmlNodePtr node, @@ -12909,7 +12893,6 @@ virDomainChrDefNew(virDomainXMLOptionPtr xmlopt) } =20 /* Parse the XML definition for a character device - * @param node XML nodeset to parse for net definition * * The XML we're dealing with looks like * --=20 2.21.0