From nobody Fri Nov 21 10:01:45 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=reject dis=none) header.from=lists.libvirt.org ARC-Seal: i=1; a=rsa-sha256; t=1762527223; cv=none; d=zohomail.com; s=zohoarc; b=Je3bb6UatWKt+M3X9URjAyuzA5AnokGaWXOZd89oGwZnT+FJdnFTmANMP3ag8mJY1P4XgaH+WOAOHKO7rlvHWY2PbmTdOHd2jGALiJdSvBbwL3S2YHaXaJIuVKaJiCuMQbyGwZR5U2/Bf4jsnM3vcbOx42ak1EWWfaasZpHQT5U= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1762527223; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:List-Subscribe:List-Post:List-Owner:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:Subject:Subject:To:To:Message-Id:Cc; bh=6dUmZkcebW3gf/PBtkQfDHhfeqmV39kQseAnqEX8vvE=; b=EORuyqxSddwoLxKR+5LMkbsTv+uGWS7P13xEEu7Q+wnRbjp1BvKDv4TjWhXuzWif73dNAXIBcuBun4QW6XfH8nta99AdRR7Vzoh2+JRgBvYK0H1ZlKidsCKAqda++v1vqAGZcsvtMcxbe/IqTsGV9/IcmWmAYAnPf2hMUVAU+Ug= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1762527223539296.7055935457166; Fri, 7 Nov 2025 06:53:43 -0800 (PST) Received: by lists.libvirt.org (Postfix, from userid 993) id E5F974429F; Fri, 7 Nov 2025 09:53:38 -0500 (EST) Received: from [172.19.199.29] (lists.libvirt.org [8.43.85.245]) by lists.libvirt.org (Postfix) with ESMTP id 3945C443E8; Fri, 7 Nov 2025 09:52:27 -0500 (EST) Received: by lists.libvirt.org (Postfix, from userid 993) id 3C4E344288; Fri, 7 Nov 2025 09:52:15 -0500 (EST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (3072 bits) server-digest SHA256) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 0EB5F4426C for ; Fri, 7 Nov 2025 09:52:13 -0500 (EST) Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-58-tyV5_n5DNzqzZMCxHpm2vg-1; Fri, 07 Nov 2025 09:52:11 -0500 Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 463321959BEF for ; Fri, 7 Nov 2025 14:52:09 +0000 (UTC) Received: from fedora.redhat.com (unknown [10.45.224.179]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 4E69A18002A6 for ; Fri, 7 Nov 2025 14:52:08 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-5.0 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_PASS autolearn=unavailable autolearn_force=no version=4.0.1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1762527132; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=6dUmZkcebW3gf/PBtkQfDHhfeqmV39kQseAnqEX8vvE=; b=RklrPcSRcUvhAzzIGJ/s26C7T36iJIlDshpfwL8UjbyHroCY2gdDXvWDCQwP3O/cywOXEH VY0wWgenK04vBxXEtiF69+734iz+Je0ogThgchYM4+iCKetAGJjbnRFrLNF2CkdM3XBmtq 7tVxs0Xoru/NNymliP4DkHa98CmP9es= X-MC-Unique: tyV5_n5DNzqzZMCxHpm2vg-1 X-Mimecast-MFC-AGG-ID: tyV5_n5DNzqzZMCxHpm2vg_1762527130 To: devel@lists.libvirt.org Subject: [libvirt PATCH] scripts: do not use uninitialized variable Date: Fri, 7 Nov 2025 15:51:53 +0100 Message-ID: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: z7PgWCRwg_A0t3NCRuDUMywoULVqxHBtz7rsUaavKAM_1762527130 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-ID-Hash: AGJV5PJHTA5LFY7QJYB47QAJTBALXYOZ X-Message-ID-Hash: AGJV5PJHTA5LFY7QJYB47QAJTBALXYOZ X-MailFrom: jtomko@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-devel.lists.libvirt.org-0; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: =?utf-8?q?J=C3=A1n_Tomko_via_Devel?= Reply-To: =?UTF-8?q?J=C3=A1n=20Tomko?= X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1762527226555154100 From: J=C3=A1n Tomko A previous commit removed the 'ret' variable when switching to subprocess.run, but did not adjust the exit code. Fixes: 15c9ca383c2a814c61cc4ed16b4dad91221d8129 Signed-off-by: J=C3=A1n Tomko --- Pushed as a build fix. scripts/check-file-access.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/check-file-access.py b/scripts/check-file-access.py index 71130d4dec..42c9c6b989 100755 --- a/scripts/check-file-access.py +++ b/scripts/check-file-access.py @@ -42,7 +42,7 @@ proc =3D subprocess.run(sys.argv[1:]) if proc.returncode !=3D 0 or os.read(access_fd, 10) =3D=3D b'': os.close(access_fd) os.remove(access_file) - sys.exit(ret) + sys.exit(proc.returncode) =20 known_actions =3D ["open", "fopen", "access", "stat", "lstat", "connect"] =20 --=20 2.51.1