From nobody Sun Feb 8 18:08:54 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1690961393; cv=none; d=zohomail.com; s=zohoarc; b=gG4EuBFr0qqf2ecg1zq32C2uUHymSTDfWOMCIt3oG6/P2BA+X9TAE8iUPv8DHbx5IC40gJcYXicUH+F7v++VOc6p8jvaXK2qHcWXmM2LH6WRDiwTOfOnE5pvuLrGotp7A3iAWFXDiQ6iW/nAsYLqBE3jzahngxu/GcDukgY0h5A= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1690961393; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=oBNitTgBblV58MCalQJJVeJZhQAo1oSwPX5dmqsxsq4=; b=ca1mn3t/aARvEplBA2rw64gU24s9fqXNDpSby2KZQFyXcR8jfA8rfDeCn+Z2zemKXVS08/MRyMjM+klMkq6X3b26YPB8XqOjOR7ckXv3APOWw7GpqiVWRwfmzaZUQ8oto/+bODJkoO/YLiZivrm+ZIamzVKcJpASSdQMtF9e9AI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1690961393625559.7452863754291; Wed, 2 Aug 2023 00:29:53 -0700 (PDT) Received: from mimecast-mx02.redhat.com (66.187.233.73 [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-424-IOJEMdxLPLK175hnW9gO2w-1; Wed, 02 Aug 2023 03:29:48 -0400 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 6022629AA384; Wed, 2 Aug 2023 07:29:46 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (unknown [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id 4A604C57963; Wed, 2 Aug 2023 07:29:46 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 2E1F01946A45; Wed, 2 Aug 2023 07:29:46 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 122FB194720E for ; Wed, 2 Aug 2023 07:29:45 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id 045BA112132D; Wed, 2 Aug 2023 07:29:45 +0000 (UTC) Received: from speedmetal.lan (unknown [10.45.242.15]) by smtp.corp.redhat.com (Postfix) with ESMTP id 7D8D21121325 for ; Wed, 2 Aug 2023 07:29:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1690961392; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=oBNitTgBblV58MCalQJJVeJZhQAo1oSwPX5dmqsxsq4=; b=NozZUL1nBnGlePS9oPLS50Dxlj6vNah4yR+jjAmB5jJpyWxxSyEK2gVi4KmTJ6Krj4p+hn 2yUhUQ0b3tdpd4QOKTsUlK6s6lgdYu0I0UT3eJLneo6MU1rp8w9IFzxcFdop4fphR18IbV 7O3cGrrD7kwxYPj6eFD6ZnhZL9iU6kk= X-MC-Unique: IOJEMdxLPLK175hnW9gO2w-1 X-Original-To: libvir-list@listman.corp.redhat.com From: Peter Krempa To: libvir-list@redhat.com Subject: [PATCH 1/3] virLXCControllerSetupUsernsMap: Modify debug logging for clean startup errors Date: Wed, 2 Aug 2023 09:29:40 +0200 Message-ID: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.3 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 3.1 on 10.11.54.8 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1690961394642100001 Content-Type: text/plain; charset="utf-8" Avoid logging multiline debug logs so that the function which attempts to extract a non-debug log error message can work properly. Signed-off-by: Peter Krempa --- src/lxc/lxc_controller.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/src/lxc/lxc_controller.c b/src/lxc/lxc_controller.c index 86dcd880e8..ba7f15ad24 100644 --- a/src/lxc/lxc_controller.c +++ b/src/lxc/lxc_controller.c @@ -1359,11 +1359,13 @@ virLXCControllerSetupUsernsMap(virDomainIdMapEntry = *map, return -1; } - for (i =3D 0; i < num; i++) + VIR_DEBUG("Set '%s' mappings to:", path); + + for (i =3D 0; i < num; i++) { + VIR_DEBUG("%u %u %u", map[i].start, map[i].target, map[i].count); virBufferAsprintf(&map_value, "%u %u %u\n", map[i].start, map[i].target, map[i].count); - - VIR_DEBUG("Set '%s' to '%s'", path, virBufferCurrentContent(&map_value= )); + } if (virFileWriteStr(path, virBufferCurrentContent(&map_value), 0) < 0)= { virReportSystemError(errno, _("unable write to %1$s"), path); --=20 2.41.0