From nobody Sun Feb 8 19:03:01 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 205.139.110.61 as permitted sender) client-ip=205.139.110.61; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-1.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zoho.com: domain of redhat.com designates 205.139.110.61 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1574258905; cv=none; d=zoho.com; s=zohoarc; b=QNGc8239kkngXDMn1ItABkYnKMoXp1b4g4lNZxC9sB05a9KHgk8JgnzVVK1VH7MnGY1JUwvOwoeOcUr9U/wJPMdmJTrRq6oPbRMwZ4+NL6pV5gRFw/62FVu5zReJ8mF+ajUdbvqp7/QbQWsCkJuwtGRsrR9x/yoNGrI4B3vGQNo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1574258905; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=avaKDhvq1ZynUbFQQftQ838hX2bmTkvqG9fvaTkJQpc=; b=KOhqcTbUQohhv5veGotOL+3PX/hgQh7kMIrht26slqJYzP0ZfwLRcE5KgfIgtVKdopIF9xDG99yAPlr0U58SWUi/4dCy96jh6h49KsBQuZuCOt6gs2IOrK1u+rx+KK+Nc0m6BiGD1cxtlOW4s5ejA/pjzqIhL4tTnz7jDdrHSso= ARC-Authentication-Results: i=1; mx.zoho.com; dkim=pass; spf=pass (zoho.com: domain of redhat.com designates 205.139.110.61 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-1.mimecast.com (us-smtp-2.mimecast.com [205.139.110.61]) by mx.zohomail.com with SMTPS id 157425890557998.66040018405886; Wed, 20 Nov 2019 06:08:25 -0800 (PST) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-152-J-d5WhoiNRyx3w6btzAVvA-1; Wed, 20 Nov 2019 09:08:23 -0500 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id DE0F618C35A7; Wed, 20 Nov 2019 14:08:15 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id B198828DD9; Wed, 20 Nov 2019 14:08:15 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 6EB771808878; Wed, 20 Nov 2019 14:08:15 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id xAKE81JV003167 for ; Wed, 20 Nov 2019 09:08:01 -0500 Received: by smtp.corp.redhat.com (Postfix) id D66591036C7E; Wed, 20 Nov 2019 14:08:01 +0000 (UTC) Received: from antique-work.redhat.com (unknown [10.43.2.149]) by smtp.corp.redhat.com (Postfix) with ESMTP id 6186A1036C6C for ; Wed, 20 Nov 2019 14:08:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1574258904; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=avaKDhvq1ZynUbFQQftQ838hX2bmTkvqG9fvaTkJQpc=; b=UPNqxUTZw0AhTYJ3piymQld3y0YeaiTia0Tzp5XS4ESWF3CF+h1K9MqbF9fMdV3CD9qWDU e2YK+wU5fCjvH4YL+QihCugWunHkvQfhAg2ktgVyjbAZgHn+B6Q1Y2EG8UsDu9tGACupl9 dXSHMW6Be/8GbQyKRmwU/1G8Sx+VBdo= From: Pavel Hrdina To: libvir-list@redhat.com Date: Wed, 20 Nov 2019 15:07:45 +0100 Message-Id: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-loop: libvir-list@redhat.com Subject: [libvirt] [PATCH 03/13] use g_ascii_isalpha instead of c_isalpha from gnulib X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-MC-Unique: J-d5WhoiNRyx3w6btzAVvA-1 X-Mimecast-Spam-Score: 0 Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" Signed-off-by: Pavel Hrdina --- src/conf/network_conf.c | 3 +-- src/qemu/qemu_domain.c | 3 +-- src/qemu/qemu_qapi.c | 4 +--- src/util/virconf.c | 2 +- src/util/virfile.c | 4 ++-- 5 files changed, 6 insertions(+), 10 deletions(-) diff --git a/src/conf/network_conf.c b/src/conf/network_conf.c index 6970831593..5551b5b4d5 100644 --- a/src/conf/network_conf.c +++ b/src/conf/network_conf.c @@ -37,7 +37,6 @@ #include "virxml.h" #include "viruuid.h" #include "virbuffer.h" -#include "c-ctype.h" #include "virfile.h" #include "virstring.h" =20 @@ -482,7 +481,7 @@ virNetworkDHCPHostDefParseXML(const char *networkName, } =20 name =3D virXMLPropString(node, "name"); - if (name && (!c_isalpha(name[0]))) { + if (name && (!g_ascii_isalpha(name[0]))) { virReportError(VIR_ERR_XML_ERROR, _("Cannot use host name '%s' in network '%s'"), name, networkName); diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c index f54b9b21ff..5eea0ebcd7 100644 --- a/src/qemu/qemu_domain.c +++ b/src/qemu/qemu_domain.c @@ -40,7 +40,6 @@ #include "viralloc.h" #include "virlog.h" #include "virerror.h" -#include "c-ctype.h" #include "cpu/cpu.h" #include "viruuid.h" #include "virfile.h" @@ -3768,7 +3767,7 @@ qemuDomainDefNamespaceParseCommandlineArgs(qemuDomain= XmlNsDefPtr nsdef, static int qemuDomainDefNamespaceParseCommandlineEnvNameValidate(const char *envname) { - if (!c_isalpha(envname[0]) && envname[0] !=3D '_') { + if (!g_ascii_isalpha(envname[0]) && envname[0] !=3D '_') { virReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("Invalid environment name, it must begin with a l= etter or underscore")); return -1; diff --git a/src/qemu/qemu_qapi.c b/src/qemu/qemu_qapi.c index 484f274c63..15a85fd1ad 100644 --- a/src/qemu/qemu_qapi.c +++ b/src/qemu/qemu_qapi.c @@ -25,8 +25,6 @@ #include "virerror.h" #include "virlog.h" =20 -#include "c-ctype.h" - #define VIR_FROM_THIS VIR_FROM_QEMU =20 VIR_LOG_INIT("qemu.qemu_qapi"); @@ -165,7 +163,7 @@ virQEMUQAPISchemaTraverseObject(virJSONValuePtr cur, const char *query =3D virQEMUQAPISchemaTraverseContextNextQuery(ctxt); char modifier =3D *query; =20 - if (!c_isalpha(modifier)) + if (!g_ascii_isalpha(modifier)) query++; =20 /* exit on modifers for other types */ diff --git a/src/util/virconf.c b/src/util/virconf.c index 305a78b515..cde747158c 100644 --- a/src/util/virconf.c +++ b/src/util/virconf.c @@ -556,7 +556,7 @@ virConfParseName(virConfParserCtxtPtr ctxt) SKIP_BLANKS; base =3D ctxt->cur; /* TODO: probably need encoding support and UTF-8 parsing ! */ - if (!c_isalpha(CUR) && + if (!g_ascii_isalpha(CUR) && !((ctxt->conf->flags & VIR_CONF_FLAG_VMX_FORMAT) && (CUR =3D=3D '.= '))) { virConfError(ctxt, VIR_ERR_CONF_SYNTAX, _("expecting a name")); return NULL; diff --git a/src/util/virfile.c b/src/util/virfile.c index fca7ff9d35..a329f2e83f 100644 --- a/src/util/virfile.c +++ b/src/util/virfile.c @@ -3190,7 +3190,7 @@ virFileIsAbsPath(const char *path) return true; =20 #ifdef WIN32 - if (c_isalpha(path[0]) && + if (g_ascii_isalpha(path[0]) && path[1] =3D=3D ':' && VIR_FILE_IS_DIR_SEPARATOR(path[2])) return true; @@ -3242,7 +3242,7 @@ virFileSkipRoot(const char *path) =20 #ifdef WIN32 /* Skip X:\ */ - if (c_isalpha(path[0]) && + if (g_ascii_isalpha(path[0]) && path[1] =3D=3D ':' && VIR_FILE_IS_DIR_SEPARATOR(path[2])) return path + 3; --=20 2.23.0 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list