From nobody Sun May 5 02:34:41 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) client-ip=170.10.129.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail(p=quarantine dis=quarantine) header.from=virtuozzo.com Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.zohomail.com with SMTPS id 1652362039867261.87525385689935; Thu, 12 May 2022 06:27:19 -0700 (PDT) Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-283-CdmZzSIBP8WKYGkLHyEv9Q-1; Thu, 12 May 2022 09:27:13 -0400 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 6ECD018A6598; Thu, 12 May 2022 13:27:09 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id 552BEC28119; Thu, 12 May 2022 13:27:08 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 269A11932231; Thu, 12 May 2022 13:27:07 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 55F7F1947058 for ; Thu, 12 May 2022 13:17:15 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id 45FAB400E43D; Thu, 12 May 2022 13:17:15 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast01.extmail.prod.ext.rdu2.redhat.com [10.11.55.17]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 4119740C1247 for ; Thu, 12 May 2022 13:17:15 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-2.mimecast.com [205.139.110.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 26D7F899EC4 for ; Thu, 12 May 2022 13:17:15 +0000 (UTC) Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2136.outbound.protection.outlook.com [40.107.21.136]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-352-_7MIcUfWOC6I8JNmiTY_YQ-1; Thu, 12 May 2022 09:17:13 -0400 Received: from GV1PR08MB7380.eurprd08.prod.outlook.com (2603:10a6:150:24::7) by AS8PR08MB5912.eurprd08.prod.outlook.com (2603:10a6:20b:29f::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5250.14; Thu, 12 May 2022 13:17:11 +0000 Received: from GV1PR08MB7380.eurprd08.prod.outlook.com ([fe80::1c0f:d9bf:7e4c:4434]) by GV1PR08MB7380.eurprd08.prod.outlook.com ([fe80::1c0f:d9bf:7e4c:4434%7]) with mapi id 15.20.5227.023; Thu, 12 May 2022 13:17:11 +0000 X-MC-Unique: CdmZzSIBP8WKYGkLHyEv9Q-1 X-Original-To: libvir-list@listman.corp.redhat.com X-MC-Unique: _7MIcUfWOC6I8JNmiTY_YQ-1 From: Efim Shevrin To: "libvir-list@redhat.com" Subject: libvirt patch in master, [PATCH] Send event on persistent config modification Thread-Topic: libvirt patch in master, [PATCH] Send event on persistent config modification Thread-Index: AQHYZgHn9bDiLJHnBUOrtdkK9Ikm/Q== Date: Thu, 12 May 2022 13:17:11 +0000 Message-ID: Accept-Language: ru-RU, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: suggested_attachment_session_id: 5dee6cca-41ba-5443-ed49-226919caecf5 x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: dbc4a073-daaa-46df-1057-08da3419b930 x-ms-traffictypediagnostic: AS8PR08MB5912:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0 x-microsoft-antispam-message-info: N8aL7W8/cz2UPxVAb8QNoIiTXuBTk7AQaUEXPEMlWq1mlG+syGx0B85LulWYzxkehV0Yll9OsO7r/wvu8lZ6M/IXrr9YVjBp1kMaECmS+1TrXWbAYGRyrEUznzkU5YuolXCskXCy/MfkPAD/f+fig73CkUITIO14+QBDs/adcrV0aGIwYHM+Wd6kdLKENoHcaEpjU+TT76GfaQ2Oo++HTV+4jgB5DAiY8xKDq8x8SVH8lf3moGUq40pcl3VQ/31HxTRc7KIJ2ta8rG0wXfdsWw10Pgxuq8yJ5WrXifipL+2KWBO0at9gDuEgFVRPtRf69D6zk7l5KEIQ8QSGAR0BOpoyAqXA/GEIRp7y7vggsGqTzIUCl01gmLve0UB/FlTZanig6YWhhQwovWswsJm8LLQhngSAyAeLfDKe6L9Gsls605+tJtuOldn5awmOoe1OVcz9ZYTGWSwrlYN6rKNyHRl+h9UZLaqAQznGCUwAGSlJ6yJmqswCQ0w7JcevNyOOBnJJiW3kWdvPYraWeDAv4PpBjgNC6/DOMMyTdn45Cb7eXmcF5kOyvseXqh1nRFn/ZpKjN2JeFdsTaOw4iwrsXY4ak7I1WcJzjUkNQnEOXaFDfpuCKqhY6QEKpfhUikkm7YumFtppgZddYIWP16tiqS6QrtBVAPGVpGSpwf4F8ssEcaJ2VgNSS47bvZVLlfTos0bop7P8kwXaDBwuk/OADQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:GV1PR08MB7380.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(4636009)(366004)(508600001)(53546011)(316002)(9686003)(71200400001)(33656002)(55016003)(83380400001)(6916009)(86362001)(2906002)(66556008)(5660300002)(44832011)(66946007)(52536014)(76116006)(91956017)(66446008)(66476007)(8936002)(64756008)(186003)(6506007)(26005)(7696005)(122000001)(8676002)(38100700002)(38070700005); DIR:OUT; SFP:1102 x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?koi8-r?Q?8FwTc+SKjJ4TPNbZfX8iTqS5CKkAhwqLH6uBuGm84tj/9LNjAkCUNIcswxzEhn?= =?koi8-r?Q?m6WlWYjkRP6efs/XSXp3gWwKmHza+o3+QC3gQjlfNZqEImHMZeJrVUdjmv2kBd?= =?koi8-r?Q?s6ErTi7yNZlHYDNAig8jbh1rzCxe7CzqEmyKLgCk2/b+mEO4/BaJDoZG9UxWw1?= =?koi8-r?Q?0WqW9Tw5PJlqLlyyUHRolcFwYE7XBSK7CzNfcjCibcDIAm6h43imNSDwavyfpn?= =?koi8-r?Q?IuzxBjOVdoU2IQtZh1Cl7FOIXVAh9IpnG2uHcPXrH7WIoo+0S3rN+kvkOUNT7i?= =?koi8-r?Q?RjtKjCZMA5dsRePgT42itpuGwKyLrHYsLJrg+kaOmVKGVOOQK1smWWUb/snT2F?= =?koi8-r?Q?FrkDJ3AB2H+f6s19QIaxBDAUEpsVBCkvfTuBvm1G8vPveXnlmKl7qpsd+XWTcO?= =?koi8-r?Q?hzGDkxaxaA0MsRCSd745ihLdz1hK47+OsGk3f/pcc5wGXopE5Jqh1s8ydvdJnV?= =?koi8-r?Q?HnMfJyjXx9Sqf9uLrdcYXneHBnRF3VMTpYoZW31IdWAWjCW6Gp5wJO7URNzFcC?= =?koi8-r?Q?P/25wP9kO4+VzBHgie+fYo/P9DwHmjHOgNISxNLLScH3JpS/7UR9ZwPcZ8G8sI?= =?koi8-r?Q?6LC9yoqojgTkjLEjsHRzgHiz3eqkI8HTkduiiPTQ2wm9O8PswYIxhT23DvRpxJ?= =?koi8-r?Q?TziXRyWKDSgW3Y6F8Ko5JkaA/rAP3C5bcvkiqzxqfozeTQngPaGuZyav25Rb9W?= =?koi8-r?Q?oWoU/OmiambT+W8newSsHaGlbM0/4H3pUGcXyqhFg8/QcJSFvLev1iI2ufVZVM?= =?koi8-r?Q?2MJu3KRUSq1Y/MbdoTnePAqml6NARZCcDm9Og4izKFBotZg8lyVvqa1elpWu1j?= =?koi8-r?Q?CmcfP4db+f+N3mnV/0gfiTsd+ZvqJEmuU+EJJDaCnSw3cChZXV6s8CD1zUimqf?= =?koi8-r?Q?bXNv0px83+UNWahCdxDavyOewAVDROecpNFOLWP9k3eOLjp1qBUvs6H4Rbt+m6?= =?koi8-r?Q?kAu6ITBEsxNwlKo5OIamzJ1czEacYSQg8M40/6yQR7ct4m7Ku1RVAFsGXMRuXa?= =?koi8-r?Q?pPlrGMy17IOef9W2lNJ3fcDTSrPSWX0eDnFiyFh1wpPRNmXciXJxayO1F6cz4s?= =?koi8-r?Q?wWzj2Vg70Gbkn8fD5KvBNNXXndf5QmvzoZ2D8+8YF/KFMboDfG5xCQ34968YG4?= =?koi8-r?Q?7K42XwG1xpq0uLomXg/1EQ7gjbhY9CSaikFCm7cEXy7D+0vdc0Te/JNhiK6K8F?= =?koi8-r?Q?mp0IoLRmgdxcAU9Kw9J3GJ+nVO5sH2GVPOsEhkUQZlMOZmEn5kOYPvzO7UwcBN?= =?koi8-r?Q?9VGjN0E+Ch8nyEZCeX1atg+/gUragrxCu2llp5hq31X9wzBK0rLo3FB2jKbNWY?= =?koi8-r?Q?WR6jnxVB2lMDYMc2YikNhKUM3I5WylcIEWyOHivpqe7So++xtvvYfWp377AOFh?= =?koi8-r?Q?WQmeUk/WcYR4yYJpmMRpFMnG3vt1PdCaExxorlBikxkx55/0hNNAqZuCCQ1G19?= =?koi8-r?Q?49110cFXbqAIsAMglmYTnvSEeaCCPe4nvSmt3URZb5licfAikEc8VO7UrGnSVx?= =?koi8-r?Q?ISlXGCzg/zCzSUNzgWAqkIfyGiaJeNu0r3qvVS1bsAjHlS411dDstO0SDCm7+4?= =?koi8-r?Q?K4p86gwtNb0k9QFmYVDRiKzO2I9EzTdNDd2S6ZAyHa8/L3fXWoiQY0Km7+Onx1?= =?koi8-r?Q?STMSBnBLx4cXiuvKikIuqLc/hzwNhij/rNWn9iWgWmjMB5eX7ry8jkTXCnj7mJ?= =?koi8-r?Q?LeWS6RWZVo2SGQ=3D=3D?= MIME-Version: 1.0 X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: GV1PR08MB7380.eurprd08.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: dbc4a073-daaa-46df-1057-08da3419b930 X-MS-Exchange-CrossTenant-originalarrivaltime: 12 May 2022 13:17:11.1483 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: cyME7G5tiSyuK6ygsBPfYKNG5uItgGtwYKr9J8E4NTmbS6DY8O9BZKLOOZBQdei3daE4Lbw49egjRH0UG5GWRgoZhdGNyx29bZJUup3XdPI= X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB5912 X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection Definition; Similar Internal Domain=false; Similar Monitored External Domain=false; Custom External Domain=false; Mimecast External Domain=false; Newly Observed Domain=false; Internal User Name=false; Custom Display Name List=false; Reply-to Address Mismatch=false; Targeted Threat Dictionary=false; Mimecast Threat Dictionary=false; Custom Threat Dictionary=false X-Scanned-By: MIMEDefang 2.84 on 10.11.54.2 X-Mailman-Approved-At: Thu, 12 May 2022 13:27:05 +0000 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 2.85 on 10.11.54.8 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: ru-RU Content-Transfer-Encoding: quoted-printable X-ZM-MESSAGEID: 1652362041743100001 Content-Type: text/plain; charset="utf-8" From 32dbfbf9857ea72b69ea175ea7f8b21210f4e5d2 Mon Sep 17 00:00:00 2001 From: Efim Shevrin Date: Tue, 10 May 2022 17:03:11 +0300 Subject: [PATCH] Send event on persistent config modification Libvirt is not sending events in case of a device update, thus any services listening to events are unaware of the changes.This patch suggests to send = event in case of a persistent config modification, it should keep subscribed service= s in sync with VM configuration. Signed-off-by: Efim Shevrin --- src/qemu/qemu_driver.c | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index e3582f62a7..6008a4c8f3 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -7942,6 +7942,7 @@ static int qemuDomainUpdateDeviceFlags(virDomainPtr d= om, virQEMUDriver *driver =3D dom->conn->privateData; virDomainObj *vm =3D NULL; qemuDomainObjPrivate *priv; + virObjectEvent *event =3D NULL; g_autoview.settings().get('font_face')ptr(virDomainDef) vmdef =3D NULL; g_autoptr(virDomainDeviceDef) dev =3D NULL; virDomainDeviceDef *dev_copy =3D NULL; @@ -8019,8 +8020,16 @@ static int qemuDomainUpdateDeviceFlags(virDomainPtr = dom, /* Finally, if no error until here, we can save config. */ if (flags & VIR_DOMAIN_AFFECT_CONFIG) { ret =3D virDomainDefSave(vmdef, driver->xmlopt, cfg->configDir); - if (!ret) + if (!ret) { virDomainObjAssignDef(vm, &vmdef, false, NULL); + + /* Event sending if persistent config has changed */ + event =3D virDomainEventLifecycleNewFromObj(vm, + VIR_DOMAIN_EVENT_DEFI= NED, + VIR_DOMAIN_EVENT_DEFI= NED_UPDATED); + + virObjectEventStateQueue(driver->domainEventState, event); + } } endjob: --=20 2.31.1