From nobody Sat May 11 03:13:07 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) client-ip=170.10.129.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail(p=quarantine dis=quarantine) header.from=virtuozzo.com Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.zohomail.com with SMTPS id 1652362085560389.6391651949741; Thu, 12 May 2022 06:28:05 -0700 (PDT) Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-557-A-R8tjvuMhW9LDNoNj96TA-1; Thu, 12 May 2022 09:27:14 -0400 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 0821C86B8D0; Thu, 12 May 2022 13:27:10 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id CD6ED1542D25; Thu, 12 May 2022 13:27:09 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id A17C7193211B; Thu, 12 May 2022 13:27:07 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id B58E11947058 for ; Thu, 12 May 2022 13:25:56 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id 7B8047C2A; Thu, 12 May 2022 13:25:56 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast03.extmail.prod.ext.rdu2.redhat.com [10.11.55.19]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 7430B7AF9 for ; Thu, 12 May 2022 13:25:53 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-2.mimecast.com [205.139.110.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 13AFE811E78 for ; Thu, 12 May 2022 13:25:53 +0000 (UTC) Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-eopbgr80097.outbound.protection.outlook.com [40.107.8.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-640-B12il-T0NcCWvF3DqWxW5A-1; Thu, 12 May 2022 09:25:51 -0400 Received: from GV1PR08MB7380.eurprd08.prod.outlook.com (2603:10a6:150:24::7) by AM5PR0801MB1617.eurprd08.prod.outlook.com (2603:10a6:203:39::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5250.13; Thu, 12 May 2022 13:25:49 +0000 Received: from GV1PR08MB7380.eurprd08.prod.outlook.com ([fe80::1c0f:d9bf:7e4c:4434]) by GV1PR08MB7380.eurprd08.prod.outlook.com ([fe80::1c0f:d9bf:7e4c:4434%7]) with mapi id 15.20.5227.023; Thu, 12 May 2022 13:25:49 +0000 X-MC-Unique: A-R8tjvuMhW9LDNoNj96TA-1 X-Original-To: libvir-list@listman.corp.redhat.com X-MC-Unique: B12il-T0NcCWvF3DqWxW5A-1 From: Efim Shevrin To: "libvir-list@redhat.com" Subject: [libvirt PATCH] Send event on persistent config modification Thread-Topic: [libvirt PATCH] Send event on persistent config modification Thread-Index: AQHYZgNp6XHBixWijE2kYIfdGrTNdw== Date: Thu, 12 May 2022 13:25:49 +0000 Message-ID: Accept-Language: ru-RU, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: suggested_attachment_session_id: abc75783-f1e9-5030-5cd0-a07c4dbc7ab2 x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 3951da65-8ae8-4458-e63e-08da341aedd7 x-ms-traffictypediagnostic: AM5PR0801MB1617:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0 x-microsoft-antispam-message-info: FhG8DizTXn82GoNfVMgRZjtOhjtJEsE6/DTIjRIwQze+5w4s0sNoYw/ZfanHFc7O5zRRgVb3lmPr+6+9VajWeAZm+iEUP/ljZhrjSGNVmD8/xSepe90QYko7dS6eX00VemxP97GH9V/+MqjgSAhQXQs8Vn8xz2DywYGalU8P6sNexijs7FI08/lXfHvLBa5shc2E7k4dxopcU96aVzD9SCn4zNDE4UCotxaiHghKHXBdUGzqyVMg2DlWSRscjR/ftXastyfpdyTSBPE1r5uvieaO/tRpZ9E3bBEytetYCwjzEjvMbbBPZ4cnWzI/nbDIham+IeyNeHkPfIfNTLXGLCoT//70su5o/FSeeOQpKwiGUkOuaQ3yIkNi2SQ0G1LUoe8Tw6Tn7rmaK1HCME+TDIMe8h63TTAQ3vtRWSg9I/6a6rLCUdzYjXBNDX0X2vIdIAfYBr/fT6XObdnO8X2bmPUwos3vq7Turz2Fsih0FcKGY1wNjwVvwA+FV1S04lisdJ1hxDvPDgZEoUrxxo+P3YbBfShoxi0Z9i4fUJ/OenHe/LmgoVYR061wbNRPQ7Ly1ksePKG/fSkttQwlPSIx3bwrRNnplyzwabioMfhTYzs5gdP14dfoL9fa7n9juYIs9y97ofxXYID7KwrjSGD2GalvS6qdsPwDUwt/UoUwxG3RJQIh5ZoakOwhxHvGhGYbQZ0W5AvrFcsQq6eNtFMhrg== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:GV1PR08MB7380.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(4636009)(366004)(44832011)(6916009)(122000001)(33656002)(38070700005)(38100700002)(55016003)(316002)(53546011)(76116006)(186003)(64756008)(66476007)(8676002)(66556008)(66946007)(6506007)(26005)(7696005)(71200400001)(5660300002)(91956017)(83380400001)(66446008)(52536014)(8936002)(86362001)(508600001)(2906002)(9686003); DIR:OUT; SFP:1102 x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?koi8-r?Q?acRCHY1U2OTzgfz8sZk7qv0i7Suh03eXaQ+jo5paJW6fcuB+pKvizxU5GhdoTC?= =?koi8-r?Q?RvJ+qD0SqseNZ7hfXqKVGDA3wZW6dnTdkpEcFV2x40y8c3q8BdicQjJM825RoW?= =?koi8-r?Q?Awq//fyuJk8hUNg8FMgfrwkk1DgwNydAElTNM9Rcw+a3eqPp92/cFr6xL/4LeW?= =?koi8-r?Q?efnuDxLVkN1Pg1OQMU2sYt9Z98kU81BAkX14xTHrw5AMyAXNhJWnOe3i3wZlIL?= =?koi8-r?Q?d30uSIfJrsjFaZ5EHXWZ0uyvCZhz9Fu1PkoYxPlR4CvBpfBsD5lunPpFn+un7d?= =?koi8-r?Q?opthOFTArBd0LYzk9zR490Y8rCRcvNIIK8OCesV07AfzUY5DtaqaEwUEsmPiu/?= =?koi8-r?Q?eUKIKXfEUmZ4+sz+Ijd8cYcJBJ4HBF6nMM2X2Fg4q9psIQrISgkGXaOcGR3E85?= =?koi8-r?Q?kZu2mOFeUmLM7BIiQgFZ4pkHiSnm59T+5CF4El9ii4waYg4jaDWWeNQpmEh6sK?= =?koi8-r?Q?+/ww/8TyB6zI8jCx4Q/1UKxPGzeTSPcWkxNpUndl+SzcPxs7vJ6A+rVEBtC32d?= =?koi8-r?Q?iZH8oFjOLMoMIkWWn3Rmtc5Rd861hf74/9mLCe1xWsEhr0aUXXgs6zGtuksHP/?= =?koi8-r?Q?9e+qUtoX/BbFKFtxgRh3i/xczbjZlOF9jtLYLCDJJDnkE52CXixALqRGqp7Zvs?= =?koi8-r?Q?gEzpG67+C8zANOwwjpNRhCx010/NO+YfLT8IzJZtTqCsmd+798COSpqqgOMPdB?= =?koi8-r?Q?a0XaL78vCUXK8mi0bmAAEW5Gj7SbJOp356lGtwuz3h26BeiJK7lyiKdLk/vFNd?= =?koi8-r?Q?S6+gcjSgaga0ORFa013pxNcnFtI7qEp0mhUa+SWsasgb7lht+y8VtY6N8Mexw1?= =?koi8-r?Q?xXlqePtyH9IvtZLjUCPfrM9WsxXss5sHnSYV3Ziy9w1d2FkhdfFKJ9wX5yVpDZ?= =?koi8-r?Q?I2JHg2U9q7K0MzTpWG27NQFQoaqltaaXHR7FK19vc819b045LQC74w5Vrb8L8a?= =?koi8-r?Q?r6Wx+7MYqltd+B9Uha0Eo11/RPxp0uH5/Mm3A+7L/T59BiKrJ83o71xGCHgnBx?= =?koi8-r?Q?oi1mF/Oh6mzQ2LM6Pu8XIxcpIJGQ+vCz8IO06Ml7FOi8v9YIozJV9TfaT83779?= =?koi8-r?Q?Qps3v98nrHUgXZ2jiAK0hLJR2WZAKIeTMwSsKeKChTw1PxYX9MUADYcigicMMw?= =?koi8-r?Q?/mIuPVSmxglMFFPuGCiDFlIZPWriJQZTPBqbHbsNV0RzUsZ73+Asmdy+UkwgbQ?= =?koi8-r?Q?FDTht/ie7yKABjq6HzrpiV30gqpuX4lfh78SFidOkOluxZiIDE0x8fC4h89TYQ?= =?koi8-r?Q?r9hYOJvJ1+06x7L1RMPMkSAXbbjQbyC050J5CU2r7PbsGwSfPbycmX786CbB7/?= =?koi8-r?Q?aEzNJrO6iqHd7lBMxCRSUuhNMiudo+ISsxf8bWeeViCy8P5nTX5KifDqthx0P/?= =?koi8-r?Q?0P5ZjqinmHbfVYqfXUZceyOVYVFk+7cqgqR+fdbh19JOpG2WjCrme434ZDcRiD?= =?koi8-r?Q?ry/Zks3EUNuCvNNFpOZ0wezQ6FXc9xeI9bcvOQOlVAAx0WMoP3ACeMjYDr+ZtN?= =?koi8-r?Q?IArjN9ysA9feKyHsIgT/beKdPK1zYJbyEXn0ENueYt8/hVAgd3dAbUCG4otjz7?= =?koi8-r?Q?uUXYJrOjomd5CPljh8ZGXOtapAB3NJV9Z9PwJWSUz4xLlSRQytp/xEZv9s44LX?= =?koi8-r?Q?JdOBHt0kUf9F2VLPtqZ/iexmI+q5MuetbrB6fRBQeNb7ks1oE5vXQS6lJZPTJK?= =?koi8-r?Q?SzWDoHoTO4jD/g=3D=3D?= MIME-Version: 1.0 X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: GV1PR08MB7380.eurprd08.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3951da65-8ae8-4458-e63e-08da341aedd7 X-MS-Exchange-CrossTenant-originalarrivaltime: 12 May 2022 13:25:49.0177 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: YcADpGVqPnIMvNyCbySTprPdDWfWCWQ+NGKShq66CvF7pXVKHAknGuhma8Dj31EsPfa83oNyWbrUqEysLU9l0OCmsX9f5AiOw2M4YYNudjE= X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM5PR0801MB1617 X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection Definition; Similar Internal Domain=false; Similar Monitored External Domain=false; Custom External Domain=false; Mimecast External Domain=false; Newly Observed Domain=false; Internal User Name=false; Custom Display Name List=false; Reply-to Address Mismatch=false; Targeted Threat Dictionary=false; Mimecast Threat Dictionary=false; Custom Threat Dictionary=false X-Scanned-By: MIMEDefang 2.79 on 10.11.54.5 X-Mailman-Approved-At: Thu, 12 May 2022 13:27:05 +0000 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 2.85 on 10.11.54.7 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: ru-RU Content-Transfer-Encoding: quoted-printable X-ZM-MESSAGEID: 1652362087754100003 Content-Type: text/plain; charset="utf-8" From 32dbfbf9857ea72b69ea175ea7f8b21210f4e5d2 Mon Sep 17 00:00:00 2001 From: Efim Shevrin Date: Tue, 10 May 2022 17:03:11 +0300 Subject: [PATCH] Send event on persistent config modification Libvirt is not sending events in case of a device update, thus any services listening to events are unaware of the changes.This patch suggests to send = event in case of a persistent config modification, it should keep subscribed service= s in sync with VM configuration. Signed-off-by: Efim Shevrin --- src/qemu/qemu_driver.c | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index e3582f62a7..6008a4c8f3 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -7942,6 +7942,7 @@ static int qemuDomainUpdateDeviceFlags(virDomainPtr d= om, virQEMUDriver *driver =3D dom->conn->privateData; virDomainObj *vm =3D NULL; qemuDomainObjPrivate *priv; + virObjectEvent *event =3D NULL; g_autoview.settings().get('font_face')ptr(virDomainDef) vmdef =3D NULL; g_autoptr(virDomainDeviceDef) dev =3D NULL; virDomainDeviceDef *dev_copy =3D NULL; @@ -8019,8 +8020,16 @@ static int qemuDomainUpdateDeviceFlags(virDomainPtr = dom, /* Finally, if no error until here, we can save config. */ if (flags & VIR_DOMAIN_AFFECT_CONFIG) { ret =3D virDomainDefSave(vmdef, driver->xmlopt, cfg->configDir); - if (!ret) + if (!ret) { virDomainObjAssignDef(vm, &vmdef, false, NULL); + + /* Event sending if persistent config has changed */ + event =3D virDomainEventLifecycleNewFromObj(vm, + VIR_DOMAIN_EVENT_DEFI= NED, + VIR_DOMAIN_EVENT_DEFI= NED_UPDATED); + + virObjectEventStateQueue(driver->domainEventState, event); + } } endjob: --=20 2.31.1