1. Patchew
  2. Libvirt
  3. View series

[libvirt] [PATCH] Let virt-manager 1.4.0+ work to access console of VM

Bryan Quigley posted 1 patch 7 years, 1 month ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/CAML-E+u0oOeQmavtT2Nzq3_pi2NSze8E1G28Bc-EZx2He58umg@mail.gmail.com
examples/apparmor/libvirt-qemu | 3 +++
1 file changed, 3 insertions(+)
[libvirt] [PATCH] Let virt-manager 1.4.0+ work to access console of VM
Posted by Bryan Quigley 7 years, 1 month ago 
Also see Ubuntu bug
https://bugs.launchpad.net/ubuntu/+source/libvirt/+bug/1668681
First reported https://askubuntu.com/questions/833964/virt-manager-cant-connect-to-graphical-console/888220#888220

---
 examples/apparmor/libvirt-qemu | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/examples/apparmor/libvirt-qemu b/examples/apparmor/libvirt-qemu
index a9020aa..19d99e5 100644
--- a/examples/apparmor/libvirt-qemu
+++ b/examples/apparmor/libvirt-qemu
@@ -151,3 +151,6 @@
   /etc/udev/udev.conf r,
   /sys/bus/ r,
   /sys/class/ r,
+
+  # allow connect with openGraphicsFD to work
+  unix (send, receive) type=stream peer=(label=/usr/sbin/libvirtd),
-- 
2.10.2

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH] Let virt-manager 1.4.0+ work to access console of VM
Posted by Bryan Quigley 7 years, 1 month ago 
With Jamie Strandboge's help it should be restricted a bit more by
adding addr=none:
unix (send, receive) type=stream addr=none peer=(label=/usr/sbin/libvirtd),

On Tue, Feb 28, 2017 at 1:48 PM, Bryan Quigley
<bryan.quigley@canonical.com> wrote:
> Also see Ubuntu bug
> https://bugs.launchpad.net/ubuntu/+source/libvirt/+bug/1668681
> First reported https://askubuntu.com/questions/833964/virt-manager-cant-connect-to-graphical-console/888220#888220
>
> ---
>  examples/apparmor/libvirt-qemu | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/examples/apparmor/libvirt-qemu b/examples/apparmor/libvirt-qemu
> index a9020aa..19d99e5 100644
> --- a/examples/apparmor/libvirt-qemu
> +++ b/examples/apparmor/libvirt-qemu
> @@ -151,3 +151,6 @@
>    /etc/udev/udev.conf r,
>    /sys/bus/ r,
>    /sys/class/ r,
> +
> +  # allow connect with openGraphicsFD to work
> +  unix (send, receive) type=stream peer=(label=/usr/sbin/libvirtd),
> --
> 2.10.2

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH] Let virt-manager 1.4.0+ work to access console of VM
Posted by Guido Günther 7 years, 1 month ago 
On Tue, Feb 28, 2017 at 01:48:31PM -0500, Bryan Quigley wrote:
> Also see Ubuntu bug
> https://bugs.launchpad.net/ubuntu/+source/libvirt/+bug/1668681
> First reported https://askubuntu.com/questions/833964/virt-manager-cant-connect-to-graphical-console/888220#888220
> 
> ---
>  examples/apparmor/libvirt-qemu | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/examples/apparmor/libvirt-qemu b/examples/apparmor/libvirt-qemu
> index a9020aa..19d99e5 100644
> --- a/examples/apparmor/libvirt-qemu
> +++ b/examples/apparmor/libvirt-qemu
> @@ -151,3 +151,6 @@
>    /etc/udev/udev.conf r,
>    /sys/bus/ r,
>    /sys/class/ r,
> +
> +  # allow connect with openGraphicsFD to work
> +  unix (send, receive) type=stream peer=(label=/usr/sbin/libvirtd),

Shouldn't this only be added via virt-aa-helper when a corresponding
console is in use?
Cheers,
 -- Guido

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH] Let virt-manager 1.4.0+ work to access console of VM
Posted by Bryan Quigley 7 years, 1 month ago 
Hi Guido,

It's only needed when a user actually clicks on the running VM in
virt-manager.  It's not defined differently in the domain xml.

I'm thinking that means virt-aa-helper can't help us in this case, but
am open to being proven wrong.

Thanks!
Bryan

On Wed, Mar 1, 2017 at 1:04 AM, Guido Günther <agx@sigxcpu.org> wrote:
> On Tue, Feb 28, 2017 at 01:48:31PM -0500, Bryan Quigley wrote:
>> Also see Ubuntu bug
>> https://bugs.launchpad.net/ubuntu/+source/libvirt/+bug/1668681
>> First reported https://askubuntu.com/questions/833964/virt-manager-cant-connect-to-graphical-console/888220#888220
>>
>> ---
>>  examples/apparmor/libvirt-qemu | 3 +++
>>  1 file changed, 3 insertions(+)
>>
>> diff --git a/examples/apparmor/libvirt-qemu b/examples/apparmor/libvirt-qemu
>> index a9020aa..19d99e5 100644
>> --- a/examples/apparmor/libvirt-qemu
>> +++ b/examples/apparmor/libvirt-qemu
>> @@ -151,3 +151,6 @@
>>    /etc/udev/udev.conf r,
>>    /sys/bus/ r,
>>    /sys/class/ r,
>> +
>> +  # allow connect with openGraphicsFD to work
>> +  unix (send, receive) type=stream peer=(label=/usr/sbin/libvirtd),
>
> Shouldn't this only be added via virt-aa-helper when a corresponding
> console is in use?
> Cheers,
>  -- Guido

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH] Let virt-manager 1.4.0+ work to access console of VM
Posted by Guido Günther 7 years, 1 month ago 
On Wed, Mar 01, 2017 at 05:11:53PM -0500, Bryan Quigley wrote:
> Hi Guido,
> 
> It's only needed when a user actually clicks on the running VM in
> virt-manager.  It's not defined differently in the domain xml.
> 
> I'm thinking that means virt-aa-helper can't help us in this case, but
> am open to being proven wrong.

The fd is passed over the existing socket, no new socket is created to
the qemu process, so yes virt-aa-helper won't help here. Sorry for the
noise.
 -- Guido

> 
> Thanks!
> Bryan
> 
> On Wed, Mar 1, 2017 at 1:04 AM, Guido Günther <agx@sigxcpu.org> wrote:
> > On Tue, Feb 28, 2017 at 01:48:31PM -0500, Bryan Quigley wrote:
> >> Also see Ubuntu bug
> >> https://bugs.launchpad.net/ubuntu/+source/libvirt/+bug/1668681
> >> First reported https://askubuntu.com/questions/833964/virt-manager-cant-connect-to-graphical-console/888220#888220
> >>
> >> ---
> >>  examples/apparmor/libvirt-qemu | 3 +++
> >>  1 file changed, 3 insertions(+)
> >>
> >> diff --git a/examples/apparmor/libvirt-qemu b/examples/apparmor/libvirt-qemu
> >> index a9020aa..19d99e5 100644
> >> --- a/examples/apparmor/libvirt-qemu
> >> +++ b/examples/apparmor/libvirt-qemu
> >> @@ -151,3 +151,6 @@
> >>    /etc/udev/udev.conf r,
> >>    /sys/bus/ r,
> >>    /sys/class/ r,
> >> +
> >> +  # allow connect with openGraphicsFD to work
> >> +  unix (send, receive) type=stream peer=(label=/usr/sbin/libvirtd),
> >
> > Shouldn't this only be added via virt-aa-helper when a corresponding
> > console is in use?
> > Cheers,
> >  -- Guido
> 
> --
> libvir-list mailing list
> libvir-list@redhat.com
> https://www.redhat.com/mailman/listinfo/libvir-list

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH] Let virt-manager 1.4.0+ work to access console of VM
Posted by Christian Ehrhardt 6 years, 4 months ago 
This starves a bit in the corners of the ML, any chance to pick this
up for 3.11?

On Thu, Mar 2, 2017 at 8:42 AM, Guido Günther <agx@sigxcpu.org> wrote:
> On Wed, Mar 01, 2017 at 05:11:53PM -0500, Bryan Quigley wrote:
>> Hi Guido,
>>
>> It's only needed when a user actually clicks on the running VM in
>> virt-manager.  It's not defined differently in the domain xml.
>>
>> I'm thinking that means virt-aa-helper can't help us in this case, but
>> am open to being proven wrong.
>
> The fd is passed over the existing socket, no new socket is created to
> the qemu process, so yes virt-aa-helper won't help here. Sorry for the
> noise.
>  -- Guido
>
>>
>> Thanks!
>> Bryan
>>
>> On Wed, Mar 1, 2017 at 1:04 AM, Guido Günther <agx@sigxcpu.org> wrote:
>> > On Tue, Feb 28, 2017 at 01:48:31PM -0500, Bryan Quigley wrote:
>> >> Also see Ubuntu bug
>> >> https://bugs.launchpad.net/ubuntu/+source/libvirt/+bug/1668681
>> >> First reported https://askubuntu.com/questions/833964/virt-manager-cant-connect-to-graphical-console/888220#888220
>> >>
>> >> ---
>> >>  examples/apparmor/libvirt-qemu | 3 +++
>> >>  1 file changed, 3 insertions(+)
>> >>
>> >> diff --git a/examples/apparmor/libvirt-qemu b/examples/apparmor/libvirt-qemu
>> >> index a9020aa..19d99e5 100644
>> >> --- a/examples/apparmor/libvirt-qemu
>> >> +++ b/examples/apparmor/libvirt-qemu
>> >> @@ -151,3 +151,6 @@
>> >>    /etc/udev/udev.conf r,
>> >>    /sys/bus/ r,
>> >>    /sys/class/ r,
>> >> +
>> >> +  # allow connect with openGraphicsFD to work
>> >> +  unix (send, receive) type=stream peer=(label=/usr/sbin/libvirtd),
>> >
>> > Shouldn't this only be added via virt-aa-helper when a corresponding
>> > console is in use?
>> > Cheers,
>> >  -- Guido
>>
>> --
>> libvir-list mailing list
>> libvir-list@redhat.com
>> https://www.redhat.com/mailman/listinfo/libvir-list
>
> --
> libvir-list mailing list
> libvir-list@redhat.com
> https://www.redhat.com/mailman/listinfo/libvir-list



-- 
Christian Ehrhardt
Software Engineer, Ubuntu Server
Canonical Ltd

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Patchew 2.1-devel-0870f84

© 2016 - 2024 Red Hat, Inc.