[libvirt] [libvirt-perl] Remove-the-unused-parameter-in-document

Dan Zheng posted 1 patch 5 years, 1 month ago
Failed in applying to current master (apply log)
lib/Sys/Virt/Domain.pm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[libvirt] [libvirt-perl] Remove-the-unused-parameter-in-document
Posted by Dan Zheng 5 years, 1 month ago
>From d3b0044699732dba54ff0360e626ea1738bfe872 Mon Sep 17 00:00:00 2001
From: Dan Zheng <dzheng@redhat.com>
Date: Tue, 26 Feb 2019 17:35:49 +0800
Subject: [PATCH] Remove the unused parameter in document

Signed-off-by: Dan Zheng <dzheng@redhat.com>
---
 lib/Sys/Virt/Domain.pm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/Sys/Virt/Domain.pm b/lib/Sys/Virt/Domain.pm
index 7b43e7f..1e3a3a2 100644
--- a/lib/Sys/Virt/Domain.pm
+++ b/lib/Sys/Virt/Domain.pm
@@ -1448,7 +1448,7 @@ Delete an existing IOThread by the C<$iothread> value
from the guest domain.
 The C<$flags> parameter accepts one or more the CONFIG OPTION constants
 documented later, and defaults to 0 if omitted.

-=item $dom->set_iothread($iothread, $params, $nparams, $flags=0)
+=item $dom->set_iothread($iothread, $params, $flags=0)

 Set parameters for the IOThread by the C<$iothread> value on the guest
domain.
 The C<$params> parameter is a hash reference whose keys are the
-- 
1.8.3.1

Regards,
Dan Zheng (dzheng@redhat.com)
Libvirt, Virtualization
Redhat Beijing  R&D
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [libvirt-perl] Remove-the-unused-parameter-in-document
Posted by Daniel P. Berrangé 5 years, 1 month ago
On Tue, Feb 26, 2019 at 05:40:49PM +0800, Dan Zheng wrote:
> >From d3b0044699732dba54ff0360e626ea1738bfe872 Mon Sep 17 00:00:00 2001
> From: Dan Zheng <dzheng@redhat.com>
> Date: Tue, 26 Feb 2019 17:35:49 +0800
> Subject: [PATCH] Remove the unused parameter in document
> 
> Signed-off-by: Dan Zheng <dzheng@redhat.com>
> ---
>  lib/Sys/Virt/Domain.pm | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/lib/Sys/Virt/Domain.pm b/lib/Sys/Virt/Domain.pm
> index 7b43e7f..1e3a3a2 100644
> --- a/lib/Sys/Virt/Domain.pm
> +++ b/lib/Sys/Virt/Domain.pm
> @@ -1448,7 +1448,7 @@ Delete an existing IOThread by the C<$iothread> value
> from the guest domain.
>  The C<$flags> parameter accepts one or more the CONFIG OPTION constants
>  documented later, and defaults to 0 if omitted.
> 
> -=item $dom->set_iothread($iothread, $params, $nparams, $flags=0)
> +=item $dom->set_iothread($iothread, $params, $flags=0)
> 
>  Set parameters for the IOThread by the C<$iothread> value on the guest
> domain.
>  The C<$params> parameter is a hash reference whose keys are the

Change looks fine, but the patch has been mangled by your mail client
inserting bogus line breaks.  It is a simple enough patch that I'll
fix this and push it manually, so no need to re-send.

FWIW, I'd strongly recommend using  "git send-email" to submit patches,
or even "git publish"  (needs the git-publish RPM from Fedora) as it
avoids alot of problems in general.

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list