From nobody Thu May 2 04:20:41 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 207.211.31.81 as permitted sender) client-ip=207.211.31.81; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-1.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 207.211.31.81 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1582567654; cv=none; d=zohomail.com; s=zohoarc; b=C/fTlnhCRYQ++K4dcf0be8AOxNXv23TdSgB+4jLd1zw0haetGCG1eKHSQSfdOqo8QvROWIiEa+LI3/qCe5WViYVtHqhwkzY2c+kpX1KZgG29vu/LpzCEE+K00pcI3PQB+/CsnPp48OzKYmyI+Ehb3yUyjLPGpXgPhhRMvhUb3nI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1582567654; h=Content-Type:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=RhxDm5f5HPY1UMKWDGThf6irjZpooTHGbA1ZwCCOj8w=; b=R04wgRc/pHbJgT6q/f8cbetyI0T/m9v+/aRnRULRplkrl25fDoFSNgpNcD/ZX5eZTwpHuTkYZXdj+rxiK6lLTHvjodpIvVywb+VHsXW9zzbOlY1IjP5Mrc5suscY72UFt+ak6PXJRaNLlsYykN8X2mkJgiPAVI1MjlaPVMSL2kM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 207.211.31.81 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com Return-Path: Received: from us-smtp-delivery-1.mimecast.com (us-smtp-1.mimecast.com [207.211.31.81]) by mx.zohomail.com with SMTPS id 1582567654290966.4705055997002; Mon, 24 Feb 2020 10:07:34 -0800 (PST) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-321-FMWBQoq6O2-dJjgRlgraZw-1; Mon, 24 Feb 2020 13:07:29 -0500 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 6BC1613F8; Mon, 24 Feb 2020 18:07:22 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 3DB7960BF7; Mon, 24 Feb 2020 18:07:22 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id E971618089CD; Mon, 24 Feb 2020 18:07:21 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 01OI1Ap3006207 for ; Mon, 24 Feb 2020 13:01:10 -0500 Received: by smtp.corp.redhat.com (Postfix) id 7CA5E10F8E07; Mon, 24 Feb 2020 18:01:10 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast01.extmail.prod.ext.rdu2.redhat.com [10.11.55.17]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 76EBD10F8E04 for ; Mon, 24 Feb 2020 18:01:06 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id CA97085A308 for ; Mon, 24 Feb 2020 18:01:06 +0000 (UTC) Received: from mail-vs1-f41.google.com (mail-vs1-f41.google.com [209.85.217.41]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-133-vaXxiFMAM_iNUfHcu7nddw-1; Mon, 24 Feb 2020 13:01:03 -0500 Received: by mail-vs1-f41.google.com with SMTP id x123so6268779vsc.2; Mon, 24 Feb 2020 10:01:02 -0800 (PST) Received: from mail-vk1-f176.google.com (mail-vk1-f176.google.com. [209.85.221.176]) by smtp.gmail.com with ESMTPSA id b20sm2825843vsq.20.2020.02.24.10.01.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 24 Feb 2020 10:01:01 -0800 (PST) Received: by mail-vk1-f176.google.com with SMTP id o187so2741149vka.2; Mon, 24 Feb 2020 10:01:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1582567651; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:list-id:list-help:list-unsubscribe: list-subscribe:list-post; bh=RhxDm5f5HPY1UMKWDGThf6irjZpooTHGbA1ZwCCOj8w=; b=TokuEhqDxCwUhGfSqfM5tE99nkeHMhkfFGoZIkrF0kJvcSStrTaINhoAwTh3/PHzSeVSfs wZp6K/2veJQ3oUTXnLDIiF9Z644z26MRIOdVwLqZ1rpRVcOT4mjlPmR62n9MdXEEx1m1u9 vpLuecxN0f7HkCOKCWfKvIWLbT6ZOCo= X-MC-Unique: FMWBQoq6O2-dJjgRlgraZw-1 X-MC-Unique: vaXxiFMAM_iNUfHcu7nddw-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to:cc; bh=ynfoSRUPkBv6Yno/bZaSByE55zx6wCgOlRvhi8B3xl0=; b=FF9kf8BHox90rlp2IQxyOXuDTf39KviCslumr49SEQyXCVTfoXhAEOkBaoXWPBAgJS o4nXK44f2IWl6gz2eqLGZOhQnTsdBzy17ez02swlcim4sZYIbcFWFweb3k4tJFSR41xw 8zke1Vvgpmb351ZcU7aECwu765sNYxnyov9KjPnvUKID3TneIsExURTKCA4aRgxYIcwC 0aIt2/mP4k9px16lDx9uSgzBe9N5LCYwnOCgu8HDhW6Fqvb7T5kaDsDDLSuaMU+DESri L5iI+s7ZrzJhr8vYkSxGN8mFO+f2jJ2rzJ7wK2wqRdXyeNfT6HIaa/O4zAMkMsTgqEw+ I1mg== X-Gm-Message-State: APjAAAU0u0A6uus8fFKSrEv41o4uu+VSCLy//N7Gl9MHo1vsV7TSrDEV nrICduwCQxIi2ZF2WViqKRnrfofPTOg= X-Google-Smtp-Source: APXvYqwkVrdnqKnq2Bw6+N9UapsJ+O7yR1FUFwXWcyFcbM06NmItjQE4AOWGqfeLKQWICOvHPs3Asw== X-Received: by 2002:a67:f591:: with SMTP id i17mr27591424vso.34.1582567262076; Mon, 24 Feb 2020 10:01:02 -0800 (PST) X-Received: by 2002:a1f:18cf:: with SMTP id 198mr23619841vky.61.1582567261320; Mon, 24 Feb 2020 10:01:01 -0800 (PST) MIME-Version: 1.0 From: Gaurav Agrawal Date: Mon, 24 Feb 2020 23:30:50 +0530 X-Gmail-Original-Message-ID: Message-ID: Subject: network: bridge_driver: Use new helpers for storing libvirt errors To: libvir-list@redhat.com X-Scanned-By: MIMEDefang 2.78 on 10.11.54.3 X-loop: libvir-list@redhat.com X-Mailman-Approved-At: Mon, 24 Feb 2020 13:07:20 -0500 Cc: crobinso@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: multipart/alternative; boundary="00000000000071bd7f059f56274e" X-ZohoMail-DKIM: pass (identity @redhat.com) --00000000000071bd7f059f56274e Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" >From c2028d3b27e20eb0d15a553139d2c987325d977e Mon Sep 17 00:00:00 2001 From: Gaurav Agrawal Date: Mon, 24 Feb 2020 22:49:21 +0530 Subject: [PATCH] network: bridge_driver: Use new helpers for storing libvirt errors Signed-off-by: Gaurav Agrawal --- src/network/bridge_driver_linux.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/network/bridge_driver_linux.c b/src/network/bridge_driver_linux.c index 7bbde5c6a9..fde33b5d38 100644 --- a/src/network/bridge_driver_linux.c +++ b/src/network/bridge_driver_linux.c @@ -22,6 +22,7 @@ #include #include "viralloc.h" +#include "virerror.h" #include "virfile.h" #include "viriptables.h" #include "virstring.h" @@ -53,7 +54,7 @@ static void networkSetupPrivateChains(void) if (rc < 0) { VIR_DEBUG("Failed to create global IPv4 chains: %s", virGetLastErrorMessage()); - errInitV4 =3D virSaveLastError(); + virErrorPreserveLast(&errInitV4); virResetLastError(); } else { virFreeError(errInitV4); @@ -70,7 +71,7 @@ static void networkSetupPrivateChains(void) if (rc < 0) { VIR_DEBUG("Failed to create global IPv6 chains: %s", virGetLastErrorMessage()); - errInitV6 =3D virSaveLastError(); + virErrorPreserveLast(&errInitV6); virResetLastError(); } else { virFreeError(errInitV6); --=20 2.24.1 --00000000000071bd7f059f56274e Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
From c2028d3b27e20eb0d15a553139d2c987325d977e Mon Sep 17 0= 0:00:00 2001
From: Gaurav Agrawal <agrawalgaurav@gnome.org>
Date: Mon, 24 Feb 2020 22:49:21= +0530
Subject: [PATCH] network: bridge_driver: Use new helpers for stor= ing libvirt
=C2=A0errors

Signed-off-by: Gaurav Agrawal <agrawalgaurav@gnome.org>
---=
=C2=A0src/network/bridge_driver_linux.c | 5 +++--
=C2=A01 file chang= ed, 3 insertions(+), 2 deletions(-)

diff --git a/src/network/bridge_= driver_linux.c b/src/network/bridge_driver_linux.c
index 7bbde5c6a9..fde= 33b5d38 100644
--- a/src/network/bridge_driver_linux.c
+++ b/src/netw= ork/bridge_driver_linux.c
@@ -22,6 +22,7 @@
=C2=A0#include <config= .h>
=C2=A0
=C2=A0#include "viralloc.h"
+#include &quo= t;virerror.h"
=C2=A0#include "virfile.h"
=C2=A0#includ= e "viriptables.h"
=C2=A0#include "virstring.h"
@@= -53,7 +54,7 @@ static void networkSetupPrivateChains(void)
=C2=A0 =C2= =A0 =C2=A0if (rc < 0) {
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0VIR_DEBUG(&= quot;Failed to create global IPv4 chains: %s",
=C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0virGetLastErrorMessage());=
- =C2=A0 =C2=A0 =C2=A0 =C2=A0errInitV4 =3D virSaveLastError();
+ =C2= =A0 =C2=A0 =C2=A0 =C2=A0virErrorPreserveLast(&errInitV4);
=C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0virResetLastError();
=C2=A0 =C2=A0 =C2=A0} else = {
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0virFreeError(errInitV4);
@@ -70,7= +71,7 @@ static void networkSetupPrivateChains(void)
=C2=A0 =C2=A0 =C2= =A0if (rc < 0) {
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0VIR_DEBUG("Fa= iled to create global IPv6 chains: %s",
=C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0virGetLastErrorMessage());
- = =C2=A0 =C2=A0 =C2=A0 =C2=A0errInitV6 =3D virSaveLastError();
+ =C2=A0 = =C2=A0 =C2=A0 =C2=A0virErrorPreserveLast(&errInitV6);
=C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0virResetLastError();
=C2=A0 =C2=A0 =C2=A0} else {=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0virFreeError(errInitV6);
--
2.24.= 1
--00000000000071bd7f059f56274e--