From nobody Fri May 17 06:07:29 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) client-ip=170.10.129.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail(p=none dis=none) header.from=gmail.com Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.zohomail.com with SMTPS id 1655349398551369.9640549540951; Wed, 15 Jun 2022 20:16:38 -0700 (PDT) Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-365-TKqICZI8OkKhpzhboaCNbg-1; Wed, 15 Jun 2022 23:16:30 -0400 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id A884085A585; Thu, 16 Jun 2022 03:16:27 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (unknown [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id 277761415106; Thu, 16 Jun 2022 03:16:27 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id C0703194704D; Thu, 16 Jun 2022 03:16:26 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 488C019466DF for ; Thu, 16 Jun 2022 03:16:25 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id 15392C08F0D; Thu, 16 Jun 2022 03:16:25 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast02.extmail.prod.ext.rdu2.redhat.com [10.11.55.18]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 11283C08081 for ; Thu, 16 Jun 2022 03:16:25 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id EDD03801756 for ; Thu, 16 Jun 2022 03:16:24 +0000 (UTC) Received: from mail-io1-f50.google.com (mail-io1-f50.google.com [209.85.166.50]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-373-941ken7jPH66vjJRS3h2XA-1; Wed, 15 Jun 2022 23:16:23 -0400 Received: by mail-io1-f50.google.com with SMTP id p128so286760iof.1 for ; Wed, 15 Jun 2022 20:16:22 -0700 (PDT) X-MC-Unique: TKqICZI8OkKhpzhboaCNbg-1 X-Original-To: libvir-list@listman.corp.redhat.com X-MC-Unique: 941ken7jPH66vjJRS3h2XA-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=eRDhguBHwt970vgBubQC6JDA35twdSElyvAVU9IQYjE=; b=Ge1FcWk6DlEXKzXFk5zgld9nqW3J2Oeed2q+ke/pdKgbHn9myukJiNx8QJcxIVZ+kU 7rU85zCdzYB5Emej9FXHECP+VOKLiEnea68CYb0sTaNjE4erlbW8+1nPO1TF6YB0dBpK wiqJFSuWu3EDFoOZ5mgSbwgjo0wdE+PsM7/66ZfRCs782GKYR4lQaznev1NMbtdlcnKk ys9R45st+sZsQ0/l8my6x4atfcRwUpXpUTIw4Gohkkv2o1zrR/bJ+73hSQW0NulU1kRo lQdZNNjlMfDkDqMlN23QErwoN+Fq/MIvjt90KHc2MRiKOE9WcmfbNv75UExSGQrZkLCL kobg== X-Gm-Message-State: AJIora8H8XIyNDgdUzjkYswYbbgeWmDy9Y/R/lzbmRu+N+SUuP8Qcjz8 LksKvA8nGezuE2YDai/0zG5VmKv3+DrSXk2cnhA1/zrzjIWV+oS201qe6A== X-Google-Smtp-Source: AGRyM1spCY1eE5kCyiCgj1KfpLz+nO1zZ9TlHNIoLQ1p2HKPLDcJke56OlfHVLipe3Gke1kyyMxcnSadPTM3iD6+/Fc= X-Received: by 2002:a05:6638:16cf:b0:332:2bc:b7d5 with SMTP id g15-20020a05663816cf00b0033202bcb7d5mr1533686jat.172.1655349382242; Wed, 15 Jun 2022 20:16:22 -0700 (PDT) MIME-Version: 1.0 From: Eustance Wu Date: Thu, 16 Jun 2022 11:16:11 +0800 Message-ID: Subject: [PATCH] virMacAddrParse: Fix wrong termination character To: libvir-list@redhat.com X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection Definition; Similar Internal Domain=false; Similar Monitored External Domain=false; Custom External Domain=false; Mimecast External Domain=false; Newly Observed Domain=false; Internal User Name=false; Custom Display Name List=false; Reply-to Address Mismatch=false; Targeted Threat Dictionary=false; Mimecast Threat Dictionary=false; Custom Threat Dictionary=false X-Scanned-By: MIMEDefang 2.85 on 10.11.54.8 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 2.85 on 10.11.54.7 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: multipart/alternative; boundary="000000000000e8687705e1880ffe" X-ZM-MESSAGEID: 1655349399006100001 Content-Transfer-Encoding: quoted-printable --000000000000e8687705e1880ffe MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 RnJvbSA3ZGYwMzRlOTNkMzkyYzczNGFjNWM0ZjQxNDhhM2QwNWY5ZWRjZTI5IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBXdUxvbmdUYW8gPGV1c3RhbmNld3VAZ21haWwuY29tPgpEYXRl OiBUaHUsIDE2IEp1biAyMDIyIDEwOjQzOjI5ICswODAwClN1YmplY3Q6IFtQQVRDSF0gdmlyTWFj QWRkclBhcnNlOiBGaXggd3JvbmcgdGVybWluYXRpb24gY2hhcmFjdGVyCgpUaGUganVkZ21lbnQg b2YgdGhlIHRlcm1pbmF0aW9uIGNoYXJhY3RlciBzaG91bGQgYmUgdGhlIG51bGwgY2hhcmFjdGVy LCBub3QKYSBzcGFjZS4gVXNpbmcgc3BhY2VzIHRvIGp1ZGdlLCBjb250ZW50IGNhbiBiZSBpbmpl Y3RlZCBpbnRvIG1hYy4gc3VjaCBhczoKIjcwOmFmOmU3OjFmOjNmOjg5XDAwMQppbmplY3RlZCIu CgpUaGlzIHdpbGwgcmVzdWx0IGluIGFuIGVycm9yOiAidmlyTmV0U29ja2V0UmVhZFdpcmU6MTgw NSA6IEVuZCBvZiBmaWxlCndoaWxlIHJlYWRpbmcgZGF0YTogSW5wdXQvb3V0cHV0IGVycm9yIgot LS0KIHNyYy91dGlsL3Zpcm1hY2FkZHIuYyB8IDIgKy0KIDEgZmlsZSBjaGFuZ2VkLCAxIGluc2Vy dGlvbigrKSwgMSBkZWxldGlvbigtKQoKZGlmZiAtLWdpdCBhL3NyYy91dGlsL3Zpcm1hY2FkZHIu YyBiL3NyYy91dGlsL3Zpcm1hY2FkZHIuYwppbmRleCA2YjIyMzg0Y2VlLi41YzRhYTA3NzEzIDEw MDY0NAotLS0gYS9zcmMvdXRpbC92aXJtYWNhZGRyLmMKKysrIGIvc3JjL3V0aWwvdmlybWFjYWRk ci5jCkBAIC0xNjMsNyArMTYzLDcgQEAgdmlyTWFjQWRkclBhcnNlKGNvbnN0IGNoYXIqIHN0ciwg dmlyTWFjQWRkciAqYWRkcikKCiAgICAgICAgIGFkZHItPmFkZHJbaV0gPTNEICh1bnNpZ25lZCBj aGFyKSByZXN1bHQ7CgotICAgICAgICBpZiAoKGkgPTNEPTNEIDUpICYmICgqZW5kX3B0ciA8PTNE ICcgJykpCisgICAgICAgIGlmICgoaSA9M0Q9M0QgNSkgJiYgKCplbmRfcHRyIDw9M0QgMCkpCiAg ICAgICAgICAgICByZXR1cm4gMDsKICAgICAgICAgaWYgKCplbmRfcHRyICE9M0QgJzonKQogICAg ICAgICAgICAgYnJlYWs7Ci0tPTIwCjIuMzIuMA== --000000000000e8687705e1880ffe Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
From 7df034e93d392c734ac5c4f4148a3d05f9edce29 Mon Sep 17 0= 0:00:00 2001
From: WuLongTao <eustancewu@gmail.com>
Date: Thu, 16 Jun 2022 10:43:29 +0800
S= ubject: [PATCH] virMacAddrParse: Fix wrong termination character

The= judgment of the termination character should be the null character, not a = space. Using spaces to judge, content can be injected into mac. such as: &q= uot;70:af:e7:1f:3f:89\001
injected".

This will result in an = error: "virNetSocketReadWire:1805 : End of file while reading data: In= put/output error"
---
=C2=A0src/util/virmacaddr.c | 2 +-
=C2= =A01 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/ut= il/virmacaddr.c b/src/util/virmacaddr.c
index 6b22384cee..5c4aa07713 100= 644
--- a/src/util/virmacaddr.c
+++ b/src/util/virmacaddr.c
@@ -16= 3,7 +163,7 @@ virMacAddrParse(const char* str, virMacAddr *addr)
=C2=A0<= br>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0addr->addr[i] =3D (unsigned char) r= esult;
=C2=A0
- =C2=A0 =C2=A0 =C2=A0 =C2=A0if ((i =3D=3D 5) &&= ; (*end_ptr <=3D ' '))
+ =C2=A0 =C2=A0 =C2=A0 =C2=A0if ((i = =3D=3D 5) && (*end_ptr <=3D 0))
=C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0return 0;
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0if (*end= _ptr !=3D ':')
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0b= reak;
--
2.32.0
--000000000000e8687705e1880ffe--