From nobody Wed May 15 22:28:21 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail(p=none dis=none) header.from=gmail.com Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1655359773175781.4630278418762; Wed, 15 Jun 2022 23:09:33 -0700 (PDT) Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-618-KNu0HaHGNDqWYKTZEn1m8A-1; Thu, 16 Jun 2022 02:09:28 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 04ADF811E75; Thu, 16 Jun 2022 06:09:27 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id 2C75F2026D2D; Thu, 16 Jun 2022 06:09:24 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id ED9E91947055; Thu, 16 Jun 2022 06:09:23 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id AA9011947052 for ; Thu, 16 Jun 2022 06:09:22 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id 7E65740CF8E4; Thu, 16 Jun 2022 06:09:22 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast09.extmail.prod.ext.rdu2.redhat.com [10.11.55.25]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 79D5E401015E for ; Thu, 16 Jun 2022 06:09:22 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-2.mimecast.com [207.211.31.81]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 5F92329AB3F0 for ; Thu, 16 Jun 2022 06:09:22 +0000 (UTC) Received: from mail-il1-f173.google.com (mail-il1-f173.google.com [209.85.166.173]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-209-OOuvVS7YPNumI5lWo7UFGQ-1; Thu, 16 Jun 2022 02:09:18 -0400 Received: by mail-il1-f173.google.com with SMTP id r3so274674ilt.8 for ; Wed, 15 Jun 2022 23:09:18 -0700 (PDT) X-MC-Unique: KNu0HaHGNDqWYKTZEn1m8A-1 X-Original-To: libvir-list@listman.corp.redhat.com X-MC-Unique: OOuvVS7YPNumI5lWo7UFGQ-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=Ydaqgdsn4sy1sjyq+18CuC8c3ba0SxXE6Eg2sH1BP/Q=; b=T9g9j6zMT2m0htR1/JhtLVniH4Tyo56LSmcC1ZEQHphUcpkrZp0bWGyg1nsqXzPa1U fT+NLlokF/1WhmEyQDLH6rOC/ZmeW+v3LSyJQ+Jv4VbKmVS5unpfYOD3yIP8RSJyjoVU NIZj1m5ta9D2FBocUIPP0+0G2MIHGTLKSzRNNPTVtzjIGJ3lGF/AE1DgZ8ym7/AiMp1A 98EOKOyzfti5/ERXwhQN1DQMItLsMisCtCxfL8yafUSGcpig0xi+KotBhy875HJkJ4rc AYK9oLiAzFJ3MOyObMuIXHXOPFECfwDm+RXi6iFOoOJqJHblwHn/iEpWMFhQujtB3Ibz VEfw== X-Gm-Message-State: AJIora8cpJEg8biL+VweBA6ebU+qNfjOMLLYH0SETI7po4a12O0d/3RF tCUXh6J5yL7mpMxKR2kRudlZV7ui8JFg1bwq3Bi7/kdFEPXnWycq7tmzhA== X-Google-Smtp-Source: AGRyM1viFiUtTWugmS5Y9c+uSWvz7CJUUrl4IdGWPy4321wQWO+/ZVgcRGf8XxuxH1f2du21rdENuaaKFIPC13jvcX0= X-Received: by 2002:a05:6e02:1523:b0:2d3:cb16:2d03 with SMTP id i3-20020a056e02152300b002d3cb162d03mr1941956ilu.198.1655359757939; Wed, 15 Jun 2022 23:09:17 -0700 (PDT) MIME-Version: 1.0 From: Eustance Wu Date: Thu, 16 Jun 2022 14:09:06 +0800 Message-ID: Subject: [PATCH] virMacAddrParse: Fix wrong termination character To: libvir-list@redhat.com X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection Definition; Similar Internal Domain=false; Similar Monitored External Domain=false; Custom External Domain=false; Mimecast External Domain=false; Newly Observed Domain=false; Internal User Name=false; Custom Display Name List=false; Reply-to Address Mismatch=false; Targeted Threat Dictionary=false; Mimecast Threat Dictionary=false; Custom Threat Dictionary=false X-Scanned-By: MIMEDefang 2.84 on 10.11.54.1 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: multipart/alternative; boundary="00000000000058f8e505e18a7a44" X-ZM-MESSAGEID: 1655359774827100001 Content-Transfer-Encoding: quoted-printable --00000000000058f8e505e18a7a44 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 RnJvbSBlZjIyZTUzYzkzNjBkZGI0YmRmZjYxYTEyMDEzYTI4MTJmYjczNDZhIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBsb25ndGFvIDxsb25ndGFvLnd1QHpzdGFjay5pbz4KRGF0ZTog VGh1LCAxNiBKdW4gMjAyMiAxNDowODoxNCArMDgwMApTdWJqZWN0OiBbUEFUQ0hdIHZpck1hY0Fk ZHJQYXJzZTogRml4IHdyb25nIHRlcm1pbmF0aW9uIGNoYXJhY3RlcgoKVGhlIGp1ZGdtZW50IG9m IHRoZSB0ZXJtaW5hdGlvbiBjaGFyYWN0ZXIgc2hvdWxkIGJlIHRoZSAnXDAnIGNoYXJhY3Rlciwg bm90CmEgc3BhY2UuClVzaW5nIHNwYWNlcyB0byBqdWRnZSwgY29udGVudCBjYW4gYmUgaW5qZWN0 ZWQgaW50byBtYWMuIHN1Y2ggYXM6CiI3MDphZjplNzoxZjozZjo4OVwzMmluamVjdGVkIi4KCkJl Zm9yZSB0aGlzIHBhdGNoLCB0aGUgdGVybWluYXRpbmcgY2hhcmFjdGVyIHdhcyBhIHNwYWNlICgn XDMyJyksbm90ICdcMCcuClNvIEkgY2FuIHNldCB0aGUgREhDUCBob3N0IG1hYyBsaWtlIHRoaXMg Ijxob3N0IG1hYz0zRCdjMDozYjowNDoyMToxNTozNQogaW5qZWN0ZWQnIG5hbWU9M0QnbmFtZTEy OScgaXA9M0QnMTkyLjE2OC4xMDAuMTI5Jy8+Ii4KV2hlbiBydW5uaW5nIHRoZSBuZXR3b3JrLCBu byBlcnJvciBpcyByZXBvcnRlZC4KQnV0LCB3aGVuIHVzaW5nIHRoaXMgbWFjIHRvIGNyZWF0ZSBh IHZpcnR1YWwgbWFjaGluZSwgIFdpbGwgZ2V0CiJ2aXJOZXRTb2NrZXRSZWFkV2lyZToxODA1IDog RW5kIG9mIGZpbGUgd2hpbGUgcmVhZGluZyBkYXRhOiBJbnB1dC9vdXRwdXQKZXJyb3IiIGluIHRo ZSBsaWJ2aXJ0ZCBsb2cuCi0tLQogc3JjL3V0aWwvdmlybWFjYWRkci5jIHwgMiArLQogMSBmaWxl IGNoYW5nZWQsIDEgaW5zZXJ0aW9uKCspLCAxIGRlbGV0aW9uKC0pCgpkaWZmIC0tZ2l0IGEvc3Jj L3V0aWwvdmlybWFjYWRkci5jIGIvc3JjL3V0aWwvdmlybWFjYWRkci5jCmluZGV4IDZiMjIzODRj ZWUuLmJhN2M3ZTcwNzYgMTAwNjQ0Ci0tLSBhL3NyYy91dGlsL3Zpcm1hY2FkZHIuYworKysgYi9z cmMvdXRpbC92aXJtYWNhZGRyLmMKQEAgLTE2Myw3ICsxNjMsNyBAQCB2aXJNYWNBZGRyUGFyc2Uo Y29uc3QgY2hhciogc3RyLCB2aXJNYWNBZGRyICphZGRyKQoKICAgICAgICAgYWRkci0+YWRkcltp XSA9M0QgKHVuc2lnbmVkIGNoYXIpIHJlc3VsdDsKCi0gICAgICAgIGlmICgoaSA9M0Q9M0QgNSkg JiYgKCplbmRfcHRyIDw9M0QgJyAnKSkKKyAgICAgICAgaWYgKChpID0zRD0zRCA1KSAmJiAoKmVu ZF9wdHIgPTNEPTNEIDApKQogICAgICAgICAgICAgcmV0dXJuIDA7CiAgICAgICAgIGlmICgqZW5k X3B0ciAhPTNEICc6JykKICAgICAgICAgICAgIGJyZWFrOwotLT0yMAoyLjMyLjA= --00000000000058f8e505e18a7a44 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
From ef22e53c9360ddb4bdff61a12013a2812fb7346a Mon Sep= 17 00:00:00 2001
From: longtao <longtao.wu@zstack.io>
Date: Thu, 16 Jun 2022 14:08:14 +0800Subject: [PATCH] virMacAddrParse: Fix wrong termination character

= The judgment of the termination character should be the '\0' charac= ter, not a space.
Using spaces to judge, content can be injected into ma= c. such as: "70:af:e7:1f:3f:89\32injected".

Before this pa= tch, the terminating character was a space ('\32'),not '\0'= .
So I can set the DHCP host mac like this "<host mac=3D'c0:= 3b:04:21:15:35 =C2=A0injected' name=3D'name129' ip=3D'192.1= 68.100.129'/>".
When running the network, no error is report= ed.
But, when using this mac to create a virtual machine, =C2=A0Will get= "virNetSocketReadWire:1805 : End of file while reading data: Input/ou= tput error" in the libvirtd log.
---
=C2=A0src/util/virmacaddr.c= | 2 +-
=C2=A01 file changed, 1 insertion(+), 1 deletion(-)

diff = --git a/src/util/virmacaddr.c b/src/util/virmacaddr.c
index 6b22384cee..= ba7c7e7076 100644
--- a/src/util/virmacaddr.c
+++ b/src/util/virmacad= dr.c
@@ -163,7 +163,7 @@ virMacAddrParse(const char* str, virMacAddr *ad= dr)
=C2=A0
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0addr->addr[i] =3D (un= signed char) result;
=C2=A0
- =C2=A0 =C2=A0 =C2=A0 =C2=A0if ((i =3D= =3D 5) && (*end_ptr <=3D ' '))
+ =C2=A0 =C2=A0 =C2=A0= =C2=A0if ((i =3D=3D 5) && (*end_ptr =3D=3D 0))
=C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0return 0;
=C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0if (*end_ptr !=3D ':')
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0break;
--
2.32.0
--00000000000058f8e505e18a7a44--