From nobody Fri May 10 20:02:48 2024 Delivered-To: importer@patchew.org Received-SPF: none (zohomail.com: 8.43.85.245 is neither permitted nor denied by domain of lists.libvirt.org) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; spf=none (zohomail.com: 8.43.85.245 is neither permitted nor denied by domain of lists.libvirt.org) smtp.mailfrom=devel-bounces@lists.libvirt.org; arc=fail (BodyHash is different from the expected one); dmarc=fail(p=none dis=none) header.from=outlook.com Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1710198425558154.48660541668687; Mon, 11 Mar 2024 16:07:05 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 996) id E34931E2E; Mon, 11 Mar 2024 19:07:00 -0400 (EDT) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id ABAE01DF2; Mon, 11 Mar 2024 19:05:27 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 996) id C64BA1DEA; Mon, 11 Mar 2024 19:05:23 -0400 (EDT) Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-vi1eur04olkn2070.outbound.protection.outlook.com [40.92.75.70]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id C606B1DDE for ; Mon, 11 Mar 2024 19:05:21 -0400 (EDT) Received: from AM9P193MB1126.EURP193.PROD.OUTLOOK.COM (2603:10a6:20b:1f0::16) by GV1P193MB2087.EURP193.PROD.OUTLOOK.COM (2603:10a6:150:22::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7362.35; Mon, 11 Mar 2024 23:05:18 +0000 Received: from AM9P193MB1126.EURP193.PROD.OUTLOOK.COM ([fe80::ebbc:1923:3a93:3ef1]) by AM9P193MB1126.EURP193.PROD.OUTLOOK.COM ([fe80::ebbc:1923:3a93:3ef1%6]) with mapi id 15.20.7362.035; Mon, 11 Mar 2024 23:05:18 +0000 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=0.2 required=5.0 tests=FORGED_SPF_HELO, FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.4 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hzgI6TQx73Hby1DvZpn1QfOwlG0wtkRsCeSdsYbkU4MTjOhKeGr8B1KWIERSJhGuVWb5PFvaalVTNDZYQ6lQKz8mzUUvKFjXQa7XqooWjaiLPtF8UwjYSga6AlCcK1XlHvUsVS76oPGQYZ/4OFfJu9xJpPARhO0Mn9N8ki1dhrRaYl5102fIhEQpXH4qFLQRNtqasoqpxMy42KG7LIcnWNpxuhZXIU7JQ6sMLxRhDFCec5cM1vn+wxUmmEDbaAPTFTd9veK95vvmL1qJzx/2SvBFRvpd3nXybcOBfuH0TosLJoRpHVyqrofBO3ZRhC1siCGaIA7FKLO7tjR3QApvRQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=lLh3jIZF1N4oEop+Gl4PZVVXX/92xKxmLEj6Om/hpSg=; b=Wzs9uPW+pfjM55anIfgUUSc15K5MvHf5a0+oPl3VpTIIFDp8PrDNnQrFhm3NMrCPq//J3Cj0WFQGJAWn5T4DfAblndmsWawjbhASrSFksfPii5COl1BOPU5b3jt1rBP6+aLhZo02tFmlF2pmTA7h2xFp2FnBWsM3+3tMaLvetDy6vQirQZGNZmloLJ+40EVndcDwTnoXHi7vdaXnGKXJaj13weEm7GBz+fhrL7aSc4AtMgkCzi8eWz4G7xrrJf5nfRz1dD1J4Itrp7SvE5oJ73y1i+aInyi3wBQpog7+99B1rK+xEAapF2hSE4knqhgXcXnafWD51REp3vPlUwYS1w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none From: Mostafa To: devel@lists.libvirt.org Subject: [PATCH v2] Remove VIR_FREE in favor of g_autofree in some functions in libvrit-domain.c Date: Tue, 12 Mar 2024 00:11:28 +0200 Message-ID: X-Mailer: git-send-email 2.34.1 X-TMN: [+wSs5MmLXM0RC+cL7ZBmRrFLrWAZ0b/B] X-ClientProxiedBy: MR2P264CA0188.FRAP264.PROD.OUTLOOK.COM (2603:10a6:501::27) To AM9P193MB1126.EURP193.PROD.OUTLOOK.COM (2603:10a6:20b:1f0::16) X-Microsoft-Original-Message-ID: <20240311221128.120451-1-recenum@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AM9P193MB1126:EE_|GV1P193MB2087:EE_ X-MS-Office365-Filtering-Correlation-Id: 9a235dea-2695-4dfc-0ced-08dc421fb7e2 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ywLKV5BSaDPaUsY+aZaNtaTF6tEV4MfgUYNjwm5nHRR/kWQQwB4ZWDyrMVMYKEu0EvkEJiFZZVnPsK0OYx9Rsn1w0wt7sa58iCTJKf+lJynKjy6NEqRxJob1AooPbyP0Tv+8rUuw++igQ2jA9BtZA/hdUArcwWkXcv1DuBYkTTKiSiEjvgo8zSSK+3ESo92QDtcPhn0tma7DP5uOwrOZFYjEEYyXPJ4U8xVYIst/rqAGBrxrETScXMCW/f+Qtmh7BYYnsjKoB2S17kkJyFmqwxUIedJe5brj2UFiG9iv+6e18DA0ZOd2Qham41yplwkGOXwNm8zgeCWjhEzbvoO2hf0+3ecwV/CdCfCXjlGNfCzS4AD42JvImwqacWF7HEqOLlMDQ5PbLiL+HqRwxxzWhlyh3WO4iOHkbSzEaXuFlUmM04VZ1oXGBUaumTskAdCVtTQSvIO2ebUwsMMJVZy48iJqSZ13Nojv7zl8MPksMfI/LIFsBPOO2FLWxVZbApgEocfM5307FYjEIDEAEmg71bEai9qpMPeL2699kfQkf19NccIpUqXEO/AOoTM0l//5qmaXNxD1nOy3yixh5/0hqH8JqOGg7yamiZBX9H6M4Ds= X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?si0TP+BZnwqxblHnomD4NhJx51ngJoR3TSxafVHpK+zQT34+UUKWTYWKT5nV?= =?us-ascii?Q?RKwEJFs9BmOHQRb5XuQ4hJJYpkyCNUaZnBZq7PNCpLWja1PrAGqTGjsCLlrN?= =?us-ascii?Q?Gq7lb4xuWpjWArRZskqYaNzGatXZ7Q8DsoMaJ4zjx/YsEwDZuTigU2xDDz/9?= =?us-ascii?Q?EtrPl0S/cm3p9Dixh66r/znjBU5tiBT+xAv+4OV7TAtUp1cWuUzKNlTJw/Te?= =?us-ascii?Q?+tkI5ZruCvUqKLXYqzEVzfcxigdGJ4U3OHC+oOwdr0r/Q0Jbeq3tNN50BvtT?= =?us-ascii?Q?7csTjM8gUB4p+R0QhfGhmNQCw2fLcFLCRABuZThbD61q8I0/vd7RrMnKepYZ?= =?us-ascii?Q?9F1fn8ZMwFHAV8B+mNP7IgtHmBhInvpsmRawKDBJMBVyd9Bb2IBjFkui4e0K?= =?us-ascii?Q?2081lCMB8iPjf++GzjPGBOVElJBKZHqmAJLGjKCrp6nfi6YkItW9yzoVH3kN?= =?us-ascii?Q?L8rxSVU2XS1FgVr43SM9t0+McfMoDJhX4RGLU8VB1NONuwTfC3l84yXffU1C?= =?us-ascii?Q?/fYimFG2qbAwoHIfXg2kMWUccKC803Tbs+tH1ZIdRoFX8Lt3bEFwsPllruRM?= =?us-ascii?Q?NqZn4egJ0OuPQ8ak1W+z9+RNEDR6AFwavZyGSXrJ3tubM00sGxOwjkObrU8m?= =?us-ascii?Q?4cKRuAvI/HOdTQtZDbqP+zTjqrMJby13mH1kR16JvR9HtBK7RyAMpSBMoQXI?= =?us-ascii?Q?nZ/M3c52EOMnri3UGaMQO5sradCsgwIJ0Ecgh5n33W10NA9m/gkNgkMYNK0g?= =?us-ascii?Q?91nuEBSTeLQ+MVHIEubXIH63FJ7VfqvDbxp3e36CNrF/hKUfeGOt8cwvZbdv?= =?us-ascii?Q?+48t2AU5Gdh2tkf+PWdDkyyJBIlLRObhy1MKTk+dipGtinmnvQwOzPWB9HN8?= =?us-ascii?Q?nn1eu6eyvFvshPG8EIBFKN2h/LtVm0pc76fBtYfmq68rSO/h08mAuFzW19x1?= =?us-ascii?Q?shImuUPTiFOhQ7em3C1HOHFp5ET0mW7z1ERidSFnflHxYtWwSpPlG2o3E7k9?= =?us-ascii?Q?bH9AmY6txBRTfazaIi/9zWXs0YABdWi7PdqNChNiT7YVJHXpsxk1b6m8x4rN?= =?us-ascii?Q?oumGqw+g9qPeM849MlnBGnTzXZLbP0a+ldOrpVsPv9AU2xX1zbYs7IkWKu7y?= =?us-ascii?Q?9GORzrPV2dLsh/H2ACHKgvCdUKf+ySFZDhcx9bY85AMw8ZFcZVLi1P1G1wnp?= =?us-ascii?Q?b5mzbqquI9/9FHpzc3GVcakGdW9uwBYoB9goOh72rdQI6ylsySe+Ge60mWk?= =?us-ascii?Q?=3D?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9a235dea-2695-4dfc-0ced-08dc421fb7e2 X-MS-Exchange-CrossTenant-AuthSource: AM9P193MB1126.EURP193.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Mar 2024 23:05:18.0994 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV1P193MB2087 Message-ID-Hash: TFNZ3AEZI7GFOGDX3UWB426GNNKOGGFW X-Message-ID-Hash: TFNZ3AEZI7GFOGDX3UWB426GNNKOGGFW X-MailFrom: recenum@outlook.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header CC: Mostafa X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZM-MESSAGEID: 1710198425856100001 Signed-off-by: Mostafa Reviewed-by: Peter Krempa --- src/libvirt-domain.c | 32 ++++++++------------------------ 1 file changed, 8 insertions(+), 24 deletions(-) diff --git a/src/libvirt-domain.c b/src/libvirt-domain.c index 83abad251e..4ba3563c9e 100644 --- a/src/libvirt-domain.c +++ b/src/libvirt-domain.c @@ -884,7 +884,7 @@ virDomainSave(virDomainPtr domain, const char *to) =20 if (conn->driver->domainSave) { int ret; - char *absolute_to; + g_autofree char *absolute_to =3D NULL; =20 /* We must absolutize the file path as the save is done out of pro= cess */ if (!(absolute_to =3D g_canonicalize_filename(to, NULL))) { @@ -895,8 +895,6 @@ virDomainSave(virDomainPtr domain, const char *to) =20 ret =3D conn->driver->domainSave(domain, absolute_to); =20 - VIR_FREE(absolute_to); - if (ret < 0) goto error; return ret; @@ -974,7 +972,7 @@ virDomainSaveFlags(virDomainPtr domain, const char *to, =20 if (conn->driver->domainSaveFlags) { int ret; - char *absolute_to; + g_autofree char *absolute_to =3D NULL; =20 /* We must absolutize the file path as the save is done out of pro= cess */ if (!(absolute_to =3D g_canonicalize_filename(to, NULL))) { @@ -985,8 +983,6 @@ virDomainSaveFlags(virDomainPtr domain, const char *to, =20 ret =3D conn->driver->domainSaveFlags(domain, absolute_to, dxml, f= lags); =20 - VIR_FREE(absolute_to); - if (ret < 0) goto error; return ret; @@ -1076,7 +1072,7 @@ virDomainRestore(virConnectPtr conn, const char *from) =20 if (conn->driver->domainRestore) { int ret; - char *absolute_from; + g_autofree char *absolute_from =3D NULL; =20 /* We must absolutize the file path as the restore is done out of = process */ if (!(absolute_from =3D g_canonicalize_filename(from, NULL))) { @@ -1087,8 +1083,6 @@ virDomainRestore(virConnectPtr conn, const char *from) =20 ret =3D conn->driver->domainRestore(conn, absolute_from); =20 - VIR_FREE(absolute_from); - if (ret < 0) goto error; return ret; @@ -1156,7 +1150,7 @@ virDomainRestoreFlags(virConnectPtr conn, const char = *from, const char *dxml, =20 if (conn->driver->domainRestoreFlags) { int ret; - char *absolute_from; + g_autofree char *absolute_from =3D NULL; =20 /* We must absolutize the file path as the restore is done out of = process */ if (!(absolute_from =3D g_canonicalize_filename(from, NULL))) { @@ -1168,8 +1162,6 @@ virDomainRestoreFlags(virConnectPtr conn, const char = *from, const char *dxml, ret =3D conn->driver->domainRestoreFlags(conn, absolute_from, dxml, flags); =20 - VIR_FREE(absolute_from); - if (ret < 0) goto error; return ret; @@ -1263,7 +1255,7 @@ virDomainSaveImageGetXMLDesc(virConnectPtr conn, cons= t char *file, =20 if (conn->driver->domainSaveImageGetXMLDesc) { char *ret; - char *absolute_file; + g_autofree char *absolute_file =3D NULL; =20 /* We must absolutize the file path as the read is done out of pro= cess */ if (!(absolute_file =3D g_canonicalize_filename(file, NULL))) { @@ -1275,8 +1267,6 @@ virDomainSaveImageGetXMLDesc(virConnectPtr conn, cons= t char *file, ret =3D conn->driver->domainSaveImageGetXMLDesc(conn, absolute_fil= e, flags); =20 - VIR_FREE(absolute_file); - if (!ret) goto error; return ret; @@ -1338,7 +1328,7 @@ virDomainSaveImageDefineXML(virConnectPtr conn, const= char *file, =20 if (conn->driver->domainSaveImageDefineXML) { int ret; - char *absolute_file; + g_autofree char *absolute_file =3D NULL; =20 /* We must absolutize the file path as the read is done out of pro= cess */ if (!(absolute_file =3D g_canonicalize_filename(file, NULL))) { @@ -1350,8 +1340,6 @@ virDomainSaveImageDefineXML(virConnectPtr conn, const= char *file, ret =3D conn->driver->domainSaveImageDefineXML(conn, absolute_file, dxml, flags); =20 - VIR_FREE(absolute_file); - if (ret < 0) goto error; return ret; @@ -1415,7 +1403,7 @@ virDomainCoreDump(virDomainPtr domain, const char *to= , unsigned int flags) =20 if (conn->driver->domainCoreDump) { int ret; - char *absolute_to; + g_autofree char *absolute_to =3D NULL; =20 /* We must absolutize the file path as the save is done out of pro= cess */ if (!(absolute_to =3D g_canonicalize_filename(to, NULL))) { @@ -1426,8 +1414,6 @@ virDomainCoreDump(virDomainPtr domain, const char *to= , unsigned int flags) =20 ret =3D conn->driver->domainCoreDump(domain, absolute_to, flags); =20 - VIR_FREE(absolute_to); - if (ret < 0) goto error; return ret; @@ -1501,7 +1487,7 @@ virDomainCoreDumpWithFormat(virDomainPtr domain, cons= t char *to, =20 if (conn->driver->domainCoreDumpWithFormat) { int ret; - char *absolute_to; + g_autofree char *absolute_to =3D NULL; =20 /* We must absolutize the file path as the save is done out of pro= cess */ if (!(absolute_to =3D g_canonicalize_filename(to, NULL))) { @@ -1513,8 +1499,6 @@ virDomainCoreDumpWithFormat(virDomainPtr domain, cons= t char *to, ret =3D conn->driver->domainCoreDumpWithFormat(domain, absolute_to, dumpformat, flags); =20 - VIR_FREE(absolute_to); - if (ret < 0) goto error; return ret; --=20 2.34.1 _______________________________________________ Devel mailing list -- devel@lists.libvirt.org To unsubscribe send an email to devel-leave@lists.libvirt.org