From nobody Wed May 15 04:37:27 2024 Delivered-To: importer@patchew.org Received-SPF: none (zohomail.com: 8.43.85.245 is neither permitted nor denied by domain of lists.libvirt.org) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; spf=none (zohomail.com: 8.43.85.245 is neither permitted nor denied by domain of lists.libvirt.org) smtp.mailfrom=devel-bounces@lists.libvirt.org; arc=fail (BodyHash is different from the expected one); dmarc=fail(p=none dis=none) header.from=outlook.com Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1710116341955458.6479917167287; Sun, 10 Mar 2024 17:19:01 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 996) id 94D8E1D6F; Sun, 10 Mar 2024 20:19:00 -0400 (EDT) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id 7A77C1C7E; Sun, 10 Mar 2024 20:16:48 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 996) id 7C9AD1C7D; Sun, 10 Mar 2024 20:16:39 -0400 (EDT) Received: from EUR02-AM0-obe.outbound.protection.outlook.com (mail-am0eur02olkn2103.outbound.protection.outlook.com [40.92.49.103]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 4CA7D1C76 for ; Sun, 10 Mar 2024 20:16:37 -0400 (EDT) Received: from AM8P193MB1124.EURP193.PROD.OUTLOOK.COM (2603:10a6:20b:1e2::17) by PAXP193MB1360.EURP193.PROD.OUTLOOK.COM (2603:10a6:102:133::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7362.34; Mon, 11 Mar 2024 00:16:34 +0000 Received: from AM8P193MB1124.EURP193.PROD.OUTLOOK.COM ([fe80::a4db:cc9a:2027:8ba]) by AM8P193MB1124.EURP193.PROD.OUTLOOK.COM ([fe80::a4db:cc9a:2027:8ba%5]) with mapi id 15.20.7362.035; Mon, 11 Mar 2024 00:16:34 +0000 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: * X-Spam-Status: No, score=1.2 required=5.0 tests=FORGED_SPF_HELO, FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.4 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UgOPtJwwgXkndaK+4u6EzlqRnuvPEPHeozppv+GHXdAaAAH6hbbHvrE2PHJgdTynvU9O7VlJcjfSJXjRJqB09qJjKVuZ7+Mdhs4RnxSjAGL/WG2OcT+fJbf5NdtqN9JB+bu6IJLwVK6qGfyZK+txwh5ypp4YygOS7pWV3QbPEI2GU7HoF09UcZFZyJe/1evIINXZERcGsyV2SkbMLSIS6wmOGek7Z1+kF0ClwI4p8u8NR4dDdGe1A5jwAqLlSBzSGsjquOwwzvDQ7bwutvGX/v3geoC9DwIPOjw7oDz+nHx3GzcKJJUKneoExG7iaAWO4Sfb/usjoQMpY8j1Jh6sIA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=N4QfdzO0Kxj8VmkpTlOJi5AiRamMC4YH29eRYkn7dgo=; b=P+j+sTEHSfnFCiqHtuA0hCo1Lcz/nykKVVlq5QsMFjepl1oSy0GGlpycsdDXyjGN0Y8aIpyTt9ieFTJLUjsc7+Pe/TaB4rOI9ldHxi8wOLv4rhfCswGfWqcw5X37znPPcC2UXcnZxae0X6IpSkklIViGCwGUxRAz88vjYqkiyoNd7/CzWKbJ5tcwLHwSEpl4X5ODWKzxdigG1AwYlcX1cYZrDVvyT13vUZ5oant9BpR2epRwLIcudCmK+B0pPgi3q0qlCtKwSotL2oknSYb43Jf9n4ZEFK6fgVIRdLEMhsZAt4II1m/qBocISqP6XWqMhh7booXSsKot7HAuiLfGEQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none From: Mostafa To: devel@lists.libvirt.org Subject: [PATCH] Remove VIR_FREE in favor of g_autofree in some functions in libvrit-domain.c Date: Mon, 11 Mar 2024 02:15:32 +0200 Message-ID: X-Mailer: git-send-email 2.34.1 X-TMN: [Cqsy4FWw6TK7pYUULfqWoqxYM9i5+iJUBKeDMyXuI18=] X-ClientProxiedBy: MR2P264CA0041.FRAP264.PROD.OUTLOOK.COM (2603:10a6:500::29) To AM8P193MB1124.EURP193.PROD.OUTLOOK.COM (2603:10a6:20b:1e2::17) X-Microsoft-Original-Message-ID: <20240311001532.50347-1-recenum@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AM8P193MB1124:EE_|PAXP193MB1360:EE_ X-MS-Office365-Filtering-Correlation-Id: e6c87c14-1f1f-4a5d-c762-08dc416082a2 X-MS-Exchange-SLBlob-MailProps: AlkLxVwsndk1AS9jZirPPIVQoLcFywHLyk87YK1SodGXxeZtuMAPtddU+BgWdvf13LNN5cW2eSJqAmr6ygI/ZF+C4NsQQ9IzH6JejlNHhD22Su1VrGFNYs9QiCZKjYb1ouUzqe/orRqUeKPQ5Bd9Pv2lTq2ju1MSt6k1kt96h1L1kGa63eA4NRGiL2pOqSvLJ9o4E6e726lS+Cog88sFWpISYpSmMxGoNyy8Ad61z6jL4HjvBUBHCCddXzBARb0IIf1cfqlRA16QAIPyZeh2EjY4OH4UcukO7MvejYfYgv9KH77kHQCAp3zSIGG99WrhLj6II805PjYObqBqBLepRtng+lU3hwGUwceCYU0M4l92JP32Z+6wBkzg6GtNVmgk2B9Yp9rT4upE4pPIFQgj0SoLO4hhP01Eg6I8MYte147JsSt4QWzfux9RkRI6wKeR/n510SW3uh5/xSfODUgDsVzKlyQLdnA18KUJSRJZ7/OUrQ7qjWDoSUMQhXRBA4kVgl840Nmk6Q8cyqxxVkAYafY6zfTRWBW4kv1MYIjfrM/MPBKmhb1IaWKAE/3QoFg2KxTF7TeNAYZzZLxAxzRK+5JsyEv37lJ7IJGpQNC8NoKNHI8aKWQsiv1HjY61uX9tRv7L4hPcE3Qk7TNJeUY67rRLK5RpDHWAk9+SdkaDwoCWnY1Na4nvbxuIyktsctd7QJpRe4PyuBhTgLGnMwVkN1qaP2/eASYfx3omSzFptSMoc0Nx/kR3z86Z06XwdNgOnLthFHdkLySESfRGnowZvIwgF3VqAWv2 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: l70dqj5CAUhbtiefrnREMEkOhO6iDh26fGWX8b9RVBGOvJDaaVUrHKlIFJRzZC0y9phKIPbuX9JimG2Xk44YBn4H47wyFgkLoNVOWEDow+jQEsMQ/BVUTZDtb55ky4dSqfMaYYdaGCu848lscDP/MINLG4zsbtYbJbUinIoPNcV3OGh1PnzsXMXlE7DAkjCwWBTN8TD1piEWEI4OlqZJZwCsy5TmNtRD8hMjy8adTj+/cI+zAFWDftyrHxkbX5geFEkE2s+3Fy0FlcXrQ6Xt3xkGSykUqLwJXTS0UAuSaQxU3wkCINGStvPpi2Dv20hIebTT+LwpyIw0nFTQXelyx42hYQFmE6XiWwbcRHyFBVcI3sPO7MrVPlT8Qp8+eukhnmWUrCTe1dkYsdSz0AJ3t8q7YogtIWEBecSUMlcTBH7lVspu+kLth7Bcbx83qmkSGH30I3D5db0RfMUghLATalLPgRrcU2586hloCWW797LxloK9I4pGA2mflrud75Fxs9qI+ACpfSQCuOgt6DGu8z5hxxiC/hnzxx2J5ifeBXyF7zh9ZvJB+c6xiJCy9FRd X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bE5lVXI1SHYwZk9YclB0R2Y0YUh3TzVlcE9EamtLcEsyc2R6YVlaVXBCbkwz?= =?utf-8?B?ZjczZzI2WnpJRnBuN0t6T3RtTFlzRkQzUCtVWnFUUUJwT1I4OHJsL21EK1Nt?= =?utf-8?B?TWhhb1dZbVdQWFVhWTV6RFo3M29veWRFTG9melozZUpNOWxwY2FSY3BPbEww?= =?utf-8?B?ak1OZFU2QVpUWTErSGJKYkJsaXFuZXJ5NVRXOFZoY3JnUWMvcGRhbzNSRnlj?= =?utf-8?B?enAzb2hod0tuQ09VTEVXdTdRQk1LNDFtVWcvUFBrTVJuem1yYXlpdTN0eW9i?= =?utf-8?B?TytIdUEzRE9JSGNpNGVmekFhREpGZzBjVEh4KzBLMEMrUllmTjRyVk9CT3U1?= =?utf-8?B?bHVaMXlpUFZ0QWZIODBKa2hBUWFGQjFjUFdQTVNpWlpxQ2FJNUZvS012WVpl?= =?utf-8?B?ZGFrNFZRMlVVT2RYZjNNdDQ1RUg4L3FKM2Y5c3Uzc21jcGpVWElKSUExWngw?= =?utf-8?B?TnlZaE92YVVVT1FEKzcwUm5FTnJWNnV4YnBmSFA4VGdBQUFxT3B3eDFtM01l?= =?utf-8?B?Sks4RTNtY2tkSnNZR2JUVFJ1bXczaHpQcmhDSjBlVjY1ejA2N3BUdUVJQnQw?= =?utf-8?B?ekxkUXRLRm42bGpFZHo4Vm5ZZFlQaXBtK1BDK3R4elQ5V2VOa0M5M1FURHBI?= =?utf-8?B?KzFPODlkWkI0ZUtFdTBmTVZRRFhNS25qV0VxdjNOblltSkFCMlI3bm5NY2hR?= =?utf-8?B?bjZkbjdjQUk3NVNyb2dNTG1NYkplSTJGSStJeDgzdXNPUGtPd1JJUWYxVGlN?= =?utf-8?B?Um9wbTl3ZU5RYjlPTDhxZWsraEFXZzI4RGJIZjhUNXY0VkpRUUFvckVmaytN?= =?utf-8?B?bFlTejZSUVlGQm1HaytkYmNqbVdXa0ZxMnBvMzF5c1pnOU5Rc3JGUnQ1YkM1?= =?utf-8?B?YkRySWFnbitMUVF4bHhrSzJobVRiY1JZcGN6L2IvYnV0dzIxNElDMy9Uay9Z?= =?utf-8?B?YU9WR0dLSHVFQU16a3l3Ty9ZV1VQeEw0ejQ3TmFqcnRpWTErNGZPNkhzWGlL?= =?utf-8?B?cFlINUNvcE95ekpubCtaTHlNdnJqNUIydDdTQ05NdENmcmdBemFhcmJoNXVD?= =?utf-8?B?R0FYMkVHSkFGa0pzVVh3Q0JMcFJxRXFNTkRiUFBuWWpzTkIzaGdnQkhyQmlB?= =?utf-8?B?U0lFWlNoYi93RUF2ZWF4MW9TZmRwUVFjTmlCSkNBUWl3M1ZPcGZiNGlhWXk3?= =?utf-8?B?UVdWWEViUndXZnoyVk8vUkNQeitVRENFZTRrbFUvbzZlRWswb3h6bUVkSk1u?= =?utf-8?B?K1dZOEphUURrRHNjc1NGeEtObmIzL0hEdlNyRFRVb25Rb2J2MU5vTmNWbExz?= =?utf-8?B?cUd6NThDcUZmanVEakZXRDdRVXl2cE1qODViUndlRk4xMm9PZFFsd0FaSita?= =?utf-8?B?anVWZSthNkxHUDNmQWpnS3dIVHNCaTBrMUdmVTR2ajBwcUJkbjBzU2NKUFpH?= =?utf-8?B?WWI2a1dydk55cXYra09DVUZSSFdJTWdLWjF3d0N2aVkvbzYvWmJKTFo3THhn?= =?utf-8?B?NnN4MEhBcGpjVUxNOUk1K0VPNThLZUlaajY3YWhXZFFmMVEyb2t0SEFkemhz?= =?utf-8?B?TVJocVVIdENxSHA2ZzVhWlNYcUtBeEhIYzBKbTNoNThFOEhiejVRV2JoMHg1?= =?utf-8?Q?AIGs0p9y9gtu6skcZuav/nJ1tmc27r0HDMy7TPOVRvt8=3D?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: e6c87c14-1f1f-4a5d-c762-08dc416082a2 X-MS-Exchange-CrossTenant-AuthSource: AM8P193MB1124.EURP193.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Mar 2024 00:16:34.6686 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXP193MB1360 Message-ID-Hash: ZKSZW5ZTEMVHRCGNG5G6ABOD2BXOIYRC X-Message-ID-Hash: ZKSZW5ZTEMVHRCGNG5G6ABOD2BXOIYRC X-MailFrom: recenum@outlook.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header CC: =?UTF-8?q?=D9=85=D8=B5=D8=B7=D9=81=D9=8A=20=D9=85=D8=AD=D9=85=D9=88?= =?UTF-8?q?=D8=AF=20=D9=83=D9=85=D8=A7=D9=84=20=D8=A7=D9=84=D8=AF=D9=8A?= =?UTF-8?q?=D9=86?= <48567303+moste00@users.noreply.github.com> X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZM-MESSAGEID: 1710116342543100001 From: =D9=85=D8=B5=D8=B7=D9=81=D9=8A =D9=85=D8=AD=D9=85=D9=88=D8=AF =D9=83= =D9=85=D8=A7=D9=84 =D8=A7=D9=84=D8=AF=D9=8A=D9=86 <48567303+moste00@users.n= oreply.github.com> --- src/libvirt-domain.c | 32 ++++++++------------------------ 1 file changed, 8 insertions(+), 24 deletions(-) diff --git a/src/libvirt-domain.c b/src/libvirt-domain.c index 83abad251e..9b68a7ac95 100644 --- a/src/libvirt-domain.c +++ b/src/libvirt-domain.c @@ -884,7 +884,7 @@ virDomainSave(virDomainPtr domain, const char *to) =20 if (conn->driver->domainSave) { int ret; - char *absolute_to; + g_autofree char *absolute_to; =20 /* We must absolutize the file path as the save is done out of pro= cess */ if (!(absolute_to =3D g_canonicalize_filename(to, NULL))) { @@ -895,8 +895,6 @@ virDomainSave(virDomainPtr domain, const char *to) =20 ret =3D conn->driver->domainSave(domain, absolute_to); =20 - VIR_FREE(absolute_to); - if (ret < 0) goto error; return ret; @@ -974,7 +972,7 @@ virDomainSaveFlags(virDomainPtr domain, const char *to, =20 if (conn->driver->domainSaveFlags) { int ret; - char *absolute_to; + g_autofree char *absolute_to; =20 /* We must absolutize the file path as the save is done out of pro= cess */ if (!(absolute_to =3D g_canonicalize_filename(to, NULL))) { @@ -985,8 +983,6 @@ virDomainSaveFlags(virDomainPtr domain, const char *to, =20 ret =3D conn->driver->domainSaveFlags(domain, absolute_to, dxml, f= lags); =20 - VIR_FREE(absolute_to); - if (ret < 0) goto error; return ret; @@ -1076,7 +1072,7 @@ virDomainRestore(virConnectPtr conn, const char *from) =20 if (conn->driver->domainRestore) { int ret; - char *absolute_from; + g_autofree char *absolute_from; =20 /* We must absolutize the file path as the restore is done out of = process */ if (!(absolute_from =3D g_canonicalize_filename(from, NULL))) { @@ -1087,8 +1083,6 @@ virDomainRestore(virConnectPtr conn, const char *from) =20 ret =3D conn->driver->domainRestore(conn, absolute_from); =20 - VIR_FREE(absolute_from); - if (ret < 0) goto error; return ret; @@ -1156,7 +1150,7 @@ virDomainRestoreFlags(virConnectPtr conn, const char = *from, const char *dxml, =20 if (conn->driver->domainRestoreFlags) { int ret; - char *absolute_from; + g_autofree char *absolute_from; =20 /* We must absolutize the file path as the restore is done out of = process */ if (!(absolute_from =3D g_canonicalize_filename(from, NULL))) { @@ -1168,8 +1162,6 @@ virDomainRestoreFlags(virConnectPtr conn, const char = *from, const char *dxml, ret =3D conn->driver->domainRestoreFlags(conn, absolute_from, dxml, flags); =20 - VIR_FREE(absolute_from); - if (ret < 0) goto error; return ret; @@ -1263,7 +1255,7 @@ virDomainSaveImageGetXMLDesc(virConnectPtr conn, cons= t char *file, =20 if (conn->driver->domainSaveImageGetXMLDesc) { char *ret; - char *absolute_file; + g_autofree char *absolute_file; =20 /* We must absolutize the file path as the read is done out of pro= cess */ if (!(absolute_file =3D g_canonicalize_filename(file, NULL))) { @@ -1275,8 +1267,6 @@ virDomainSaveImageGetXMLDesc(virConnectPtr conn, cons= t char *file, ret =3D conn->driver->domainSaveImageGetXMLDesc(conn, absolute_fil= e, flags); =20 - VIR_FREE(absolute_file); - if (!ret) goto error; return ret; @@ -1338,7 +1328,7 @@ virDomainSaveImageDefineXML(virConnectPtr conn, const= char *file, =20 if (conn->driver->domainSaveImageDefineXML) { int ret; - char *absolute_file; + g_autofree char *absolute_file; =20 /* We must absolutize the file path as the read is done out of pro= cess */ if (!(absolute_file =3D g_canonicalize_filename(file, NULL))) { @@ -1350,8 +1340,6 @@ virDomainSaveImageDefineXML(virConnectPtr conn, const= char *file, ret =3D conn->driver->domainSaveImageDefineXML(conn, absolute_file, dxml, flags); =20 - VIR_FREE(absolute_file); - if (ret < 0) goto error; return ret; @@ -1415,7 +1403,7 @@ virDomainCoreDump(virDomainPtr domain, const char *to= , unsigned int flags) =20 if (conn->driver->domainCoreDump) { int ret; - char *absolute_to; + g_autofree char *absolute_to; =20 /* We must absolutize the file path as the save is done out of pro= cess */ if (!(absolute_to =3D g_canonicalize_filename(to, NULL))) { @@ -1426,8 +1414,6 @@ virDomainCoreDump(virDomainPtr domain, const char *to= , unsigned int flags) =20 ret =3D conn->driver->domainCoreDump(domain, absolute_to, flags); =20 - VIR_FREE(absolute_to); - if (ret < 0) goto error; return ret; @@ -1501,7 +1487,7 @@ virDomainCoreDumpWithFormat(virDomainPtr domain, cons= t char *to, =20 if (conn->driver->domainCoreDumpWithFormat) { int ret; - char *absolute_to; + g_autofree char *absolute_to; =20 /* We must absolutize the file path as the save is done out of pro= cess */ if (!(absolute_to =3D g_canonicalize_filename(to, NULL))) { @@ -1513,8 +1499,6 @@ virDomainCoreDumpWithFormat(virDomainPtr domain, cons= t char *to, ret =3D conn->driver->domainCoreDumpWithFormat(domain, absolute_to, dumpformat, flags); =20 - VIR_FREE(absolute_to); - if (ret < 0) goto error; return ret; --=20 2.34.1 _______________________________________________ Devel mailing list -- devel@lists.libvirt.org To unsubscribe send an email to devel-leave@lists.libvirt.org