From nobody Sat Feb 7 07:11:16 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) client-ip=170.10.129.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1638282817; cv=none; d=zohomail.com; s=zohoarc; b=WRpHDKLUS6yop4RIUFgWdfLI8uUIED4uNyp9khfhuC/WMDpJs0pXAVIyfMcKiWicJcAUHoCf35xGHXQgr4GuBvB+EC5ZoD+XYV0pEDyaV9aCzVn1V+usqqqFEF3/0YIGw5Nna/1+V1MyIXqsG0Ww1TCatV+CeoAwoOFJip1uNjc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1638282817; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=fqhbr64cfr4K5Ftubu1Eg7XexqoB05qS5w/0rq/bU4k=; b=c9CxdPu3+UlMvL8j0ExcruychXXG8Pb4WMftPw445styKIn52szwPmhtYmYuNwb0BN4kokQ5bt0X+aTvLKJV/azQsiG6JVh64Bps3O71xKOMewU78ceDGtqP0ArF2Qt1j98RUSvTKuwh1fuHHzjGgC8p3itSRbBLudHRnqoRdmo= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.zohomail.com with SMTPS id 1638282817966428.9188277862813; Tue, 30 Nov 2021 06:33:37 -0800 (PST) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-463-ub8KrznbOlCuOG577nq2Pg-1; Tue, 30 Nov 2021 09:33:34 -0500 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id D4E68180FD79; Tue, 30 Nov 2021 14:33:22 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id A6F1B60CA1; Tue, 30 Nov 2021 14:33:22 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 68B1F4A705; Tue, 30 Nov 2021 14:33:22 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 1AUEXIwL022872 for ; Tue, 30 Nov 2021 09:33:18 -0500 Received: by smtp.corp.redhat.com (Postfix) id AA32D610F6; Tue, 30 Nov 2021 14:33:18 +0000 (UTC) Received: from speedmetal.lan (unknown [10.40.208.10]) by smtp.corp.redhat.com (Postfix) with ESMTP id 0A21660C0F for ; Tue, 30 Nov 2021 14:33:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1638282816; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=fqhbr64cfr4K5Ftubu1Eg7XexqoB05qS5w/0rq/bU4k=; b=dm1p85GloiVK2xFHRrxJPEzk/3RC4lYYHTfcxsRJGTBUVBANAp9lJM+JXVcqqaZ9te8Ubi q0V6HxyqN0UQ/NdwVOxXbcyTg6MdN2VHmmp8SMuTgkPMawW7oL+R4AVF8F/bFj0BEicTT8 mI46F5JXOEps1bOaNWAngm6kRqcsyx8= X-MC-Unique: ub8KrznbOlCuOG577nq2Pg-1 From: Peter Krempa To: libvir-list@redhat.com Subject: [PATCH 17/23] nwfilterxml2firewalltest: testCompareXMLToArgvFiles: Automatically free GHashTable Date: Tue, 30 Nov 2021 15:32:01 +0100 Message-Id: <9fec20fa9aa178e4259f61680f021e437d77a916.1638282671.git.pkrempa@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1638282818715100003 Content-Type: text/plain; charset="utf-8" Signed-off-by: Peter Krempa Reviewed-by: J=C3=A1n Tomko --- tests/nwfilterxml2firewalltest.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/tests/nwfilterxml2firewalltest.c b/tests/nwfilterxml2firewallt= est.c index 6ab62f60c9..315afddca0 100644 --- a/tests/nwfilterxml2firewalltest.c +++ b/tests/nwfilterxml2firewalltest.c @@ -350,7 +350,7 @@ static int testCompareXMLToArgvFiles(const char *xml, { g_autofree char *actualargv =3D NULL; g_auto(virBuffer) buf =3D VIR_BUFFER_INITIALIZER; - GHashTable *vars =3D virHashNew(virNWFilterVarValueHashFree); + g_autoptr(GHashTable) vars =3D virHashNew(virNWFilterVarValueHashFree); virNWFilterInst inst; int ret =3D -1; g_autoptr(virCommandDryRunToken) dryRunToken =3D virCommandDryRunToken= New(); @@ -381,7 +381,6 @@ static int testCompareXMLToArgvFiles(const char *xml, cleanup: virNWFilterInstReset(&inst); - virHashFree(vars); return ret; } --=20 2.31.1