From nobody Mon Feb 9 16:45:12 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) client-ip=63.128.21.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1617285290; cv=none; d=zohomail.com; s=zohoarc; b=nZwu0VTJFeMmL2kC3um920/yLTpd03Y4m8a9LPxpzAALajQhLZYkebiu/8qQFXrfmf77iUTA3Dt332LXUGiCLwzAZFJMZNDM/RWl/OlVtMh/TJO9vfqqyrR7PJE6ilswjATleYDZxnTBRuHdBcPJG9p3cPke7qnY4w2bojXDGT4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1617285290; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=2llKg1z1UNs1nX1LC+uGH+wJB5vr/4i5KNVhyIhlIVY=; b=oAfmkS0pLVPp4m86nyOpYz8t9rJXDO0skYr2mgFVjJyI1M24BZDsgCuMbsYi/T/39TdsFej0jO/QwiKH7DYX/Z/zuyT81C0yXnCwXrXAhS3vn4OjxAAOrxm1/KcBYLGTZwFILFR36aN4C8RwguGyFavCsKKqd2P2RyWc+/A3C4w= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by mx.zohomail.com with SMTPS id 1617285290878312.6096666220801; Thu, 1 Apr 2021 06:54:50 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-474-QdnctE-6OpK4JeuWUmPrJw-1; Thu, 01 Apr 2021 09:54:47 -0400 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 3CB4CDF8A0; Thu, 1 Apr 2021 13:54:10 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 08C855D6B1; Thu, 1 Apr 2021 13:54:10 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 9EF7E1802139; Thu, 1 Apr 2021 13:54:09 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 131Ds17S023324 for ; Thu, 1 Apr 2021 09:54:01 -0400 Received: by smtp.corp.redhat.com (Postfix) id D1AFC79C6E; Thu, 1 Apr 2021 13:54:01 +0000 (UTC) Received: from speedmetal.redhat.com (unknown [10.40.208.33]) by smtp.corp.redhat.com (Postfix) with ESMTP id 2BA9C79C76 for ; Thu, 1 Apr 2021 13:53:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1617285289; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=2llKg1z1UNs1nX1LC+uGH+wJB5vr/4i5KNVhyIhlIVY=; b=LzHgYdPYV4uc2yHiyejCJ1rpqfKh2WM6kiBdk/i7Oaey78vMB2z6sV/9gvSKPQtCJceorN b0lixRjYFkL59Zxxuv9Xdo8XzInW6ZCmKArNid5leW7xLMQzbBbQCSn2jL3jRrOrAuQj49 wo07A0D+Z1GoSmgrid8RKwd6ro6lHAM= X-MC-Unique: QdnctE-6OpK4JeuWUmPrJw-1 From: Peter Krempa To: libvir-list@redhat.com Subject: [PATCH 18/39] bhyveParsePCIFbuf: Use g_strsplit instead of virStringSplitCount Date: Thu, 1 Apr 2021 15:52:17 +0200 Message-Id: <9fbc344893d8a1f7e5baffcb097aeca570209369.1617285119.git.pkrempa@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" Signed-off-by: Peter Krempa --- src/bhyve/bhyve_parse_command.c | 14 +++++--------- 1 file changed, 5 insertions(+), 9 deletions(-) diff --git a/src/bhyve/bhyve_parse_command.c b/src/bhyve/bhyve_parse_comman= d.c index 70f5ac42a0..d86d37b697 100644 --- a/src/bhyve/bhyve_parse_command.c +++ b/src/bhyve/bhyve_parse_command.c @@ -558,10 +558,8 @@ bhyveParsePCIFbuf(virDomainDefPtr def, virDomainVideoDefPtr video =3D NULL; virDomainGraphicsDefPtr graphics =3D NULL; - char **params =3D NULL; - char *param =3D NULL, *separator =3D NULL; - size_t nparams =3D 0; - size_t i =3D 0; + g_auto(GStrv) **params =3D NULL; + GStrv next; if (!(video =3D virDomainVideoDefNew(xmlopt))) goto cleanup; @@ -579,11 +577,11 @@ bhyveParsePCIFbuf(virDomainDefPtr def, if (!config) goto error; - if (!(params =3D virStringSplitCount(config, ",", 0, &nparams))) + if (!(params =3D g_strsplit(config, ",", 0))) goto error; - for (i =3D 0; i < nparams; i++) { - param =3D params[i]; + for (next =3D params; *next; next++) { + char *param =3D *next; if (!video->driver) video->driver =3D g_new0(virDomainVideoDriverDef, 1); @@ -649,13 +647,11 @@ bhyveParsePCIFbuf(virDomainDefPtr def, if (VIR_APPEND_ELEMENT(def->graphics, def->ngraphics, graphics) < 0) goto error; - g_strfreev(params); return 0; error: virDomainVideoDefFree(video); virDomainGraphicsDefFree(graphics); - g_strfreev(params); return -1; } --=20 2.29.2