From nobody Wed Oct 22 12:30:41 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=reject dis=none) header.from=lists.libvirt.org ARC-Seal: i=1; a=rsa-sha256; t=1759928679; cv=none; d=zohomail.com; s=zohoarc; b=ZRAtUSUQZ5YJXs0CWeR+DhubfPILZ4YFYohD7ZJszTaZqZLAt2ND0hwYhMgsHsTMmRjNyNAQDp06Po5xA4hB99FaODP7J5syz9f5haxw1dr4OapI5E/zlMwhmJXgaYxvNxabWazKarroH/AcxgC3xocPFBc4EinV5URIzuHrGj8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1759928679; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Owner:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Subject:Subject:To:To:Message-Id:Cc; bh=DRMRIc75YoyQ1hPp6Ke5Gd2mYkVWSE6hSvJXdJ7M+pQ=; b=bgLxiZru/YR4lcrXrwHfOP/lxb+V2GVDu5CM6Fm8A7cOODZK/G7SjbBWpbO2GsfhppnbiMGCfVPVU5WyXakKwpUQX6h/upwtnONv86AXRIBgc1b2vP1QNDNb9tIrIzMWcA3iDt03jWUkVzpu/+8PeZhrQ9VUdvNaRJTqTK/hWSk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 175992867936337.79127343341361; Wed, 8 Oct 2025 06:04:39 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 993) id 6D85E41AB1; Wed, 8 Oct 2025 09:04:38 -0400 (EDT) Received: from [172.19.199.17] (lists.libvirt.org [8.43.85.245]) by lists.libvirt.org (Postfix) with ESMTP id 140BC44260; Wed, 8 Oct 2025 09:03:39 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 993) id B1BC741B4B; Wed, 8 Oct 2025 08:54:19 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (3072 bits) server-digest SHA256) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 8523141B43 for ; Wed, 8 Oct 2025 08:54:14 -0400 (EDT) Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-571-nEgWi97tP3yyHyM8OjR90A-1; Wed, 08 Oct 2025 08:54:12 -0400 Received: from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id D6C70180034A for ; Wed, 8 Oct 2025 12:54:11 +0000 (UTC) Received: from localhost.localdomain (unknown [10.43.3.236]) by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 2DF5719560A2 for ; Wed, 8 Oct 2025 12:54:10 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-3.1 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_PASS autolearn=unavailable autolearn_force=no version=4.0.1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1759928054; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=DRMRIc75YoyQ1hPp6Ke5Gd2mYkVWSE6hSvJXdJ7M+pQ=; b=cccJ4uft6rZjClMGdTJsY1J6uuDVWzXbK0Hf0rL/dM1/HA/wAyViC6ggwPw9ZwzebqVqYI uySgS48qDZjL+pjD3w+7oK6/Xku/9+gAIOvvFV6890eEB0HWNb+UHh1/SaKJNAuL1f9VNg FEbnb5VG6NzGng4q39dr2VV7arcZM4c= X-MC-Unique: nEgWi97tP3yyHyM8OjR90A-1 X-Mimecast-MFC-AGG-ID: nEgWi97tP3yyHyM8OjR90A_1759928051 To: devel@lists.libvirt.org Subject: [PATCH v2 05/29] qemu_validate: Reflect dependencies of hv-synic Date: Wed, 8 Oct 2025 14:53:37 +0200 Message-ID: <9f71fd0d7903b45cb98938d7377ec446d4997c3c.1759927755.git.mprivozn@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.12 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: jUPEJpFmvYVXh2HejaNnQR8vwBddwcSkzipiVvniQSk_1759928051 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: 742VLJ3QIXVXYCKSXNXXRVKU6YE77QWZ X-Message-ID-Hash: 742VLJ3QIXVXYCKSXNXXRVKU6YE77QWZ X-MailFrom: mprivozn@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-devel.lists.libvirt.org-0; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: Michal Privoznik via Devel Reply-To: Michal Privoznik X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1759928681311154100 Content-Type: text/plain; charset="utf-8"; x-default="true" From: Michal Privoznik Per QEMU documentation (docs/system/i386/hyperv.rst): ``hv-synic`` Enables Hyper-V Synthetic interrupt controller Requires: ``hv-vpindex`` Reflect this dependency when validating domain definition. Signed-off-by: Michal Privoznik --- src/qemu/qemu_validate.c | 42 ++++++++++++++++++++++++++++++++-------- 1 file changed, 34 insertions(+), 8 deletions(-) diff --git a/src/qemu/qemu_validate.c b/src/qemu/qemu_validate.c index 8dac5c76d0..279f72f50a 100644 --- a/src/qemu/qemu_validate.c +++ b/src/qemu/qemu_validate.c @@ -88,6 +88,38 @@ qemuValidateDomainDefPSeriesFeature(const virDomainDef *= def, } =20 =20 +#define CHECK_HV_FEAT(feat, requires) \ + if (def->hyperv_features[feat] =3D=3D VIR_TRISTATE_SWITCH_ON && \ + def->hyperv_features[requires] !=3D VIR_TRISTATE_SWITCH_ON) { \ + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, \ + _("'%1$s' hyperv feature requires '%2$s' feature"),= \ + virDomainHypervTypeToString(feat), \ + virDomainHypervTypeToString(requires)); \ + return -1; \ + } + +static int +qemuValidateDomainDefHypervFeatures(const virDomainDef *def) +{ + if (def->features[VIR_DOMAIN_FEATURE_HYPERV] =3D=3D VIR_DOMAIN_HYPERV_= MODE_NONE) + return 0; + + if (!ARCH_IS_X86(def->os.arch) && !qemuDomainIsARMVirt(def)) { + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, + _("Hyperv features are not supported for architectu= re '%1$s' or machine type '%2$s'"), + virArchToString(def->os.arch), + def->os.machine); + return -1; + } + + CHECK_HV_FEAT(VIR_DOMAIN_HYPERV_SYNIC, VIR_DOMAIN_HYPERV_VPINDEX); + + return 0; +} + +#undef CHECK_HV_FEAT + + static int qemuValidateDomainDefFeatures(const virDomainDef *def, virQEMUCaps *qemuCaps) @@ -187,14 +219,8 @@ qemuValidateDomainDefFeatures(const virDomainDef *def, break; =20 case VIR_DOMAIN_FEATURE_HYPERV: - if (def->features[i] !=3D VIR_DOMAIN_HYPERV_MODE_NONE && - !ARCH_IS_X86(def->os.arch) && !qemuDomainIsARMVirt(def)) { - virReportError(VIR_ERR_CONFIG_UNSUPPORTED, - _("Hyperv features are not supported for ar= chitecture '%1$s' or machine type '%2$s'"), - virArchToString(def->os.arch), - def->os.machine); - return -1; - } + if (qemuValidateDomainDefHypervFeatures(def) < 0) + return -1; break; =20 case VIR_DOMAIN_FEATURE_PMU: --=20 2.49.1