From nobody Thu May 9 00:04:30 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) client-ip=170.10.129.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1667492675; cv=none; d=zohomail.com; s=zohoarc; b=ACi2ecj20hDCnUrRAFzqdtZF8mE9AxJg1gw/PlWnl8bEw9iEuQwJG07bF0Fp4iqYAxaxeoX6u0vXc5BOOzrgEzw/VS88/VE2CltYGbPQ5WGCEB8BJFJ20hHPZVE27oDFBM5cBZU410JYJ9iPDd5ioGjIG2iQUXcDd/YaF72eUr0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1667492675; h=Content-Type:Content-Transfer-Encoding:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=Dm6iZQsQgWHFKsbr7qr6grCcLTSpI+aFPhhc4q/l6us=; b=HJIml0clLcgztokFQnLkn8gVaKQThlT0VbgBHD1DczsHc3MvZh0NqZbWTBUjxZTHsU8v9/yHb6bgDlLD+bgklQ08E0oiPl7IVB4Vs4hreNtR3GNw8DEG9D2pMW6PF5GyuGvzwe6aY69qZmtpMqxoIQfxg6LXo0gtKjXEcwJG5wk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.zohomail.com with SMTPS id 1667492675711498.0134182693014; Thu, 3 Nov 2022 09:24:35 -0700 (PDT) Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-563-L_2v9uQANrCExBcgzP5Ouw-1; Thu, 03 Nov 2022 12:24:30 -0400 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 72CFF1C05143; Thu, 3 Nov 2022 16:24:26 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (unknown [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id 2A35C40C6EE9; Thu, 3 Nov 2022 16:24:26 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id EA75F1946597; Thu, 3 Nov 2022 16:24:25 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id DD99D1946594 for ; Thu, 3 Nov 2022 16:24:24 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id BFC78C15BAB; Thu, 3 Nov 2022 16:24:24 +0000 (UTC) Received: from virval.usersys.redhat.com (unknown [10.43.2.227]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 9D453C15BA4 for ; Thu, 3 Nov 2022 16:24:24 +0000 (UTC) Received: by virval.usersys.redhat.com (Postfix, from userid 500) id A9F8524477E; Thu, 3 Nov 2022 17:24:23 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1667492673; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=Dm6iZQsQgWHFKsbr7qr6grCcLTSpI+aFPhhc4q/l6us=; b=ZWwWCFrpM/olPfY/0H7UBNcyzJHciqp9QqnfwNeg+TYtWbn9uyLlZ8qwH44xcgmA0k9thb iOOE5raV9AE76AE0TOhGuSINTbMntolv6z6F3WmlK7+q30NIbb6+MM3aR3IqAD6SLblbwc 2jDsU21I7UuZjW+Of5AjkoeJt3PiN/M= X-MC-Unique: L_2v9uQANrCExBcgzP5Ouw-1 X-Original-To: libvir-list@listman.corp.redhat.com From: Jiri Denemark To: libvir-list@redhat.com Subject: [libvirt PATCH] spec: libvirt-daemon: Add optional dependency on *-client Date: Thu, 3 Nov 2022 17:24:18 +0100 Message-Id: <9ef91dc433754274752791b97f399c4cc977c6d4.1667492658.git.jdenemar@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.8 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 3.1 on 10.11.54.2 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1667492677180100001 Content-Type: text/plain; charset="utf-8" The libvirt-daemon subpackage contains libvirt-guests.sh script (used by libvirt-guests service), which requires virsh to actually work. But since dynamic libraries were separated from libvirt-client to libvirt-libs more than 6 years ago, libvirt-daemon no longer requires virsh to be installed. So unless libvirt-client is explicitly installed (either manually or by installing the libvirt meta package), libvirt-guests will not work. Just adding libvirt-client as a dependency of libvirt-daemon would go against the original idea behind splitting libvirt-client: users may not want to install or use any client binaries on the host where the daemon runs (either they just use various language bindings or access the daemon remotely). To solve this we could possibly turn libvirt-daemon into an empty package and separate the daemons and libvirt-guests into subpackages to make sure we support both use cases, but marking libvirt-client as Recommended for libvirt-daemon does the same job in a much simpler way. https://bugzilla.redhat.com/show_bug.cgi?id=3D2136591 Signed-off-by: Jiri Denemark Reviewed-by: Martin Kletzander --- libvirt.spec.in | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/libvirt.spec.in b/libvirt.spec.in index 0bbcdb8956..450f50f5b5 100644 --- a/libvirt.spec.in +++ b/libvirt.spec.in @@ -441,6 +441,12 @@ Summary: Server side daemon and supporting files for l= ibvirt library # The client side, i.e. shared libs are in a subpackage Requires: %{name}-libs =3D %{version}-%{release} =20 +# The libvirt-guests.sh script requires virsh from libvirt-client subpacka= ge, +# but not every deployment wants to use libvirt-guests service. Using +# Recommends here will install libvirt-client by default (if available), b= ut +# RPM won't complain if the package is unavailable, masked, or removed lat= er. +Recommends: %{name}-client =3D %{version}-%{release} + # netcat is needed on the server side so that clients that have # libvirt < 6.9.0 can connect, but newer versions will prefer # virt-ssh-helper. Making this a Recommends means that it gets --=20 2.38.1