From nobody Fri Apr 26 16:44:32 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zoho.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1490986345043131.98455813849034; Fri, 31 Mar 2017 11:52:25 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 9D8263DBCE; Fri, 31 Mar 2017 18:52:22 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id BBE1217147; Fri, 31 Mar 2017 18:52:20 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 1E49418523CC; Fri, 31 Mar 2017 18:52:16 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id v2VIjNhl000874 for ; Fri, 31 Mar 2017 14:45:23 -0400 Received: by smtp.corp.redhat.com (Postfix) id B9BD7173AC; Fri, 31 Mar 2017 18:45:23 +0000 (UTC) Received: from mamuti.net (unknown [10.40.205.34]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 7F3AD17123 for ; Fri, 31 Mar 2017 18:45:21 +0000 (UTC) Received: by mamuti.net (Postfix, from userid 500) id 39A2310069B; Fri, 31 Mar 2017 20:45:19 +0200 (CEST) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 9D8263DBCE Authentication-Results: ext-mx06.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx06.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=libvir-list-bounces@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 9D8263DBCE From: Jiri Denemark To: libvir-list@redhat.com Date: Fri, 31 Mar 2017 20:44:08 +0200 Message-Id: <9e8164d2f9ee74e81aa558879f762712ec0c8ea1.1490985848.git.jdenemar@redhat.com> Mail-Followup-To: libvir-list@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-loop: libvir-list@redhat.com Subject: [libvirt] [PATCH] Document virDomainAbortJob behavior for post-copy migration X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Fri, 31 Mar 2017 18:52:23 +0000 (UTC) X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" https://bugzilla.redhat.com/show_bug.cgi?id=3D1389313 Signed-off-by: Jiri Denemark --- src/libvirt-domain.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/src/libvirt-domain.c b/src/libvirt-domain.c index 26da0e7f3..4670c54e5 100644 --- a/src/libvirt-domain.c +++ b/src/libvirt-domain.c @@ -8702,7 +8702,9 @@ virDomainGetJobStats(virDomainPtr domain, * @domain: a domain object * * Requests that the current background job be aborted at the - * soonest opportunity. + * soonest opportunity. In case the job is a migration in a post-copy mode, + * virDomainAbortJob will report an error (see virDomainMigrateStartPostCo= py + * for more details). * * Returns 0 in case of success and -1 in case of failure. */ @@ -8976,7 +8978,8 @@ virDomainMigrateGetMaxSpeed(virDomainPtr domain, * rolled back because none of the hosts has complete state. If this happe= ns, * libvirt will leave the domain paused on both hosts with * VIR_DOMAIN_PAUSED_POSTCOPY_FAILED reason. It's up to the upper layer to - * decide what to do in such case. + * decide what to do in such case. Because of this, libvirt will refuse to + * cancel post-copy migration via virDomainAbortJob. * * The following domain life cycle events are emitted during post-copy * migration: --=20 2.12.0 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list