From nobody Mon Feb 9 01:33:49 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1737736567914351.71378813333854; Fri, 24 Jan 2025 08:36:07 -0800 (PST) Received: by lists.libvirt.org (Postfix, from userid 996) id 0990B12B6; Fri, 24 Jan 2025 11:36:07 -0500 (EST) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id C7ACA128E; Fri, 24 Jan 2025 11:35:48 -0500 (EST) Received: by lists.libvirt.org (Postfix, from userid 996) id 62CB8C5D; Fri, 24 Jan 2025 11:35:46 -0500 (EST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id A351A9CC for ; Fri, 24 Jan 2025 11:35:43 -0500 (EST) Received: from mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-693-H89FzqAtNU2N00s-434RCQ-1; Fri, 24 Jan 2025 11:35:28 -0500 Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 9639318E10E6 for ; Fri, 24 Jan 2025 16:33:17 +0000 (UTC) Received: from speedmetal.lan (unknown [10.45.242.2]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id BE8521800348 for ; Fri, 24 Jan 2025 16:33:16 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1737736543; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=m8pzZ/REGZgkFiOMZpww3lDWLRFXPSv5b47l5wZmh+s=; b=RTSvfPD/On8H76i7P25LLyyC0TwVwMFKx1HOgazJtNdcYGtNgOS0CPvylNbFYhZ+SMuXL8 vBSBYPQCFlAO9mvcbSsiRbzKLmEgfuEq9crC5iR7Y7T88PLuXeN5A2tlntomEoQ0sEx4Vo jU/6iXfiaYPyT0ejgCT0TsosxFx6Qy0= X-MC-Unique: H89FzqAtNU2N00s-434RCQ-1 X-Mimecast-MFC-AGG-ID: H89FzqAtNU2N00s-434RCQ From: Peter Krempa To: devel@lists.libvirt.org Subject: [PATCH 5/5] qemuProcessHandleIOError: Log IO errors in the VM log file Date: Fri, 24 Jan 2025 17:33:06 +0100 Message-ID: <9e45d32d2043bdfc76af0b2c6c60da4863c8a1a0.1737736288.git.pkrempa@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: gGl7GAt3b71dZn0pMZsuGwVQ_qi5uigBUxOugtLw_fs_1737736528 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: 6K34YWZIEP4SUTMY42O5QO6RVGHSYTNQ X-Message-ID-Hash: 6K34YWZIEP4SUTMY42O5QO6RVGHSYTNQ X-MailFrom: pkrempa@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1737736570489019100 Content-Type: text/plain; charset="utf-8" Add a log entry to the VM log file for every time we receive an IO error event from qemu. The log entry is as follows: 2025-01-24 16:03:28.928+0000: IO error device=3D'virtio-disk0' node-name= =3D'libvirt-1-storage' reason=3D'other: Input/output error' Signed-off-by: Peter Krempa --- src/qemu/qemu_process.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c index 95d0a40f84..e813c11f7e 100644 --- a/src/qemu/qemu_process.c +++ b/src/qemu/qemu_process.c @@ -836,6 +836,7 @@ qemuProcessHandleIOError(qemuMonitor *mon G_GNUC_UNUSED, virStorageSource *errsrc =3D NULL; const char *srcPath =3D ""; const char *devAlias =3D ""; + g_autofree char *timestamp =3D NULL; virObjectLock(vm); priv =3D QEMU_DOMAIN_PRIVATE(vm); @@ -884,6 +885,11 @@ qemuProcessHandleIOError(qemuMonitor *mon G_GNUC_UNUSE= D, } virObjectUnlock(vm); + if ((timestamp =3D virTimeStringNow()) !=3D NULL) { + qemuDomainLogAppendMessage(priv->driver, vm, "%s: IO error device= =3D'%s' node-name=3D'%s' reason=3D'%s'\n", + timestamp, NULLSTR(devAlias), NULLSTR(n= odename), NULLSTR(reason)); + } + virObjectEventStateQueue(priv->driver->domainEventState, ioErrorEvent); virObjectEventStateQueue(priv->driver->domainEventState, ioErrorEvent2= ); virObjectEventStateQueue(priv->driver->domainEventState, lifecycleEven= t); --=20 2.48.1