From nobody Wed Dec 17 08:56:34 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=reject dis=none) header.from=lists.libvirt.org ARC-Seal: i=1; a=rsa-sha256; t=1744790909; cv=none; d=zohomail.com; s=zohoarc; b=gkNEwv/fT0LtxO6db35c7900wYRXTULjd2Ft59VF1Z64WyCOtHndiHQQB2Q6ZyfV1xD+lRMJYXcMTZA/95Y7qmvhKNz6GAh5liDDOb5jjZudOMKj3WMUL50ZZf9GYCGTq84nBSZixC6sumtUKNy8bbZobdlIAx4GKRrLON+w3t0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1744790909; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Subject:Subject:To:To:Message-Id:Cc; bh=uXJp/IgcnErtxDFps5iMvYTUzKITIW30XxFGrIfFfag=; b=XJ+egsIBx34vk3lQR8Nqx2s7GWFaa5x4akbyz4T0FB5cgDemQFcLf0JpYP8NbR6a+VqQUzl3NGO9Y7bAY4Bkwr8shfmXaqAupo0uuDY7LMt8zKMhyPpRlZIUwk0UdGuPGjnamQbB3pCNmrAZv+Ac1j6fLUBJTZ0h+7Vc2ZUYSTY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 174479090915683.94067427664834; Wed, 16 Apr 2025 01:08:29 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 996) id 95D47137B; Wed, 16 Apr 2025 04:08:28 -0400 (EDT) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id 0B9DB135A; Wed, 16 Apr 2025 04:07:15 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 996) id BAF0312B8; Wed, 16 Apr 2025 04:07:08 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 9933112C9 for ; Wed, 16 Apr 2025 04:07:04 -0400 (EDT) Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-222-7YZLKRY5O_CY9KKD_LT9dQ-1; Wed, 16 Apr 2025 04:07:01 -0400 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-39141ffa913so3709057f8f.2 for ; Wed, 16 Apr 2025 01:07:01 -0700 (PDT) Received: from wheatley.localdomain ([85.93.96.130]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-39eadda64ecsm16544349f8f.0.2025.04.16.01.06.59 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Apr 2025 01:06:59 -0700 (PDT) Received: from wheatley.pinto-pinecone.ts.net (wheatley.k8r.cz [127.0.0.1]) by wheatley.localdomain (Postfix) with ESMTP id 13DDA9F0669E for ; Wed, 16 Apr 2025 10:06:59 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_HELO_NONE autolearn=unavailable autolearn_force=no version=3.4.4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1744790824; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=KAMrYhD8ZOXxzunxUHBwPsEC0gW3dhAp0t89vx8Y0DU=; b=M0jojnjGHPjKTYF63ty3Q0kpUZwmimKeXgrH1kpLk0drmOAqcuAqvXIQmliEr1bpzN9ikl IohI/rWFWr31iYcETR5/kf0uU3gf7cKbtNIBHyrXMo4GSn0SuljTN6ErcbUvBaguKYoQQf RUSyH/2YSv/4sxxer70+17u8ky61T8w= X-MC-Unique: 7YZLKRY5O_CY9KKD_LT9dQ-1 X-Mimecast-MFC-AGG-ID: 7YZLKRY5O_CY9KKD_LT9dQ_1744790821 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744790820; x=1745395620; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=KAMrYhD8ZOXxzunxUHBwPsEC0gW3dhAp0t89vx8Y0DU=; b=XwXo6obQ6B19k87vvL52mrybRib6+r0P9ZbAaKyGsAfnlMHYhn7UwNE6jcudUgGhty cmcSRX56hDcXk8elJkcWhpzRqfX2zMGQa0nACnfXyYi/wuAXFjA298GVN/Clf5M8qYPI 9OTl4qY6f41jDiUyUmIzX/FeKEP4/umjrjHf4DkM8srPpC55EVGQs187zLiXXshJPxkq MRbIVaKd3bdBum+8MxtKQPryrSZXgq+aI/OLSH6JMdYoWLOPYch5g/62O1DZwNJn1+4R bV3g1in2o5FOZNSYyfT+xwHzyDGGIJ3ivXfjzzYlDstlL47WeEtB3hGFCv1Bw/J5Ai84 G0Og== X-Gm-Message-State: AOJu0Yy3001Sr8p+PNqnEDVydrjvlNmtNFFwZeNntxPGJ0rRX+dU/+oX bFQU5sv1jS1mHyHqgMIKgyft+ZNwtaA1R8+QkkM/6nBMyiMOdSucutBpXGjinIo4Fqf8ECnT7L7 2z+NN/YHH98IRZANYO8/DAvYhAq0ITf/vwpTFJBUmSXb1i8s59ryzLjiy5NlC1GNDDZvWrZFvXO xD1018aEDf5KDonEdsNOnnM/jSfq6FAPtdOg2tRsc= X-Gm-Gg: ASbGncswGLEFIqt4wpyXP2l1KnXqhx6qcwuTCF9mhL0ot9Ciwu9gzTaBOEDK5SN8d/I g6NEdQXSKahwIXmhJ2A47GOoncv6Gz7Y8CfrEL/6+1M3j3SmcHrTeKISHq0PXoGhz0067BaY2b0 10KKP0FQfltdk1AEI3lHUtGb+HyW9omxZkZp7A/Btk12vC/wfYO5X3c5YueUzjMPPESrlGQP9eV lHEVfBG8CatsHUGP/C9Yjtyq+WBsCbsBsv1z/+yeLWxwAdCwOekrwnWM1kMLXEkag1TmBKgtY/C snTGcxyseKmxV6RhyKAY X-Received: by 2002:a5d:6dac:0:b0:39c:268e:ae04 with SMTP id ffacd0b85a97d-39ee5add7admr755027f8f.0.1744790820652; Wed, 16 Apr 2025 01:07:00 -0700 (PDT) X-Google-Smtp-Source: AGHT+IF25N/Mc2Fqp3ij5mt5HvwMuBdJ5GjuvY25flEjNPXad8U/PFw65lrwfmXIKKJzzrVc6f7DRQ== X-Received: by 2002:a5d:6dac:0:b0:39c:268e:ae04 with SMTP id ffacd0b85a97d-39ee5add7admr754970f8f.0.1744790819938; Wed, 16 Apr 2025 01:06:59 -0700 (PDT) To: devel@lists.libvirt.org Subject: [PATCH 1/3] nwfilter: Fix erroneous pointer passing to g_clear_pointer Date: Wed, 16 Apr 2025 10:06:53 +0200 Message-ID: <9e3c58f1cc12127a662a04965b9e5613919a838f.1744790743.git.mkletzan@redhat.com> X-Mailer: git-send-email 2.49.0 In-Reply-To: References: MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 2SiO9I2rCIbpZHd4dwI_M5oNo9V6SCa84o1QbTu06oE_1744790821 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: OVFC6XGYUNPR4LH7YUHFJ6RRG3YP4YD3 X-Message-ID-Hash: OVFC6XGYUNPR4LH7YUHFJ6RRG3YP4YD3 X-MailFrom: mkletzan@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: From: Martin Kletzander via Devel Reply-To: Martin Kletzander X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1744790911507019000 Content-Type: text/plain; charset="utf-8"; x-default="true" From: Martin Kletzander Commit 5de27c32a18f wanted to fix a possible double free, but by mistake did not pass a reference to the variable. This made virtnwfilterd coredump in our daily CI build. Signed-off-by: Martin Kletzander --- src/nwfilter/nwfilter_gentech_driver.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/nwfilter/nwfilter_gentech_driver.c b/src/nwfilter/nwfilter= _gentech_driver.c index 0c12b54b8029..1465734a54f8 100644 --- a/src/nwfilter/nwfilter_gentech_driver.c +++ b/src/nwfilter/nwfilter_gentech_driver.c @@ -203,12 +203,12 @@ virNWFilterInstReset(virNWFilterInst *inst) =20 for (i =3D 0; i < inst->nfilters; i++) virNWFilterObjUnlock(inst->filters[i]); - g_clear_pointer(inst->filters, g_free); + g_clear_pointer(&inst->filters, g_free); inst->nfilters =3D 0; =20 for (i =3D 0; i < inst->nrules; i++) virNWFilterRuleInstFree(inst->rules[i]); - g_clear_pointer(inst->rules, g_free); + g_clear_pointer(&inst->rules, g_free); inst->nrules =3D 0; } =20 --=20 2.49.0