From nobody Sun Feb 8 23:26:53 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) client-ip=216.205.24.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1617980660; cv=none; d=zohomail.com; s=zohoarc; b=VHGbusDcekBtzvyDD01QISWRYY4Q3NeYV0wwg72Stgj1+niYOm75cG/wSrREJAXQWpiBYSZgH/gvuLfOBHrFJfWKentNnYlMMxy0m2n2cDuHto325LDc4O8uS1G4r94Qr1afF2CbtxJch8uIMvvkhN1z9kij0pcXeWjiTtPwIhY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1617980660; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=/aNA61IfnI1VNE5AnZFSrpTGZ+dHL+iR/zBnyVlx4Wo=; b=YycaCC8RBJ28CkyEyJiBab3T3GcNldwqP9ABKNUaXRcywLNSzKDAz8cF/Oa70sMv1TD6/5SZkyoqv5MxikKHzJs6ukNr9ocMkCdPjxYBtu23szxiI8CTQvS7VG9YgED5fvfSQqv+DsXwcJ9sJ6CuVB+LOUcE2q8DV63VqrIisIw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.zohomail.com with SMTPS id 1617980660695745.0091294114292; Fri, 9 Apr 2021 08:04:20 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-345-5DGNq_i_MqKwOZtmCLeHEA-1; Fri, 09 Apr 2021 11:01:16 -0400 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 2717B195D596; Fri, 9 Apr 2021 15:00:19 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id EE68C50F1A; Fri, 9 Apr 2021 15:00:18 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id A0AC71806D10; Fri, 9 Apr 2021 15:00:18 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 139EvpXD023863 for ; Fri, 9 Apr 2021 10:57:51 -0400 Received: by smtp.corp.redhat.com (Postfix) id ACDAF14106; Fri, 9 Apr 2021 14:57:51 +0000 (UTC) Received: from speedmetal.lan (unknown [10.40.208.33]) by smtp.corp.redhat.com (Postfix) with ESMTP id 007CB6EF41 for ; Fri, 9 Apr 2021 14:57:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1617980488; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=/aNA61IfnI1VNE5AnZFSrpTGZ+dHL+iR/zBnyVlx4Wo=; b=Y4FSf7nHQk6SDsVH8YYXvqJmtxfXDvj1Xu1EDlaaSqC3hKEuzwz/1CPsgn/dTWgRl30tpG NAk5LqQFKvW/Jo5Nv5hEDImm0ex0LbbAN3CLurgv3WhxD68TpN+FOipwdWfYtzFdqH5D/a ACcnC2yka15ks1BHE4zd+S5SQV/v50M= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1617980660; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=/aNA61IfnI1VNE5AnZFSrpTGZ+dHL+iR/zBnyVlx4Wo=; b=LdLjPA+lCprOvezSgoPt1oKTWnkqF+4IQpVczl99AkeHZZqhkjFrog21fh1yGLsmTkJzVv Lgw0KxEzbqwzFMMCXyMb2/UOpJeEbmhm3FXR1JEWD4Bflge7xgjcMr37q7bFkNK3zCAQY+ g26FiNcTUoUWetxEqjZ2mzk0cB5yp/4= X-MC-Unique: 5DGNq_i_MqKwOZtmCLeHEA-1 From: Peter Krempa To: libvir-list@redhat.com Subject: [RFC PATCH 20/43] qemu: capabilities: Move setting of QEMU_CAPS_CPU_AARCH64_OFF to virQEMUCapsInitQMPBasicArch Date: Fri, 9 Apr 2021 16:56:56 +0200 Message-Id: <9dff2728decf44fcfcdf8cab965a8d1922738d66.1617979432.git.pkrempa@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) (identity @redhat.com) Content-Type: text/plain; charset="utf-8" It's now always set for AARCH64, move it into the function setting basic caps for the emulator. Signed-off-by: Peter Krempa --- src/qemu/qemu_capabilities.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c index 6ac9f8bcf7..535f2d7e55 100644 --- a/src/qemu/qemu_capabilities.c +++ b/src/qemu/qemu_capabilities.c @@ -5059,6 +5059,9 @@ virQEMUCapsInitQMPBasicArch(virQEMUCapsPtr qemuCaps) case VIR_ARCH_AARCH64: /* ACPI only works on x86 and aarch64 */ virQEMUCapsSet(qemuCaps, QEMU_CAPS_NO_ACPI); + + /* -cpu ...,aarch64=3Doff is not detectable via qmp at this point = */ + virQEMUCapsSet(qemuCaps, QEMU_CAPS_CPU_AARCH64_OFF); break; case VIR_ARCH_PPC64: @@ -5122,11 +5125,6 @@ virQEMUCapsInitQMPVersionCaps(virQEMUCapsPtr qemuCap= s) virQEMUCapsSet(qemuCaps, QEMU_CAPS_EGL_HEADLESS); virQEMUCapsSet(qemuCaps, QEMU_CAPS_NUMA_DIST); - /* -cpu ...,aarch64=3Doff supported in v2.3.0 and onwards. But it - isn't detectable via qmp at this point */ - if (qemuCaps->arch =3D=3D VIR_ARCH_AARCH64) - virQEMUCapsSet(qemuCaps, QEMU_CAPS_CPU_AARCH64_OFF); - if (ARCH_IS_PPC64(qemuCaps->arch)) { /* HPT resizing is supported since QEMU 2.10 on ppc64; unfortunate= ly * there's no sane way to probe for it */ --=20 2.30.2