From nobody Sun Feb 8 17:03:50 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) client-ip=170.10.129.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1695114938; cv=none; d=zohomail.com; s=zohoarc; b=QE0wUuMLkryjZ0V2KFQcWuJwHSsVbBoKd/dVFnyC92Jb5S6lJgpHNBNCHOtjoX1RKFbXXu99d8ScLCHCITJ9NGYrVi1+o2JhIcd6K96IWehsP7J7aIHTVFzPUJ2fDUDV8zqm5xba1p9XOFJNSDt1Y8X4uD3mLZCt7MPONEk01UE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1695114938; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=JWifkhz7pu8R5u05ahaNywkWGicKTTrTHMXA1NFupKU=; b=JRCuMcwZib2qFNH9/NoTlu3Ctmjs1tpBnn+hjT0sLpUl7A/5q+O/S7+BqM6Lg/0civo2J4K+fzLKpqcaA1dj6kGr/+pTMPq3TlFBhtlWxioN6jhSc6fmg9GHATA5jTWxDFERMGhZ5SRvcLAyFuq4Sbo5vKyS57FBFsXiye1qaKw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.zohomail.com with SMTPS id 1695114938255355.5690228405373; Tue, 19 Sep 2023 02:15:38 -0700 (PDT) Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-635-oE1MdbxANVKV-IrQ1XcLCw-1; Tue, 19 Sep 2023 05:15:35 -0400 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 43BF9101A590; Tue, 19 Sep 2023 09:15:33 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id 2DC68C154CA; Tue, 19 Sep 2023 09:15:33 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id D74DC19465BA; Tue, 19 Sep 2023 09:15:19 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 05270194658C for ; Tue, 19 Sep 2023 09:15:15 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id DC995215670B; Tue, 19 Sep 2023 09:15:09 +0000 (UTC) Received: from orca.brq.redhat.com (unknown [10.43.2.70]) by smtp.corp.redhat.com (Postfix) with ESMTP id 405A02156701; Tue, 19 Sep 2023 09:15:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1695114937; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=JWifkhz7pu8R5u05ahaNywkWGicKTTrTHMXA1NFupKU=; b=QkK2k8r0mV7MR5Lx/OrdXZE9YseQD5sZ/44Xgpj/rcwPJ1o5PC9GqgnJxDGmom4BiCMzmX oC6O09jr2MOa0OaqkRMaWjlkWBQW0f4yezPimxVGAwyb6yHBUWldPEIBqGiMaoUD6p8gD7 Pu7R6vRDbfshsWXagIrPvanauGfGDHw= X-MC-Unique: oE1MdbxANVKV-IrQ1XcLCw-1 X-Original-To: libvir-list@listman.corp.redhat.com From: Erik Skultety To: libvir-list@redhat.com Subject: [libvirt PATCH v3 01/12] syntax-check: Drop the shell's 'check for minus' rule Date: Tue, 19 Sep 2023 11:14:56 +0200 Message-ID: <9df8f0648fbbf2e63d9d930e6291bde5e218f009.1695114836.git.eskultet@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.6 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Erik Skultety Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 3.1 on 10.11.54.8 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1695114938574100005 Apparently we've only had it because the -[ao] options weren't portable at the time, but according to https://pubs.opengroup.org/onlinepubs/9699919799/utilities/test.html both are defined in POSIX.1-2017 revision which is old enough for all our supported platforms to have adopted it already, so we can drop the check. However, the above has also marked -[ao] as obsolescent stating that: "[OB] Obsolescent The functionality described may be removed in a future version of this volume of POSIX.1-2017. Strictly Conforming POSIX Applications and Strictly Conforming XSI Applications shall not use obsolescent features." It is however unlikely that the shell implementations would drop support for -[ao] despite POSIX potentially removing them. Signed-off-by: Erik Skultety Reviewed-by: Daniel P. Berrang=C3=A9 --- build-aux/syntax-check.mk | 9 --------- 1 file changed, 9 deletions(-) diff --git a/build-aux/syntax-check.mk b/build-aux/syntax-check.mk index d7cf109fbd..5718768193 100644 --- a/build-aux/syntax-check.mk +++ b/build-aux/syntax-check.mk @@ -1201,15 +1201,6 @@ sc_prohibit_double_semicolon: halt=3D"Double semicolon detected" \ $(_sc_search_regexp) =20 -_ptm1 =3D use "test C1 && test C2", not "test C1 -''a C2" -_ptm2 =3D use "test C1 || test C2", not "test C1 -''o C2" -# Using test's -a and -o operators is not portable. -# We prefer test over [, since the latter is spelled [[ in configure.ac. -sc_prohibit_test_minus_ao: - @prohibit=3D'(\