From nobody Wed Sep 23 08:40:19 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 38.145.34.151 as permitted sender) client-ip=38.145.34.151; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 38.145.34.151 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=reject dis=none) header.from=lists.libvirt.org ARC-Seal: i=1; a=rsa-sha256; t=1784647240; cv=none; d=zohomail.com; s=zohoarc; b=RCXjc1aEhEvMpztWKumV1QGEyoPzF5X9lLnAUCysN/Coytg1JysaViFeQTp2sRV8mmdgA8wbai1QWGHqEfnGXzaKNQatoKF8takNMTY3rZiaCguwwAbOkelSmwKNr9o2yYhqCW5dzpFI0O8Rn2/YspusNLQMIsU6Mm+bWkKWitM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1784647240; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Owner:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Subject:Subject:To:To:Message-Id:Cc; bh=TCVij+noKhcpmJzQkTyn1/OCwaEwhFaA0BE/MHvBArQ=; b=D9LY8+kKi9kHf+dDekY5XqjeovLDtBCUcOjMJ3dQ1q8e/+7fDxH+5eicXmnt50OWHCYfjo0MAiXpB0m9z55CkKFDHHDw8iDvnYci77/7bGswTmx8vEO5+uwYUKTqIBvIsb5e3g3+9/J95tjFQuNjFWPYeZLnf/XYXjlI7IyA19I= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 38.145.34.151 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [38.145.34.151]) by mx.zohomail.com with SMTPS id 17846472404771018.3469648610879; Tue, 21 Jul 2026 08:20:40 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 993) id C044241BC0; Tue, 21 Jul 2026 11:20:37 -0400 (EDT) Received: from [172.19.199.10] (unknown [10.16.107.18]) by lists.libvirt.org (Postfix) with ESMTP id 5018441BCF; Tue, 21 Jul 2026 11:17:54 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 993) id DA4E641908; Tue, 21 Jul 2026 11:17:34 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (3072 bits) server-digest SHA256) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 0DA8F4190D for ; Tue, 21 Jul 2026 11:17:32 -0400 (EDT) Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-656-5pI3NSIGNDCYLEjWqEHisQ-1; Tue, 21 Jul 2026 11:17:30 -0400 Received: from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id DC4F11955DC2 for ; Tue, 21 Jul 2026 15:17:29 +0000 (UTC) Received: from speedmetal.lan (unknown [10.44.24.17]) by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 3425B1955E7E for ; Tue, 21 Jul 2026 15:17:28 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=0.6 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,RCVD_IN_SBL_CSS,SPF_HELO_PASS autolearn=no autolearn_force=no version=4.0.1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1784647052; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=TCVij+noKhcpmJzQkTyn1/OCwaEwhFaA0BE/MHvBArQ=; b=P7kbAo9pol/QkIWlsCMR7XowA9N3y2I2GWMKX1ZhyGsFdA9zihcZJpYjIA69wbJJLMa5h8 YPiEatTP5Eyrk+Sdyul1w0RdMWv8Gtj3nxZM/MlI3cEjF0mSbrZTG4PjHMSMJTfV3PInpm 4yRKgyOBTJM0f8XCcvgXPlY0eQS4iNI= X-MC-Unique: 5pI3NSIGNDCYLEjWqEHisQ-1 X-Mimecast-MFC-AGG-ID: 5pI3NSIGNDCYLEjWqEHisQ_1784647050 To: devel@lists.libvirt.org Subject: [PATCH 4/4] libvirt-qemu: Add reference to QEMU agent protocol syntax Date: Tue, 21 Jul 2026 17:17:22 +0200 Message-ID: <9c6fe2bf8ea1b0c5b682856d3ef4ec880bf7e8a3.1784647021.git.pkrempa@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.12 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 3w5ELN3zLeBWH32EhfS4eAc6At3w2q54C3x9n69p3y8_1784647050 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: YKXOO5GPKH7QCIFISR3DTFKPAYTNACZ4 X-Message-ID-Hash: YKXOO5GPKH7QCIFISR3DTFKPAYTNACZ4 X-MailFrom: pkrempa@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-devel.lists.libvirt.org-0; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: Peter Krempa via Devel Reply-To: Peter Krempa X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1784647242483158501 Content-Type: text/plain; charset="utf-8" From: Peter Krempa Add a reference to the expected format of commands used with 'virDomainQemuAgentCommand'. Closes: https://gitlab.com/libvirt/libvirt/-/work_items/891 Signed-off-by: Peter Krempa --- src/libvirt-qemu.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/src/libvirt-qemu.c b/src/libvirt-qemu.c index c4cbc49ef7..3df33609e9 100644 --- a/src/libvirt-qemu.c +++ b/src/libvirt-qemu.c @@ -278,6 +278,11 @@ virDomainQemuAttach(virConnectPtr conn, * Execute an arbitrary Guest Agent command. * * Issue @cmd to the guest agent running in @domain. + * + * The QEMU guest agent expects the command @cmd to be in the QEMU Guest A= gent + * Protocol format documented at: + * https://www.qemu.org/docs/master/interop/qemu-ga-ref.html + * * @timeout must be -2, -1, 0 or positive. * VIR_DOMAIN_QEMU_AGENT_COMMAND_BLOCK(-2): meaning to block forever waiti= ng for * a result. @@ -285,7 +290,8 @@ virDomainQemuAttach(virConnectPtr conn, * VIR_DOMAIN_QEMU_AGENT_COMMAND_NOWAIT(0): does not wait. * positive value: wait for @timeout seconds * - * Returns strings if success, NULL in failure. + * Returns string containing the verbatim reply from the guest agent on + * success, NULL on failure. * * Since: 0.10.0 */ --=20 2.55.0