From nobody Sun Feb 8 13:39:08 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) client-ip=216.205.24.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1609862137; cv=none; d=zohomail.com; s=zohoarc; b=heMaSwjkR6ITWZEGI3kKM5dPbTwjFUToTuNo8omQp7PosXlXTtPlLvHf6FYkiHMm0Tp/QKaSweaHKi1of2c3KkdhVzf2TfCkxxrq/r5BLj697PsIyo3qXBFTW26ABXOA5f2oru1mrqOnZYgPYk+LJuEAJ5rUc8MlY5aW6ML/uV0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1609862137; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=e9RPK3vkKJjChWF4wQ+ez5qgzcYQkDHWwZw4qZN4l1M=; b=FyBo+PSJCe7o+hdONgAstzTY1v4qj1WoBMwt05Z0EFBBR5R90pfc+Id2lb3B1rnabpB7nscxu/pO+SHRMUwOOi2VJUYVbjrwYWH/4OGcpS7SX1/Yf4kQAmPVYYKCM8bFc9re7+fg7jClDKrx3Yu4DCx7AxteQiHWeD33noZNHfU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.zohomail.com with SMTPS id 160986213791281.40372322781195; Tue, 5 Jan 2021 07:55:37 -0800 (PST) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-27-RgJLzZj8N-mUP8X_4wCAYg-1; Tue, 05 Jan 2021 10:55:33 -0500 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 9ED87A0CA4; Tue, 5 Jan 2021 15:55:27 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 73AC719714; Tue, 5 Jan 2021 15:55:27 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 3D1D45002F; Tue, 5 Jan 2021 15:55:27 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 105FswEt020995 for ; Tue, 5 Jan 2021 10:54:58 -0500 Received: by smtp.corp.redhat.com (Postfix) id 1960B25274; Tue, 5 Jan 2021 15:54:58 +0000 (UTC) Received: from carol.localdomain (unknown [10.40.193.241]) by smtp.corp.redhat.com (Postfix) with ESMTPS id DE04519714 for ; Tue, 5 Jan 2021 15:54:54 +0000 (UTC) Received: from carol.redhat.com (carol.k8r.cz [127.0.0.1]) by carol.localdomain (Postfix) with ESMTP id E7EC6C2020E for ; Tue, 5 Jan 2021 16:54:47 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1609862136; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=e9RPK3vkKJjChWF4wQ+ez5qgzcYQkDHWwZw4qZN4l1M=; b=KW1PAJC2KB71oSxjc2NbC3GpXMEbm1L+XX6a0IxNj+HiZg8mx0KEmcjQxS36nJYwky44oP 4CFih+Rfjg/d7WYWLnbg9GRk+E1cbpOfPoHDi+bsgs86wHJCEh4r+Df9C3kVSxfONZMmhF AK+sqFd7h09PV0wnddCltToiz3f2zIw= X-MC-Unique: RgJLzZj8N-mUP8X_4wCAYg-1 From: Martin Kletzander To: libvir-list@redhat.com Subject: [libvirt PATCH v3 6/8] tests: Test vmx files with missing images Date: Tue, 5 Jan 2021 16:54:45 +0100 Message-Id: <9bfb5921c1c20a8942a43ec41d69a333c8e5df4c.1609862070.git.mkletzan@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Clacks-Overhead: GNU Terry Pratchett X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" Signed-off-by: Martin Kletzander --- .../vmx2xml-cdrom-ide-file-missing-datastore.vmx | 6 ++++++ tests/vmx2xmldata/vmx2xml-cdrom-ide-file-missing-file.vmx | 6 ++++++ .../vmx2xml-harddisk-ide-file-missing-datastore.vmx | 6 ++++++ .../vmx2xml-harddisk-scsi-file-missing-file.vmx | 7 +++++++ tests/vmx2xmltest.c | 6 ++++++ 5 files changed, 31 insertions(+) create mode 100644 tests/vmx2xmldata/vmx2xml-cdrom-ide-file-missing-datast= ore.vmx create mode 100644 tests/vmx2xmldata/vmx2xml-cdrom-ide-file-missing-file.v= mx create mode 100644 tests/vmx2xmldata/vmx2xml-harddisk-ide-file-missing-dat= astore.vmx create mode 100644 tests/vmx2xmldata/vmx2xml-harddisk-scsi-file-missing-fi= le.vmx diff --git a/tests/vmx2xmldata/vmx2xml-cdrom-ide-file-missing-datastore.vmx= b/tests/vmx2xmldata/vmx2xml-cdrom-ide-file-missing-datastore.vmx new file mode 100644 index 000000000000..8a8de892c88a --- /dev/null +++ b/tests/vmx2xmldata/vmx2xml-cdrom-ide-file-missing-datastore.vmx @@ -0,0 +1,6 @@ +config.version =3D "8" +virtualHW.version =3D "4" +ide0:0.present =3D "true" +ide0:0.deviceType =3D "cdrom-image" +ide0:0.fileName =3D "/vmfs/volumes/missing/cdrom.iso" +displayName =3D "test" diff --git a/tests/vmx2xmldata/vmx2xml-cdrom-ide-file-missing-file.vmx b/te= sts/vmx2xmldata/vmx2xml-cdrom-ide-file-missing-file.vmx new file mode 100644 index 000000000000..6ee2fb553ae4 --- /dev/null +++ b/tests/vmx2xmldata/vmx2xml-cdrom-ide-file-missing-file.vmx @@ -0,0 +1,6 @@ +config.version =3D "8" +virtualHW.version =3D "4" +ide0:0.present =3D "true" +ide0:0.deviceType =3D "cdrom-image" +ide0:0.fileName =3D "/vmfs/volumes/ds/missing.iso" +displayName =3D "test" diff --git a/tests/vmx2xmldata/vmx2xml-harddisk-ide-file-missing-datastore.= vmx b/tests/vmx2xmldata/vmx2xml-harddisk-ide-file-missing-datastore.vmx new file mode 100644 index 000000000000..9d89ce7158a8 --- /dev/null +++ b/tests/vmx2xmldata/vmx2xml-harddisk-ide-file-missing-datastore.vmx @@ -0,0 +1,6 @@ +config.version =3D "8" +virtualHW.version =3D "4" +ide0:0.present =3D "true" +ide0:0.deviceType =3D "ata-hardDisk" +ide0:0.fileName =3D "/vmfs/volumes/missing/harddisk.vmdk" +displayName =3D "test" diff --git a/tests/vmx2xmldata/vmx2xml-harddisk-scsi-file-missing-file.vmx = b/tests/vmx2xmldata/vmx2xml-harddisk-scsi-file-missing-file.vmx new file mode 100644 index 000000000000..d39f657e437f --- /dev/null +++ b/tests/vmx2xmldata/vmx2xml-harddisk-scsi-file-missing-file.vmx @@ -0,0 +1,7 @@ +config.version =3D "8" +virtualHW.version =3D "4" +scsi0.present =3D "true" +scsi0:0.present =3D "true" +scsi0:0.deviceType =3D "scsi-hardDisk" +scsi0:0.fileName =3D "/vmfs/volumes/ds/missing.vmdk" +displayName =3D "test" diff --git a/tests/vmx2xmltest.c b/tests/vmx2xmltest.c index 3a11dfb41ce8..d622e46fd563 100644 --- a/tests/vmx2xmltest.c +++ b/tests/vmx2xmltest.c @@ -247,6 +247,12 @@ mymain(void) DO_TEST("cdrom-ide-raw-auto-detect", "cdrom-ide-raw-auto-detect"); DO_TEST("cdrom-ide-raw-auto-detect", "cdrom-ide-raw-auto-detect"); =20 + DO_TEST_FAIL("cdrom-ide-file-missing-datastore", "cdrom-ide-empty"); + DO_TEST_FAIL("cdrom-ide-file-missing-file", "cdrom-ide-empty"); + + DO_TEST_FAIL("harddisk-ide-file-missing-datastore", "harddisk-ide-file= "); + DO_TEST_FAIL("harddisk-scsi-file-missing-file", "harddisk-scsi-file"); + DO_TEST("floppy-file", "floppy-file"); DO_TEST("floppy-device", "floppy-device"); =20 --=20 2.30.0