From nobody Mon Feb 9 12:42:37 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1634293616; cv=none; d=zohomail.com; s=zohoarc; b=VBPHCAvebobRWa3ZMB5zp5Nk3k6bpjwGJx587txQMcnoByBS+ejBIuDoUNYwlreywL25l2jDMC1j7nUYVt6Xw3cBgQvbOy0Y+UuqyVwEYPlD6SzPAdRW7HaBbUVx/9l3vgETjm4dlao4svcdwVX1jKOc0LM7xdCeyne6VENKsUk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1634293616; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=A+DYd/xlZzribOCRyiZET7Wbp9sEBO938qw6lsN853g=; b=LCVEag6TWI8xf5SQTv5Fv0IZ/GDzfQggW8shCuak7nwWJ8IXgHiOtzTP3RKyY+BZ3GAKh9EkZ7LzhRQzMG3+g18ysBS67E8xRmavJgTQHGRVmkGMQCp2CGioOMiY4ANI7J8h0JCUYfuOXraTBBNzYbyu6yMuTQFWmKvgAQXtM0s= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1634293616969255.9676551926675; Fri, 15 Oct 2021 03:26:56 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-526-XZ7nvuVCNWyI2d1nC0SzbQ-1; Fri, 15 Oct 2021 06:26:52 -0400 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 98E56100CCC1; Fri, 15 Oct 2021 10:26:47 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 799095C1A3; Fri, 15 Oct 2021 10:26:47 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 459514EA2A; Fri, 15 Oct 2021 10:26:47 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 19FAQZTh005410 for ; Fri, 15 Oct 2021 06:26:35 -0400 Received: by smtp.corp.redhat.com (Postfix) id EA8255F4E2; Fri, 15 Oct 2021 10:26:35 +0000 (UTC) Received: from maggie.redhat.com (unknown [10.43.2.26]) by smtp.corp.redhat.com (Postfix) with ESMTP id 735DB5D740 for ; Fri, 15 Oct 2021 10:26:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1634293616; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=A+DYd/xlZzribOCRyiZET7Wbp9sEBO938qw6lsN853g=; b=I8uhJ3lthE+P26Vn+dbkx5sMjmZcrzMVKQyR1jLcW5MbAKViZesPLEDjgun3U2R9iliItU fxW7IjIcoesLRTJfATTQG0fqH89B0PyQgb8YTnByZHc/JPRSHYZWnQ3hsuODiMlA4k6XAJ q5XDA+IgvUGjXoFEbIZeD1Qq16zNzdQ= X-MC-Unique: XZ7nvuVCNWyI2d1nC0SzbQ-1 From: Michal Privoznik To: libvir-list@redhat.com Subject: [PATCH 4/5] qemuxml2argvtest: Drop negative virtio-*-ats tests Date: Fri, 15 Oct 2021 12:26:29 +0200 Message-Id: <9bcfa0992bc87f8c13ed372bec02b5f9303360d7.1634293543.git.mprivozn@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1634293618685100001 Content-Type: text/plain; charset="utf-8" There are some tests cases in qemuxml2argvtest that aim to check whether our validator rejects when QEMU_CAPS_VIRTIO_PCI_ATS capability is not present. Well, such scenario can't happen really because the capability will always be present. Signed-off-by: Michal Privoznik --- .../virtio-options-controller-ats.err | 1 - tests/qemuxml2argvdata/virtio-options-disk-ats.err | 1 - tests/qemuxml2argvdata/virtio-options-fs-ats.err | 1 - tests/qemuxml2argvdata/virtio-options-input-ats.err | 1 - .../virtio-options-memballoon-ats.err | 1 - tests/qemuxml2argvdata/virtio-options-net-ats.err | 1 - tests/qemuxml2argvdata/virtio-options-rng-ats.err | 1 - tests/qemuxml2argvdata/virtio-options-video-ats.err | 1 - tests/qemuxml2argvtest.c | 13 ------------- 9 files changed, 21 deletions(-) delete mode 100644 tests/qemuxml2argvdata/virtio-options-controller-ats.err delete mode 100644 tests/qemuxml2argvdata/virtio-options-disk-ats.err delete mode 100644 tests/qemuxml2argvdata/virtio-options-fs-ats.err delete mode 100644 tests/qemuxml2argvdata/virtio-options-input-ats.err delete mode 100644 tests/qemuxml2argvdata/virtio-options-memballoon-ats.err delete mode 100644 tests/qemuxml2argvdata/virtio-options-net-ats.err delete mode 100644 tests/qemuxml2argvdata/virtio-options-rng-ats.err delete mode 100644 tests/qemuxml2argvdata/virtio-options-video-ats.err diff --git a/tests/qemuxml2argvdata/virtio-options-controller-ats.err b/tes= ts/qemuxml2argvdata/virtio-options-controller-ats.err deleted file mode 100644 index f1ae0949f6..0000000000 --- a/tests/qemuxml2argvdata/virtio-options-controller-ats.err +++ /dev/null @@ -1 +0,0 @@ -unsupported configuration: the ats setting is not supported with this QEMU= binary diff --git a/tests/qemuxml2argvdata/virtio-options-disk-ats.err b/tests/qem= uxml2argvdata/virtio-options-disk-ats.err deleted file mode 100644 index f1ae0949f6..0000000000 --- a/tests/qemuxml2argvdata/virtio-options-disk-ats.err +++ /dev/null @@ -1 +0,0 @@ -unsupported configuration: the ats setting is not supported with this QEMU= binary diff --git a/tests/qemuxml2argvdata/virtio-options-fs-ats.err b/tests/qemux= ml2argvdata/virtio-options-fs-ats.err deleted file mode 100644 index f1ae0949f6..0000000000 --- a/tests/qemuxml2argvdata/virtio-options-fs-ats.err +++ /dev/null @@ -1 +0,0 @@ -unsupported configuration: the ats setting is not supported with this QEMU= binary diff --git a/tests/qemuxml2argvdata/virtio-options-input-ats.err b/tests/qe= muxml2argvdata/virtio-options-input-ats.err deleted file mode 100644 index f1ae0949f6..0000000000 --- a/tests/qemuxml2argvdata/virtio-options-input-ats.err +++ /dev/null @@ -1 +0,0 @@ -unsupported configuration: the ats setting is not supported with this QEMU= binary diff --git a/tests/qemuxml2argvdata/virtio-options-memballoon-ats.err b/tes= ts/qemuxml2argvdata/virtio-options-memballoon-ats.err deleted file mode 100644 index f1ae0949f6..0000000000 --- a/tests/qemuxml2argvdata/virtio-options-memballoon-ats.err +++ /dev/null @@ -1 +0,0 @@ -unsupported configuration: the ats setting is not supported with this QEMU= binary diff --git a/tests/qemuxml2argvdata/virtio-options-net-ats.err b/tests/qemu= xml2argvdata/virtio-options-net-ats.err deleted file mode 100644 index f1ae0949f6..0000000000 --- a/tests/qemuxml2argvdata/virtio-options-net-ats.err +++ /dev/null @@ -1 +0,0 @@ -unsupported configuration: the ats setting is not supported with this QEMU= binary diff --git a/tests/qemuxml2argvdata/virtio-options-rng-ats.err b/tests/qemu= xml2argvdata/virtio-options-rng-ats.err deleted file mode 100644 index f1ae0949f6..0000000000 --- a/tests/qemuxml2argvdata/virtio-options-rng-ats.err +++ /dev/null @@ -1 +0,0 @@ -unsupported configuration: the ats setting is not supported with this QEMU= binary diff --git a/tests/qemuxml2argvdata/virtio-options-video-ats.err b/tests/qe= muxml2argvdata/virtio-options-video-ats.err deleted file mode 100644 index f1ae0949f6..0000000000 --- a/tests/qemuxml2argvdata/virtio-options-video-ats.err +++ /dev/null @@ -1 +0,0 @@ -unsupported configuration: the ats setting is not supported with this QEMU= binary diff --git a/tests/qemuxml2argvtest.c b/tests/qemuxml2argvtest.c index 595bc6e06c..a0ee5f9943 100644 --- a/tests/qemuxml2argvtest.c +++ b/tests/qemuxml2argvtest.c @@ -3279,19 +3279,6 @@ mymain(void) DO_TEST_CAPS_LATEST("virtio-options-net-packed"); DO_TEST_CAPS_LATEST("virtio-options-rng-packed"); DO_TEST_CAPS_LATEST("virtio-options-video-packed"); - DO_TEST_PARSE_ERROR("virtio-options-controller-ats", QEMU_CAPS_VIRTIO_= SCSI); - DO_TEST_PARSE_ERROR_NOCAPS("virtio-options-disk-ats"); - DO_TEST_PARSE_ERROR_NOCAPS("virtio-options-fs-ats"); - DO_TEST_PARSE_ERROR("virtio-options-input-ats", QEMU_CAPS_VIRTIO_MOUSE, - QEMU_CAPS_VIRTIO_KEYBOARD); - DO_TEST_PARSE_ERROR_NOCAPS("virtio-options-memballoon-ats"); - DO_TEST_PARSE_ERROR_NOCAPS("virtio-options-net-ats"); - DO_TEST_PARSE_ERROR("virtio-options-rng-ats", QEMU_CAPS_DEVICE_VIRTIO_= RNG, - QEMU_CAPS_OBJECT_RNG_RANDOM); - DO_TEST_PARSE_ERROR("virtio-options-video-ats", QEMU_CAPS_DEVICE_VIRTI= O_GPU, - QEMU_CAPS_DEVICE_VIRTIO_GPU, - QEMU_CAPS_VIRTIO_GPU_VIRGL, - QEMU_CAPS_DEVICE_VHOST_USER_GPU); DO_TEST_PARSE_ERROR("virtio-options-controller-packed", QEMU_CAPS_VIRT= IO_SCSI); DO_TEST_PARSE_ERROR_NOCAPS("virtio-options-disk-packed"); DO_TEST_PARSE_ERROR_NOCAPS("virtio-options-fs-packed"); --=20 2.32.0