From nobody Sun May 5 18:17:41 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1630404202; cv=none; d=zohomail.com; s=zohoarc; b=LO8cpCb47GhYrWSGB3sfWKnbFkSQ2xKj28rXkEvi4jM4SD1dHvrP17hBR01Ujux0bmpUybEhu57lEQOYDZEyD76f8BRLeZSvD6Q9haVCKZGg8vUSYSTt8bdCtDVjXoAnsvPlHO5sA9otVMioduIrRn1nVRTRwqA42olLksDJSPQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1630404202; h=Content-Type:Content-Transfer-Encoding:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=Y4Lb2o0Gd/w5cVV2GgkgxopOqE/ttLxpSpAlW7WTV1A=; b=NAF+hjmD+1gn23e3sUsbqjW6zx2TNweJvOKdagSeXNmniQWGng1zpTBSTGfcqSxjARjN3BgEPR1rmQBUHXKoTc+Uj40F718BgLSjLkRZf5IE0otlTjaIFCadDJwP2rDYLzv4dhpxetChPMoy/gfFIovAQijdjEHur2ZNf8AdOOk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1630404202930191.96902369072473; Tue, 31 Aug 2021 03:03:22 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-460-fY1xOWMDMZa0vIkH2_o8MA-1; Tue, 31 Aug 2021 06:03:19 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 4EA6E1008061; Tue, 31 Aug 2021 10:03:15 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id BA4D05DEB8; Tue, 31 Aug 2021 10:03:14 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 540BC181A2A6; Tue, 31 Aug 2021 10:03:14 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 17VA3DrT017915 for ; Tue, 31 Aug 2021 06:03:13 -0400 Received: by smtp.corp.redhat.com (Postfix) id 14DC71024866; Tue, 31 Aug 2021 10:03:13 +0000 (UTC) Received: from hjs.redhat.com (unknown [10.43.2.20]) by smtp.corp.redhat.com (Postfix) with ESMTP id 939251009962 for ; Tue, 31 Aug 2021 10:03:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1630404201; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=Y4Lb2o0Gd/w5cVV2GgkgxopOqE/ttLxpSpAlW7WTV1A=; b=DqkFPQglKtiSuovpuCRL9XyI+mNnX+4YNyeVdnJpNtADvK0sCmsOuj0IEPgGuOnukwumil 92oU1cWpq+TGoP3o2EHXE3x9U99+0+75oyqQvHESxWMAjUEMuV3tQmpvWElOCODwHR+fQ2 7wJKuOvPRrLf59vRHdPnCDDPNV4u/PM= X-MC-Unique: fY1xOWMDMZa0vIkH2_o8MA-1 From: =?UTF-8?q?J=C3=A1n=20Tomko?= To: libvir-list@redhat.com Subject: [libvirt PATCH] tests: virstoragetest: remove tests without backing type Date: Tue, 31 Aug 2021 12:03:06 +0200 Message-Id: <9b8840a8fb7f7c0d8328ce95a8bc1f998f4b3920.1630404183.git.jtomko@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1630404204766100001 As of qemu commit: commit 497a30dbb065937d67f6c43af6dd78492e1d6f6d qemu-img: Require -F with -b backing image creating images with backing images requires specifying the format. Remove tests which do not pass the backing format on the command line. Signed-off-by: J=C3=A1n Tomko Reviewed-by: Daniel P. Berrang=C3=A9 --- tests/virstoragetest.c | 33 --------------------------------- 1 file changed, 33 deletions(-) diff --git a/tests/virstoragetest.c b/tests/virstoragetest.c index 1b211b60e6..b80818bc7b 100644 --- a/tests/virstoragetest.c +++ b/tests/virstoragetest.c @@ -638,30 +638,6 @@ mymain(void) }; TEST_CHAIN(abswrap, VIR_STORAGE_FILE_QCOW2, (&wrap, &qcow2, &raw), EXP= _PASS); =20 - /* Rewrite qcow2 and wrap file to omit backing file type */ - virCommandFree(cmd); - cmd =3D virCommandNewArgList(qemuimg, "rebase", "-u", "-f", "qcow2", - "-b", absraw, "qcow2", NULL); - if (virCommandRun(cmd, NULL) < 0) - ret =3D -1; - - virCommandFree(cmd); - cmd =3D virCommandNewArgList(qemuimg, "rebase", "-u", "-f", "qcow2", - "-b", absqcow2, "wrap", NULL); - if (virCommandRun(cmd, NULL) < 0) - ret =3D -1; - - /* Qcow2 file with raw as absolute backing, backing format omitted */ - testFileData wrap_as_raw =3D { - .expBackingStoreRaw =3D absqcow2, - .expCapacity =3D 1024, - .path =3D abswrap, - .type =3D VIR_STORAGE_TYPE_FILE, - .format =3D VIR_STORAGE_FILE_QCOW2, - }; - TEST_CHAIN(abswrap, VIR_STORAGE_FILE_QCOW2, - (&wrap_as_raw, &qcow2_as_raw), EXP_FAIL); - /* Rewrite qcow2 to a missing backing file, with backing type */ virCommandFree(cmd); cmd =3D virCommandNewArgList(qemuimg, "rebase", "-u", "-f", "qcow2", @@ -674,15 +650,6 @@ mymain(void) /* Qcow2 file with missing backing file but specified type */ TEST_CHAIN(absqcow2, VIR_STORAGE_FILE_QCOW2, (&qcow2), EXP_FAIL); =20 - /* Rewrite qcow2 to a missing backing file, without backing type */ - virCommandFree(cmd); - cmd =3D virCommandNewArgList(qemuimg, "rebase", "-u", "-f", "qcow2", - "-b", datadir "/bogus", "qcow2", NULL); - if (virCommandRun(cmd, NULL) < 0) - ret =3D -1; - - /* Qcow2 file with missing backing file and no specified type */ - TEST_CHAIN(absqcow2, VIR_STORAGE_FILE_QCOW2, (&qcow2), EXP_FAIL); =20 /* Rewrite qcow2 to use an nbd: protocol as backend */ virCommandFree(cmd); --=20 2.31.1