From nobody Mon Apr 29 09:59:43 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.39 as permitted sender) client-ip=209.132.183.39; envelope-from=libvir-list-bounces@redhat.com; helo=mx6-phx2.redhat.com; Authentication-Results: mx.zoho.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.39 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; Return-Path: Received: from mx6-phx2.redhat.com (mx6-phx2.redhat.com [209.132.183.39]) by mx.zohomail.com with SMTPS id 1488397714296507.91531712290896; Wed, 1 Mar 2017 11:48:34 -0800 (PST) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by mx6-phx2.redhat.com (8.14.4/8.14.4) with ESMTP id v21Jj501031357; Wed, 1 Mar 2017 14:45:05 -0500 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id v21Jj3jm031414 for ; Wed, 1 Mar 2017 14:45:03 -0500 Received: from mx1.redhat.com (ext-mx03.extmail.prod.ext.phx2.redhat.com [10.5.110.27]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id v21Jj3WP007258 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Wed, 1 Mar 2017 14:45:03 -0500 Received: from mail.univention.de (mail.univention.de [82.198.197.8]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id EB8F1811A7; Wed, 1 Mar 2017 19:45:01 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by solig.knut.univention.de (Postfix) with ESMTP id 4F39218001D2; Wed, 1 Mar 2017 20:44:59 +0100 (CET) Received: from mail.univention.de ([127.0.0.1]) by localhost (solig.knut.univention.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id O6yJfmIc8Gcs; Wed, 1 Mar 2017 20:44:56 +0100 (CET) Received: from ivar.knut.univention.de (dslb-092-076-235-049.092.076.pools.vodafone-ip.de [92.76.235.49]) by solig.knut.univention.de (Postfix) with ESMTPSA id A41F218001C3; Wed, 1 Mar 2017 20:44:56 +0100 (CET) Received: by ivar.knut.univention.de (Postfix, from userid 2260) id 593459FC44; Wed, 1 Mar 2017 20:44:54 +0100 (CET) X-Virus-Scanned: by amavisd-new-2.7.1 (20120429) (Debian) at knut.univention.de From: Philipp Hahn To: libvir-list@redhat.com Date: Wed, 1 Mar 2017 20:44:54 +0100 Message-Id: <9ada292ec8b93acee103fc98f85e253a59f9331f.1488397405.git.hahn@univention.de> In-Reply-To: <20170223123452.GD3470@wheatley> References: <20170223123452.GD3470@wheatley> Organization: Univention GmbH, Bremen, Germany X-Greylist: Sender passed SPF test, Sender IP whitelisted by DNSRBL, ACL 202 matched, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.27]); Wed, 01 Mar 2017 19:45:02 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.27]); Wed, 01 Mar 2017 19:45:02 +0000 (UTC) for IP:'82.198.197.8' DOMAIN:'mail.univention.de' HELO:'mail.univention.de' FROM:'hahn@univention.de' RCPT:'' X-RedHat-Spam-Score: 0.789 (BAYES_50, RCVD_IN_DNSWL_NONE, RP_MATCHES_RCVD) 82.198.197.8 mail.univention.de 82.198.197.8 mail.univention.de X-Scanned-By: MIMEDefang 2.68 on 10.5.11.24 X-Scanned-By: MIMEDefang 2.78 on 10.5.110.27 X-loop: libvir-list@redhat.com Cc: Martin Kletzander , Laine Stump , Osier Yang Subject: [libvirt] [PATCH v3] doc: Correct the default werror policy X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" The documentation is plain wrong about the default write_error policy, as its only implemented by QEMU (src/vz/vz_utils.c is the only other case, which simply explodes, is anything except other then VIR_DOMAIN_DISK_ERROR_POLICY_DEFAULT is used). And QEMUs default is VIR_DOMAIN_DISK_ERROR_POLICY_ENOSPACE. Signed-off-by: Philipp Hahn --- Osier Yang proposed v1 on 2011-10-24, which never got applied due to discussions of "enospace" vs. "enospc".=20 v2: Remove internal QEMU default docs/formatdomain.html.in | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in index 02ce792..dc44a55 100644 --- a/docs/formatdomain.html.in +++ b/docs/formatdomain.html.in @@ -2745,7 +2745,8 @@ how the hypervisor will behave on a disk read or write error, possible values are "stop", "report", "ignore", and "enospace".Since 0.8.0, "report" since - 0.9.7 The default setting of error_policy is "report". + 0.9.7 The default is left to the discretion of the + hypervisor.
There is also an optional rerror_policy that controls behavior for read errors only. Since @@ -2755,8 +2756,7 @@ read errors. Also note that "enospace" is not a valid policy for read errors, so if error_policy is set to "enospace" and no rerror_policy is - given, the read error policy will be left at its default, - which is "report". + given, the read error policy will be left at its default.
  • The optional io attribute controls specific --=20 2.1.4 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list