From nobody Fri Apr 26 21:55:16 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zoho.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1490774564348778.0416843735782; Wed, 29 Mar 2017 01:02:44 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 62FC4C04D2B7; Wed, 29 Mar 2017 08:02:42 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 1A8D48803E; Wed, 29 Mar 2017 08:02:42 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id ED09F18523C6; Wed, 29 Mar 2017 08:02:39 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id v2T82chG006063 for ; Wed, 29 Mar 2017 04:02:38 -0400 Received: by smtp.corp.redhat.com (Postfix) id C5819A568F; Wed, 29 Mar 2017 08:02:38 +0000 (UTC) Received: from moe.brq.redhat.com (dhcp129-131.brq.redhat.com [10.34.129.131]) by smtp.corp.redhat.com (Postfix) with ESMTP id 4B47496DCF for ; Wed, 29 Mar 2017 08:02:36 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 62FC4C04D2B7 Authentication-Results: ext-mx07.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx07.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=libvir-list-bounces@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 62FC4C04D2B7 From: Michal Privoznik To: libvir-list@redhat.com Date: Wed, 29 Mar 2017 10:02:34 +0200 Message-Id: <9a592e4d0bc5ea1ca2900db296ea2217304b25b7.1490774554.git.mprivozn@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-loop: libvir-list@redhat.com Subject: [libvirt] [PATCH] network: Drop unused networkRestartRadvd X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.31]); Wed, 29 Mar 2017 08:02:43 +0000 (UTC) X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" Since its introduction in 1ce4922e720 this function lived as an outcast in an #if 0 block. Signed-off-by: Michal Privoznik --- src/network/bridge_driver.c | 27 --------------------------- 1 file changed, 27 deletions(-) diff --git a/src/network/bridge_driver.c b/src/network/bridge_driver.c index 5ccd37a..ddd2a3a 100644 --- a/src/network/bridge_driver.c +++ b/src/network/bridge_driver.c @@ -1980,33 +1980,6 @@ networkRefreshRadvd(virNetworkDriverStatePtr driver, return kill(network->radvdPid, SIGHUP); } =20 -#if 0 -/* currently unused, so it causes a build error unless we #if it out */ -static int -networkRestartRadvd(virNetworkObjPtr network) -{ - char *radvdpidbase; - - /* if there is a running radvd, kill it */ - if (network->radvdPid > 0) { - /* essentially ignore errors from the following two functions, - * since there's really no better recovery to be done than to - * just push ahead (and that may be exactly what's needed). - */ - if ((networkKillDaemon(network->radvdPid, "radvd", - network->def->name) >=3D 0) && - ((radvdpidbase =3D networkRadvdPidfileBasename(network->def->n= ame)) - !=3D NULL)) { - virPidFileDelete(driver->pidDir, radvdpidbase); - VIR_FREE(radvdpidbase); - } - network->radvdPid =3D -1; - } - /* now start radvd if it should be started */ - return networkStartRadvd(network); -} -#endif /* #if 0 */ - static int networkRefreshDaemonsHelper(virNetworkObjPtr net, void *opaque) --=20 2.10.2 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list