From nobody Mon Feb 9 07:39:23 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) client-ip=216.205.24.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1606905875; cv=none; d=zohomail.com; s=zohoarc; b=AJJwJdkTxXIw/U/DBo/xaXHAFJXMN5XDnFuqrtbpdfSv9CawyjMopPFktmtDDpKzmkSDaqsN1Q19ukAZ1nXnJ/L70xzKW6gQv1oz0/nq5MX9T/MkiJq8t7sCVlmf5iWFe7KrNqSkl2NdHfikI4B9BWuPf8ywElUFtyHSvfss684= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1606905875; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=GktLiSgL3H8zTgmHXuKlMiKFnspKNMTVDVsdh+CqPqA=; b=ZaPWALWLensQ8uYtVVwV9Zfual7zAiHRtfL4xyDYCkXnSNLrrqeziFaeqrPdiadtcAnsCPAiJ9YoQaSyRv2qM4BRwb3FjYOsY33MVuxgXIyqEl0YyQgI4+V8nfj/yeFyCm1tVoUP9luJDcfpRAlAqIGFpC3D7L0kAGBKpyLptx8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.zohomail.com with SMTPS id 1606905875291633.5589463117858; Wed, 2 Dec 2020 02:44:35 -0800 (PST) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-319-u_1ID79wPTu8XA-boWaHLw-1; Wed, 02 Dec 2020 05:44:32 -0500 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id D54611005E5B; Wed, 2 Dec 2020 10:44:25 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id B17F65C1B4; Wed, 2 Dec 2020 10:44:25 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 730BA5002D; Wed, 2 Dec 2020 10:44:25 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 0B2AhHBC013774 for ; Wed, 2 Dec 2020 05:43:17 -0500 Received: by smtp.corp.redhat.com (Postfix) id 79A0F19D9F; Wed, 2 Dec 2020 10:43:17 +0000 (UTC) Received: from speedmetal.lan (unknown [10.40.208.3]) by smtp.corp.redhat.com (Postfix) with ESMTP id D28C319C48 for ; Wed, 2 Dec 2020 10:43:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1606905874; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=GktLiSgL3H8zTgmHXuKlMiKFnspKNMTVDVsdh+CqPqA=; b=SjuYCIJP2nKy/yf99ox2gKuhU+LEH4T66pkuoLNZlmk7ItDGr+AHHdcFNG5VV2lXUyjZ4y SxInkEB3lr+52E21SqMCpLGE2kQPPhVX8y6Au83lW2qh4LOMXnsDVoUAT6oYpMoF0Uq0ab I5jlsRupqEIdN12AfwN49++ce/v4GRM= X-MC-Unique: u_1ID79wPTu8XA-boWaHLw-1 From: Peter Krempa To: libvir-list@redhat.com Subject: [PATCH 1/4] libvirt_recover_xattrs: Avoid backticks for subshell Date: Wed, 2 Dec 2020 11:43:08 +0100 Message-Id: <990d074bae08cb979a0fa0956390df151059c96a.1606905624.git.pkrempa@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" Signed-off-by: Peter Krempa --- tools/libvirt_recover_xattrs.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/libvirt_recover_xattrs.sh b/tools/libvirt_recover_xattrs= .sh index 3907413c63..cb98497732 100755 --- a/tools/libvirt_recover_xattrs.sh +++ b/tools/libvirt_recover_xattrs.sh @@ -34,7 +34,7 @@ URI=3D("qemu:///system" LIBVIRT_XATTR_PREFIXES=3D("trusted.libvirt.security" "system.libvirt.security") -if [ `whoami` !=3D "root" ]; then +if [ $(whoami) !=3D "root" ]; then die "Must be run as root" fi --=20 2.28.0