From nobody Mon Feb 9 03:18:23 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=reject dis=none) header.from=lists.libvirt.org ARC-Seal: i=1; a=rsa-sha256; t=1747232761; cv=none; d=zohomail.com; s=zohoarc; b=Lp88tCq8KGlnmWJUF1b8SXb0WIOhEwLcgp4lSxiuj5zgrXaIfsQdg7t5rksFqoYzkyKHr5vmV2iEADKxL37gMB0men/AJxFVt7xz2d6zQ173XjSYId1XsdNFUq0cvYGI7wCfxg9nbt29yUBwvO9yz9C5yWD6X3yK9emQTlOJ0bU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1747232761; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Subject:Subject:To:To:Message-Id:Cc; bh=E6q+hwJ4gjat/GafJN4fCeePd6hVF9+2ZY34viJB3TY=; b=MxJwKo6BhgjFiTNwXR5+H6HN7vw6JEPGJs+F1jdWuet04/yNUVyTBNHpvZ3e38Ai+qpOBNsTzXAAMuZpeU4hrIgGJh1V1/TldU288ParJkEUWcZCiIqYwxYj0cAVctmpvD8N9del4LHabcEV3lmT0AzvSRqWP5PUmVMUFxQ7jpI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1747232761622223.93686482299097; Wed, 14 May 2025 07:26:01 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 996) id 14CFBBFB; Wed, 14 May 2025 10:26:01 -0400 (EDT) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id AB59DE72; Wed, 14 May 2025 10:24:36 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 996) id 22A00D0D; Wed, 14 May 2025 10:24:28 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 68F92CA1 for ; Wed, 14 May 2025 10:24:27 -0400 (EDT) Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-100-2DCxzhCLO52puPSlybSGPA-1; Wed, 14 May 2025 10:24:25 -0400 Received: from mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.15]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 145CC195608B for ; Wed, 14 May 2025 14:24:25 +0000 (UTC) Received: from moe.brq.redhat.com (unknown [10.43.3.236]) by mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 5417E1955F24 for ; Wed, 14 May 2025 14:24:24 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_HELO_NONE autolearn=unavailable autolearn_force=no version=3.4.4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1747232667; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=iPNFk+OJ6b4NndfVVX8fQdh2Ya2errZCGtJvclLbuTw=; b=hq4zPbal/hL+MS6TTW0vQQ4R5LON2ne40w0J6ZchatFFDxGkvVHY71Mxl6ZVFVn/eamqIU 4LtzHKYAXKSCjq5p34qSYIpVUxRyl58sEwT8Xr+Jlr7HJPM6k4CcPYkMHgJINM87ef2MNI 6Mz53ejiJ5/MxEON+co5Q35YH364DbY= X-MC-Unique: 2DCxzhCLO52puPSlybSGPA-1 X-Mimecast-MFC-AGG-ID: 2DCxzhCLO52puPSlybSGPA_1747232665 To: devel@lists.libvirt.org Subject: [PATCH 4/7] storage_backend_rbd.C: Fix return type of a volStorageBackendRBDUseFastDiff() stub Date: Wed, 14 May 2025 16:24:13 +0200 Message-ID: <96ee96e85404fde1a7bb80d4cb9e2de5914d72f6.1747232412.git.mprivozn@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.15 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: j-oSXGCz3psk_dPY6-UNjiVB_ZOGrb5LOdeAuz3GBdM_1747232665 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: 2KYKXURS6GUSGVSSGHMGU3VQVHKPN4JW X-Message-ID-Hash: 2KYKXURS6GUSGVSSGHMGU3VQVHKPN4JW X-MailFrom: mprivozn@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: From: Michal Privoznik via Devel Reply-To: Michal Privoznik X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1747232762279019000 Content-Type: text/plain; charset="utf-8"; x-default="true" From: Michal Privoznik Inside of storage_backend.c there are two implementations of volStorageBackendRBDUseFastDiff() function: one when librbd is new enough and one when it isn't. The former returns a bool, but the latter is declared to return an int despite it returning a boolean. Fix the latter. Signed-off-by: Michal Privoznik Reviewed-by: Peter Krempa --- src/storage/storage_backend_rbd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/storage/storage_backend_rbd.c b/src/storage/storage_backen= d_rbd.c index c2dbf3a307..fd46c8be55 100644 --- a/src/storage/storage_backend_rbd.c +++ b/src/storage/storage_backend_rbd.c @@ -503,7 +503,7 @@ volStorageBackendRBDGetFlags(rbd_image_t image G_GNUC_U= NUSED, return 0; } =20 -static int +static bool volStorageBackendRBDUseFastDiff(uint64_t features G_GNUC_UNUSED, uint64_t feature_flags G_GNUC_UNUSED) { --=20 2.49.0