From nobody Sun Feb 8 13:13:15 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1652882553; cv=none; d=zohomail.com; s=zohoarc; b=YGnNTCr91FUAh5D/mmE3kNPSeHp2p23kpmz5npF53IxbVy5yEpW1wIBLHqvWG+IcGVGwGpqgPmIPtYPuneOjID6jma5/08hli50irczc5U75ayjdMrkKctysoZJkJzWkSmZohUxL+lmkXGjJ+M1+iOOFWGpwhxZP00gmyP7HN24= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1652882553; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=4MUZyULRcUMbUEsZCYTVfK6ClaXKHA5gGyR05gN2F3A=; b=dTeD05GS3vuCUmKP9Fngd2A3TCQu+kygibY6WfB+U5As4NhGNuH8JhFzjbmvWIYI98/UT2MCnaOrMw6KBqJzaBT/szoqZiRsDjaADw9bUm4PhwT6bNXh0St3ESZA0bAeKpl8QbVUMB9jGE4IzeRx9yfWA1IDjN8Iw7FHGruoyCI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1652882553273673.2063818746035; Wed, 18 May 2022 07:02:33 -0700 (PDT) Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-543-d3G69AitPwOXS6WVIfLzAQ-1; Wed, 18 May 2022 10:01:28 -0400 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 5F2F03AF42A8; Wed, 18 May 2022 14:01:13 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (unknown [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id 46A9C492C14; Wed, 18 May 2022 14:01:13 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 355311947B91; Wed, 18 May 2022 14:01:13 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 1102C194975B for ; Wed, 18 May 2022 14:01:04 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id EA3D6492CA3; Wed, 18 May 2022 14:01:03 +0000 (UTC) Received: from hjs.redhat.com (unknown [10.43.2.85]) by smtp.corp.redhat.com (Postfix) with ESMTP id 91671492C3B for ; Wed, 18 May 2022 14:01:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1652882551; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=4MUZyULRcUMbUEsZCYTVfK6ClaXKHA5gGyR05gN2F3A=; b=YP1AzebuUFFLdg5OVrb2w76ciALiGmdD5JNVcUa22xOYGefmz9jytO6K6L9frjxeZ1bm15 TXXEqIIwzFNHLYRF+Op1xW5NCYuy4wXNKdgNFAxLCpZSf4quKnlJquvPN60+VP0wKx05TL +6SldHmpjNBXfIL19jREeNnuRfdsvQU= X-MC-Unique: d3G69AitPwOXS6WVIfLzAQ-1 X-Original-To: libvir-list@listman.corp.redhat.com From: =?UTF-8?q?J=C3=A1n=20Tomko?= To: libvir-list@redhat.com Subject: [libvirt PATCH 3/5] apparmor: report error when removing profile failed Date: Wed, 18 May 2022 16:00:58 +0200 Message-Id: <963b53ec19be3a54ac88e614e134aef1345f64bc.1652882416.git.jtomko@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.85 on 10.11.54.9 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 2.85 on 10.11.54.10 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1652882554600100001 Assign the return value to 'rc' before comparing it. Signed-off-by: J=C3=A1n Tomko --- src/security/virt-aa-helper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/security/virt-aa-helper.c b/src/security/virt-aa-helper.c index 1f1cce8b3d..5dc941f79a 100644 --- a/src/security/virt-aa-helper.c +++ b/src/security/virt-aa-helper.c @@ -1497,7 +1497,7 @@ main(int argc, char **argv) size =3D virFileLength(profile, -1); if (size =3D=3D 0) { vah_warning(_("Profile of 0 size detected, will at= tempt to remove it")); - if ((rc =3D parserRemove(ctl->uuid) !=3D 0)) + if ((rc =3D parserRemove(ctl->uuid)) !=3D 0) vah_error(ctl, 1, _("could not remove prof= ile")); unlink(profile); purged =3D true; --=20 2.34.1