From nobody Mon Feb 9 00:06:59 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 207.211.31.120 as permitted sender) client-ip=207.211.31.120; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-1.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zoho.com: domain of redhat.com designates 207.211.31.120 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1574079534; cv=none; d=zoho.com; s=zohoarc; b=QbsgKF0DtwcSXFf8GtJEJxxLn5S5vldTiEa0STEXrtccftRgzBCEG03FSiiIbfD9thYk7MmFFYrQVsMAMAN79gw/8I2u0OdLL2ZQqSWecPVUluL6/TQzlAJDyLEIx/Vlmf8Xj7OZUlUjlcHqlX7gg/q3q7TzY+m7sarTnVu1zo8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1574079534; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=rtY9mKq67Kq4NA3VCaUWp9arkq//ue0RaODU5Ni8wsY=; b=bo1kkaODM8iro5dbOiaeQte0jbS4YCnvXGOWSzKu1aYehOsrh7/irv/8RyOeyej4PY3T0LMlmEJjNMXH2Qq1dte9sGQUTxXT+9siNK5YpcPuk+0ahmSS0wAl7EoJewXnRZ3uOu/D2N/WlsPnPqhPdS8zBz2q+BgJIAABePaDb+A= ARC-Authentication-Results: i=1; mx.zoho.com; dkim=pass; spf=pass (zoho.com: domain of redhat.com designates 207.211.31.120 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) by mx.zohomail.com with SMTPS id 1574079534425218.56091147524637; Mon, 18 Nov 2019 04:18:54 -0800 (PST) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-69-vDAwd8xmM_aNPaTnwOm98g-1; Mon, 18 Nov 2019 07:18:50 -0500 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id AD56B800584; Mon, 18 Nov 2019 12:18:44 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 80EB95E248; Mon, 18 Nov 2019 12:18:44 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 3F5C418089CD; Mon, 18 Nov 2019 12:18:44 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id xAICIPwl015678 for ; Mon, 18 Nov 2019 07:18:25 -0500 Received: by smtp.corp.redhat.com (Postfix) id DD4A760D0B; Mon, 18 Nov 2019 12:18:25 +0000 (UTC) Received: from ridgehead.redhat.com (unknown [10.43.2.116]) by smtp.corp.redhat.com (Postfix) with ESMTP id 40142608B5; Mon, 18 Nov 2019 12:18:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1574079533; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=rtY9mKq67Kq4NA3VCaUWp9arkq//ue0RaODU5Ni8wsY=; b=gWnH2HBmZTj4q1K5SioEd4iIUdCrzBxYrmMkUvrY7CVGr8282AxxLJH0aTM4JOK73J6sE8 BsHQuj06bEO6j1JVMeEt1HZJMlVwxzXCy6VIU9faFbKIWdK4C1PHBsvxtgzz07PXacpMSr 86qKYQ+MdtpeYe5bOeO+IZOCqSpqsDk= From: Erik Skultety To: libvir-list@redhat.com Date: Mon, 18 Nov 2019 13:18:19 +0100 Message-Id: <95f1ed434065c8e562ba097b9acbd29f6543f049.1574079462.git.eskultet@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-loop: libvir-list@redhat.com Cc: Erik Skultety Subject: [libvirt] [PATCH 3/3] libvirt-domain: virConnectListDomains: Return 0 on zero-size buffer X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-MC-Unique: vDAwd8xmM_aNPaTnwOm98g-1 X-Mimecast-Spam-Score: 0 Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" It doesn't make sense to pass a target buffer into an API, declaring its size as 0 and expect some meaningful result. Since this used to work pre-Glib era, we shouldn't end with an error, but we can return 0 for the number of domains immediately, instead of calling into the daemon, which is exactly what the daemon would have returned anyway. Signed-off-by: Erik Skultety --- src/libvirt-domain.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/libvirt-domain.c b/src/libvirt-domain.c index 02622cb2ca..0def40fdf7 100644 --- a/src/libvirt-domain.c +++ b/src/libvirt-domain.c @@ -62,6 +62,9 @@ virConnectListDomains(virConnectPtr conn, int *ids, int m= axids) virCheckNonNullArgGoto(ids, error); virCheckNonNegativeArgGoto(maxids, error); =20 + if (maxids =3D=3D 0) + return 0; + if (conn->driver->connectListDomains) { int ret =3D conn->driver->connectListDomains(conn, ids, maxids); if (ret < 0) --=20 2.23.0 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list