From nobody Tue Dec 16 09:01:43 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=reject dis=none) header.from=lists.libvirt.org ARC-Seal: i=1; a=rsa-sha256; t=1743676905; cv=none; d=zohomail.com; s=zohoarc; b=GLfffBdYQZHrEe7krGkbN54XUSp3hqztWttp0KxegAV7OkWk1yzamCOtbtvjMfD/1jw3J2otjEtGjGczRpyblUUN0TpRjZuenBJlXzCpVYdF175GPc1zkuGsG7Y8v4ISQ+EK2I75AQdF3ppcGnupOKsa+Ehyp8lmGJZy+bfyj9k= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1743676905; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Subject:Subject:To:To:Message-Id:Cc; bh=jJqKXgO17kzAjctDWbeb1ryZWxrf0Jfu6u16AFyHyg8=; b=bP4aObCjLD7eMHTzae3VIb8z2yChxhROY6CfbcNNn2206PXoYxexRoL0LdHz93/p/1yV6R67Md0qPc96omXNlbBykOl88arLt+1J1MF7qbO5F+TuHlaq5p9+4ltJgzcCtOAC/gWW5IcolfchuDHVJ1+t8pMK/G4Dgp9YZDR8fd0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1743676905255547.0725325842225; Thu, 3 Apr 2025 03:41:45 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 996) id B2C2811DD; Thu, 3 Apr 2025 06:41:44 -0400 (EDT) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id E57F21471; Thu, 3 Apr 2025 06:37:17 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 996) id 29C581419; Thu, 3 Apr 2025 06:37:09 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id AAAE31622 for ; Thu, 3 Apr 2025 06:36:54 -0400 (EDT) Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-330-SFwVO8cfM1-We9fQ5C2Jpw-1; Thu, 03 Apr 2025 06:36:51 -0400 Received: from mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.15]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id C7B4C1956089 for ; Thu, 3 Apr 2025 10:36:49 +0000 (UTC) Received: from moe.brq.redhat.com (unknown [10.43.3.236]) by mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 1E0391955BC2 for ; Thu, 3 Apr 2025 10:36:48 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_HELO_NONE autolearn=unavailable autolearn_force=no version=3.4.4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1743676614; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=T85nJ7FeK+2L8sBPBp0an+KHo87jZulGOCmaPmib6S0=; b=Y1kBw0JzYkGRcGH160zKAlzWBO3OtJm4MVvw5tWPjVL8XT6HSA5BnZKmnEHAwUVqnJnjZA 66bqQOQt/BbeuWCENuL7Hi8y5XaFMU0YWz2YSqe+v3VWNRWV0q59FNd33qIXbb+XL1ClJ/ 4oivAoZFHKYhgea0emGZU47KSD0oBCM= X-MC-Unique: SFwVO8cfM1-We9fQ5C2Jpw-1 X-Mimecast-MFC-AGG-ID: SFwVO8cfM1-We9fQ5C2Jpw_1743676609 To: devel@lists.libvirt.org Subject: [PATCH 1/3] ch: Use CH_DOMAIN_PRIVATE() more Date: Thu, 3 Apr 2025 12:36:43 +0200 Message-ID: <9422d50b24a5e4b040bb6ddffe2356c258582286.1743676591.git.mprivozn@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.15 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: iNxFbNQkgiTCeXOyw5_mmmDiy1GM6Yj8i_W5ct_K43M_1743676609 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: SWJBP7K5AH3WGI4RTNYFCJ7RL6LFIE3C X-Message-ID-Hash: SWJBP7K5AH3WGI4RTNYFCJ7RL6LFIE3C X-MailFrom: mprivozn@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: From: Michal Privoznik via Devel Reply-To: Michal Privoznik X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1743676905789019000 Content-Type: text/plain; charset="utf-8"; x-default="true" From: Michal Privoznik There are two instances where vm->privateData is typecasted only so that it can be dereferenced further. Well, that's exactly what CH_DOMAIN_PRIVATE() macro is for. Use that instead. Signed-off-by: Michal Privoznik --- src/ch/ch_events.c | 2 +- src/ch/ch_process.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/ch/ch_events.c b/src/ch/ch_events.c index f1dc5c6f4c..9cb873d8cd 100644 --- a/src/ch/ch_events.c +++ b/src/ch/ch_events.c @@ -54,7 +54,7 @@ static int virCHEventStopProcess(virDomainObj *vm, virDomainShutoffReason reason) { - virCHDriver *driver =3D ((virCHDomainObjPrivate *)vm->privateData)->d= river; + virCHDriver *driver =3D CH_DOMAIN_PRIVATE(vm)->driver; =20 virObjectLock(vm); if (virDomainObjBeginJob(vm, VIR_JOB_DESTROY)) diff --git a/src/ch/ch_process.c b/src/ch/ch_process.c index e8d482da97..6a59bf756a 100644 --- a/src/ch/ch_process.c +++ b/src/ch/ch_process.c @@ -430,8 +430,8 @@ virCHProcessSetupVcpus(virDomainObj *vm) size_t i; =20 if ((vm->def->cputune.period || vm->def->cputune.quota) && - !virCgroupHasController(((virCHDomainObjPrivate *) vm->privateData= )-> - cgroup, VIR_CGROUP_CONTROLLER_CPU)) { + !virCgroupHasController(CH_DOMAIN_PRIVATE(vm)->cgroup, + VIR_CGROUP_CONTROLLER_CPU)) { virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", _("cgroup cpu is required for scheduler tuning")); return -1; --=20 2.49.0