From nobody Mon Mar 23 23:25:48 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=reject dis=none) header.from=lists.libvirt.org ARC-Seal: i=1; a=rsa-sha256; t=1773158699; cv=none; d=zohomail.com; s=zohoarc; b=L1cwwJ5XW6yKl3GRtQrjGF2f4AfXzG7k036vN/Dg52g4hpA3Xfi8GdnBe+Bxdcv3mX9AVx+4eeyyti8RYyeJhVp1C2hIm+n72Fem2khpfX2VQY060UWL0d3RCqa4ndiIn+lD4mPONdT0H88EpbIgjc1Quo6t4wbD41E4NdqlBkY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1773158699; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:List-Subscribe:List-Post:List-Owner:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:Subject:Subject:To:To:Message-Id:Cc; bh=PoXsYfAUFxjt1hoZCQ97MeCcSIMMjEKN2PmiCpPYiC4=; b=HJe5ONuEPCePk4I5xfE/+rnO/Url/e/1TPTqvU1+VUp4eN5GF+t9i9Zykstnlt1EwkOFdCzadA2yVkkLaH2FXJT/ffTm29Hw01Y5Aq2ZEQ/zE9+IoOAtxLZSd5i5R1RJypmNxyXyeSAJTKHUcso37tH53JxpKjACARkdYgjRfuE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1773158699168821.3395685865668; Tue, 10 Mar 2026 09:04:59 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 993) id 51AC3418EA; Tue, 10 Mar 2026 12:04:59 -0400 (EDT) Received: from [172.19.199.12] (lists.libvirt.org [8.43.85.245]) by lists.libvirt.org (Postfix) with ESMTP id AB9604195C; Tue, 10 Mar 2026 12:04:27 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 993) id E4D6F3F979; Tue, 10 Mar 2026 12:04:22 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (3072 bits) server-digest SHA256) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 04A833F86E for ; Tue, 10 Mar 2026 12:04:20 -0400 (EDT) Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-98-0KFcsoEpNouy2gVg-m4Hcg-1; Tue, 10 Mar 2026 12:04:19 -0400 Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 2CF671956068 for ; Tue, 10 Mar 2026 16:04:18 +0000 (UTC) Received: from speedmetal.openshiftapps.com (unknown [10.45.242.5]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 5C41318005AE for ; Tue, 10 Mar 2026 16:04:17 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HELO_MISC_IP,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_PASS autolearn=unavailable autolearn_force=no version=4.0.1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1773158660; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=PoXsYfAUFxjt1hoZCQ97MeCcSIMMjEKN2PmiCpPYiC4=; b=ObqC/cn6F37dr7p1n4UZjqj8ML9AXsTnK2+qyP1zX/Y7yyqQvoyJEp4VEGsym5wHdj0Eor levHJCtwwK3yts2E+AHR2TA0HI8WEPYltrUMZvR0hxYKH/GKWV2YmglIxSrFTDQ6svqXU5 7wgO7yn3FKL0KCC+pbgBqqGqTFpKOeI= X-MC-Unique: 0KFcsoEpNouy2gVg-m4Hcg-1 X-Mimecast-MFC-AGG-ID: 0KFcsoEpNouy2gVg-m4Hcg_1773158658 To: devel@lists.libvirt.org Subject: [PATCH] systemtap: Fix probe definition for 'rpc_tls_context_new' Date: Tue, 10 Mar 2026 17:04:15 +0100 Message-ID: <93f95785faeef3755277ca19a50919c2aa9dc819.1773158655.git.pkrempa@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: utZeJ3ihTQK-XFParV4VIliilB485BqPDApJUzJ-syw_1773158658 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: Q4PBFFL42LR354TEDF44YJV4K2DJR7G3 X-Message-ID-Hash: Q4PBFFL42LR354TEDF44YJV4K2DJR7G3 X-MailFrom: pkrempa@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-devel.lists.libvirt.org-0; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: Peter Krempa via Devel Reply-To: Peter Krempa X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1773158711847158500 Content-Type: text/plain; charset="utf-8" From: Peter Krempa Commit d249170bf609d2c modified the arguments of 'virNetTLSContextNew' which has a systemtap probe point defined. This in turn meant that the probe point needed to be modified too. Unfortunately the systemtap generator doesn't handle double pointers correctly and in fact systemtap doesn't even seem to have a possibility to fetch a list of strings from userspace natively. This meant that an invalid probe definition was generated: probe libvirt.rpc.tls_context_new =3D process("/usr/lib64/libvirt.so").ma= rk("rpc_tls_context_new") { ctxt =3D $arg1; cacert =3D user_string($arg2); cacrl =3D user_string($arg3); *cert =3D $arg4; *keys =3D $arg5; sanityCheckCert =3D $arg6; requireValidCert =3D $arg7; isServer =3D $arg8; } Leading to the following failure: # stap -ve 'probe oneshot {exit()}' parse error: expected literal string or number saw: operator '*' at /usr/share/systemtap/tapset/libvirt_probes-6= 4.stp:204:3 source: *cert =3D $arg4; ^ 1 parse error. To address the issue declare the 'cert' and 'keys' parameters as 'void *', we can't really do anything else as string lists aren't supported, which will make our generator generate correct code once again. Resolves: https://issues.redhat.com/browse/RHEL-153832 Fixes: d249170bf609d2cb89c36477b0f9ca0908f25985 Signed-off-by: Peter Krempa --- src/libvirt_probes.d | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/libvirt_probes.d b/src/libvirt_probes.d index d9e75d9797..16d1decf46 100644 --- a/src/libvirt_probes.d +++ b/src/libvirt_probes.d @@ -54,7 +54,7 @@ provider libvirt { # file: src/rpc/virnettlscontext.c # prefix: rpc probe rpc_tls_context_new(void *ctxt, const char *cacert, const char *cac= rl, - const char **cert, const char **keys, + void *cert, void *keys, int sanityCheckCert, int requireValidCert, int isServer); probe rpc_tls_context_dispose(void *ctxt); probe rpc_tls_context_session_allow(void *ctxt, void *sess, const char *d= name); --=20 2.53.0