From nobody Tue Sep 9 09:57:17 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=reject dis=none) header.from=lists.libvirt.org ARC-Seal: i=1; a=rsa-sha256; t=1747057103; cv=none; d=zohomail.com; s=zohoarc; b=i81NzhquLDcVuRaMx8Ou4yMZn9/scTgGyrRZNHrhB3yYVp1PFhYIRwffBlvqlDHYO2SUNWrzzEJd8i9pHkIkjhRMkRzTd7sKKofOWgsXeuxs6syCm7PeBf1LP6h+SIInoeL10qGFZV6eWFNiHB2Ud9YWIYfIcJuSeUyB/u2G9os= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1747057103; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Subject:Subject:To:To:Message-Id:Cc; bh=+1xEHs4m8JK1+9hPe1qmAYoHnTmmhLi3QBvvD6if6FA=; b=azhmEljB/faAEGXnHEeK/09cyEI0pwMpjT2bMHjex2VtFZPdGT7QTtiqmgG0Q4qUsl7QZR25fC46V6WQU3Pv1xUgxnmIkx9yasVJ0r04ck15AWRSDBDtz2Z1FiZryEpUJKXBzvHnXX4JMQUe7I9PeQJXi1yuRAy6S7IPW4kTiOY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1747057103781321.0181333264046; Mon, 12 May 2025 06:38:23 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 996) id A6B6F12C7; Mon, 12 May 2025 09:38:22 -0400 (EDT) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id 4DD24B90; Mon, 12 May 2025 09:37:31 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 996) id 203CFEA0; Mon, 12 May 2025 09:37:25 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 8F343B31 for ; Mon, 12 May 2025 09:37:24 -0400 (EDT) Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-119-u11uPMCCMeK8Zg1B850dDw-1; Mon, 12 May 2025 09:37:23 -0400 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 3AE6B1800988 for ; Mon, 12 May 2025 13:37:22 +0000 (UTC) Received: from moe.brq.redhat.com (unknown [10.43.3.236]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 7D39B1801390 for ; Mon, 12 May 2025 13:37:21 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_HELO_NONE autolearn=unavailable autolearn_force=no version=3.4.4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1747057044; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ifHnzjJInxDFR99DbALhpveZR8vmEeZFgo8pUoKlz8c=; b=C9O4a+4fRj/QznLBVYpVTKxE27m2ndFrIn5ABoN1b8f2jG35wlkKqfVx2TpY/5ST60UjFi +wf3/gkLWOaBTUbtwH83kV71iG4w/vKDLm2xOAcMUl5uE+Q1UtiQ5ueSgP+YICeQAhYgM6 rqcenBSMqrqJLW43kMggu1IH1DpVyFE= X-MC-Unique: u11uPMCCMeK8Zg1B850dDw-1 X-Mimecast-MFC-AGG-ID: u11uPMCCMeK8Zg1B850dDw_1747057042 To: devel@lists.libvirt.org Subject: [PATCH 2/5] virnetlink: Provide stub for virNetlinkBridgeVlanFilterSet() Date: Mon, 12 May 2025 15:37:13 +0200 Message-ID: <92f592bf54cc6ded9fcc6b88694c8684a4f9155a.1747056917.git.mprivozn@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 6YSOiuNthHEm9pv7EjnixVBj7EoHwUnBmHSu780TDVc_1747057042 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: Q6CDDXS4XJYI2KD5HNTATIDKX3MLLJWF X-Message-ID-Hash: Q6CDDXS4XJYI2KD5HNTATIDKX3MLLJWF X-MailFrom: mprivozn@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: From: Michal Privoznik via Devel Reply-To: Michal Privoznik X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1747057104264116600 Content-Type: text/plain; charset="utf-8"; x-default="true" From: Michal Privoznik In virnetlink.c there are two sections: the first one when building WITH_LIBNL support, the other that provides stubs for functions declared in the corresponding header file when building without netlink support. But the stub implementation for virNetlinkBridgeVlanFilterSet() was missing. Signed-off-by: Michal Privoznik Reviewed-by: Peter Krempa --- src/util/virnetlink.c | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/src/util/virnetlink.c b/src/util/virnetlink.c index 206646d9d7..2555457cd2 100644 --- a/src/util/virnetlink.c +++ b/src/util/virnetlink.c @@ -1344,6 +1344,17 @@ virNetlinkNewLink(const char *ifname G_GNUC_UNUSED, } =20 =20 +int +virNetlinkBridgeVlanFilterSet(const char *ifname G_GNUC_UNUSED, + int cmd G_GNUC_UNUSED, + const unsigned short fflags G_GNUC_UNUSED, + const short vid G_GNUC_UNUSED, + int *error G_GNUC_UNUSED) +{ + virReportError(VIR_ERR_INTERNAL_ERROR, "%s", _(unsupported)); + return -1; +} + int virNetlinkGetNeighbor(void **nlData G_GNUC_UNUSED, uint32_t src_pid G_GNUC_UNUSED, --=20 2.49.0