From nobody Mon Feb 9 06:26:41 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1656425910294222.03542410506554; Tue, 28 Jun 2022 07:18:30 -0700 (PDT) Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-646-HtRBK5UqN3aqH51oYP4f9A-1; Tue, 28 Jun 2022 10:18:25 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 3A5223810D42; Tue, 28 Jun 2022 14:17:39 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (unknown [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id 24B2B2026D64; Tue, 28 Jun 2022 14:17:39 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id EEBBF1947054; Tue, 28 Jun 2022 14:17:38 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id A75AC1947060 for ; Tue, 28 Jun 2022 14:17:37 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id 80BDE112131B; Tue, 28 Jun 2022 14:17:37 +0000 (UTC) Received: from maggie.redhat.com (unknown [10.43.2.39]) by smtp.corp.redhat.com (Postfix) with ESMTP id 289D21121314 for ; Tue, 28 Jun 2022 14:17:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1656425909; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=2CMVio6WI6wk2InB1wRklYsV2G7rBkMQ+BtiZJHiBKQ=; b=EdY2k0ehAsKMMJNvWPI4oXpYTDExM19KBeTRk+gsVXg1scitTIT/3Va8f/TSOV5s0H+Xw3 JujdCCLVD2sYxU+SC45uz3PVbR7QRzkeZlutzOu0DWSB17YVGiKe16QTtrNS8Ff92pbCwm hY19lo1b9tTjxPZLdLbw0QoB8Nt5GZY= X-MC-Unique: HtRBK5UqN3aqH51oYP4f9A-1 X-Original-To: libvir-list@listman.corp.redhat.com From: Michal Privoznik To: libvir-list@redhat.com Subject: [PATCH 1/4] virnetdevbandwidthtest: Drop unnecessary brackets Date: Tue, 28 Jun 2022 16:17:32 +0200 Message-Id: <92e5c1b29d7598c7382adb3adc7678c6f7dfef0c.1656425669.git.mprivozn@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.78 on 10.11.54.3 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1656425910738100006 Content-Type: text/plain; charset="utf-8"; x-default="true" Some cases that call DO_TEST_SET() macro wrap each argument in curved brackets. This is unnecessary, drop the brackets. Signed-off-by: Michal Privoznik --- tests/virnetdevbandwidthtest.c | 88 +++++++++++++++++----------------- 1 file changed, 44 insertions(+), 44 deletions(-) diff --git a/tests/virnetdevbandwidthtest.c b/tests/virnetdevbandwidthtest.c index eb4f47dfce..419793a4ae 100644 --- a/tests/virnetdevbandwidthtest.c +++ b/tests/virnetdevbandwidthtest.c @@ -117,53 +117,53 @@ mymain(void) =20 DO_TEST_SET("", NULL); =20 - DO_TEST_SET(("" - " " - ""), - (TC " qdisc del dev eth0 root\n" - TC " qdisc del dev eth0 ingress\n" - TC " qdisc add dev eth0 root handle 1: htb default 1\n" - TC " class add dev eth0 parent 1: classid 1:1 htb rate 10= 24kbps quantum 87\n" - TC " qdisc add dev eth0 parent 1:1 handle 2: sfq perturb = 10\n" - TC " filter add dev eth0 parent 1:0 protocol all prio 1 h= andle 1 fw flowid 1\n")); + DO_TEST_SET("" + " " + "", + TC " qdisc del dev eth0 root\n" + TC " qdisc del dev eth0 ingress\n" + TC " qdisc add dev eth0 root handle 1: htb default 1\n" + TC " class add dev eth0 parent 1: classid 1:1 htb rate 102= 4kbps quantum 87\n" + TC " qdisc add dev eth0 parent 1:1 handle 2: sfq perturb 1= 0\n" + TC " filter add dev eth0 parent 1:0 protocol all prio 1 ha= ndle 1 fw flowid 1\n"); =20 - DO_TEST_SET(("" - " " - ""), - (TC " qdisc del dev eth0 root\n" - TC " qdisc del dev eth0 ingress\n" - TC " qdisc add dev eth0 ingress\n" - TC " filter add dev eth0 parent ffff: protocol all u32 ma= tch u32 0 0 " - "police rate 1024kbps burst 1024kb mtu 64kb drop flowid := 1\n")); + DO_TEST_SET("" + " " + "", + TC " qdisc del dev eth0 root\n" + TC " qdisc del dev eth0 ingress\n" + TC " qdisc add dev eth0 ingress\n" + TC " filter add dev eth0 parent ffff: protocol all u32 mat= ch u32 0 0 " + "police rate 1024kbps burst 1024kb mtu 64kb drop flowid :1= \n"); =20 - DO_TEST_SET(("" - " " - " " - ""), - (TC " qdisc del dev eth0 root\n" - TC " qdisc del dev eth0 ingress\n" - TC " qdisc add dev eth0 root handle 1: htb default 1\n" - TC " class add dev eth0 parent 1: classid 1:1 htb rate 1k= bps ceil 2kbps burst 4kb quantum 1\n" - TC " qdisc add dev eth0 parent 1:1 handle 2: sfq perturb = 10\n" - TC " filter add dev eth0 parent 1:0 protocol all prio 1 h= andle 1 fw flowid 1\n" - TC " qdisc add dev eth0 ingress\n" - TC " filter add dev eth0 parent ffff: protocol all u32 ma= tch u32 0 0 " - "police rate 5kbps burst 7kb mtu 64kb drop flowid :1\n")); + DO_TEST_SET("" + " " + " " + "", + TC " qdisc del dev eth0 root\n" + TC " qdisc del dev eth0 ingress\n" + TC " qdisc add dev eth0 root handle 1: htb default 1\n" + TC " class add dev eth0 parent 1: classid 1:1 htb rate 1kb= ps ceil 2kbps burst 4kb quantum 1\n" + TC " qdisc add dev eth0 parent 1:1 handle 2: sfq perturb 1= 0\n" + TC " filter add dev eth0 parent 1:0 protocol all prio 1 ha= ndle 1 fw flowid 1\n" + TC " qdisc add dev eth0 ingress\n" + TC " filter add dev eth0 parent ffff: protocol all u32 mat= ch u32 0 0 " + "police rate 5kbps burst 7kb mtu 64kb drop flowid :1\n"); =20 - DO_TEST_SET(("" - " " - " " - ""), - (TC " qdisc del dev eth0 root\n" - TC " qdisc del dev eth0 ingress\n" - TC " qdisc add dev eth0 root handle 1: htb default 1\n" - TC " class add dev eth0 parent 1: classid 1:1 htb rate 42= 94967295kbps quantum 366503875\n" - TC " qdisc add dev eth0 parent 1:1 handle 2: sfq perturb = 10\n" - TC " filter add dev eth0 parent 1:0 protocol all prio 1 h= andle 1 fw flowid 1\n" - TC " qdisc add dev eth0 ingress\n" - TC " filter add dev eth0 parent ffff: protocol all u32 ma= tch " - "u32 0 0 police rate 4294967295kbps burst 4194303kb mtu 6= 4kb " - "drop flowid :1\n")); + DO_TEST_SET("" + " " + " " + "", + TC " qdisc del dev eth0 root\n" + TC " qdisc del dev eth0 ingress\n" + TC " qdisc add dev eth0 root handle 1: htb default 1\n" + TC " class add dev eth0 parent 1: classid 1:1 htb rate 429= 4967295kbps quantum 366503875\n" + TC " qdisc add dev eth0 parent 1:1 handle 2: sfq perturb 1= 0\n" + TC " filter add dev eth0 parent 1:0 protocol all prio 1 ha= ndle 1 fw flowid 1\n" + TC " qdisc add dev eth0 ingress\n" + TC " filter add dev eth0 parent ffff: protocol all u32 mat= ch " + "u32 0 0 police rate 4294967295kbps burst 4194303kb mtu 64= kb " + "drop flowid :1\n"); =20 return ret =3D=3D 0 ? EXIT_SUCCESS : EXIT_FAILURE; } --=20 2.35.1