From nobody Fri Apr 26 22:47:35 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1556637000; cv=none; d=zoho.com; s=zohoarc; b=ikz33rGCbHlwoh7u6Tc13msq3owtSk+3vCwMdoq77UFts7LP+orsbnemDvw6YSSzlqadkvlbHQfBWKPJ098l0NmMrUD6q6LHsj+N3FunNKpdAp/80s8/yxuK8bDPMcqVmUVxOiF0ykJI1CV/BJ5rXhvaNTqtNfFBpLCW26XwASY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1556637000; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To:ARC-Authentication-Results; bh=8SToUdMuNKCFXL0sIb1jveoHDz6eNgIu4yZ7ywXd7cU=; b=T4f5XuornklQb7ikLu0jBR1OcAHm2z/zpg0pIdhLU/VGLlKh/FP9kVeJDWbhF9azkX0dZRcQGOzfTimq6l6OOOYBrfozRfDRE1VU2FoDv8K+YGcKe6np9T9sU78gXMC4G2xVrOtZ1XOR297S/fiKkKL41b5iDX2+eEyCSFbsT4c= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1556637000815248.41737089998412; Tue, 30 Apr 2019 08:10:00 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id EB07C30842A1; Tue, 30 Apr 2019 15:09:58 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id BF0686D0A8; Tue, 30 Apr 2019 15:09:58 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 79CBE18089CC; Tue, 30 Apr 2019 15:09:58 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id x3UF8c4U022848 for ; Tue, 30 Apr 2019 11:08:38 -0400 Received: by smtp.corp.redhat.com (Postfix) id BD1FF7D905; Tue, 30 Apr 2019 15:08:38 +0000 (UTC) Received: from worklaptop.bos.redhat.com (dhcp-17-140.bos.redhat.com [10.18.17.140]) by smtp.corp.redhat.com (Postfix) with ESMTP id 40A907C825; Tue, 30 Apr 2019 15:08:36 +0000 (UTC) From: Cole Robinson To: libvirt-list@redhat.com Date: Tue, 30 Apr 2019 11:08:06 -0400 Message-Id: <928ee40613b7fde3d54df7890949adce35553cc2.1556636871.git.crobinso@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-loop: libvir-list@redhat.com Cc: Yuval Turgeman , Laine Stump Subject: [libvirt] [PATCH] spec: fix f28 rpm without firewalld zone X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.40]); Tue, 30 Apr 2019 15:09:59 +0000 (UTC) Content-Type: text/plain; charset="utf-8" Commit 3b71f2e42d added spec handling for with_firewalld_zone. We now call %firewalld_reload if with_firewalld is set. But the matching 'BuildRequires: firewalld-filesystem' is only applied if with_firewalld_zone is set. Fix the former bit to use with_firewalld_zone Reported-by: Yuval Turgeman Signed-off-by: Cole Robinson Reviewed-by: Laine Stump --- libvirt.spec.in | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libvirt.spec.in b/libvirt.spec.in index 18f0a0e217..876b2f0897 100644 --- a/libvirt.spec.in +++ b/libvirt.spec.in @@ -1387,12 +1387,12 @@ fi rm -rf %{_localstatedir}/lib/rpm-state/libvirt || : =20 %post daemon-driver-network -%if %{with_firewalld} +%if %{with_firewalld_zone} %firewalld_reload %endif =20 %postun daemon-driver-network -%if %{with_firewalld} +%if %{with_firewalld_zone} %firewalld_reload %endif =20 --=20 2.21.0 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list