From nobody Mon Feb 2 07:32:14 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=reject dis=none) header.from=lists.libvirt.org ARC-Seal: i=1; a=rsa-sha256; t=1768814230; cv=none; d=zohomail.com; s=zohoarc; b=ETdOnNHZVT9ohCuvZyic2dd8G4xHfpYw5UIkEBSsU83FtwpN9xsxCP5CmG5la8vEzVFGjAuu+ATB82TbHleYsXaBgHg+Bpjx+F4dhbSmbl3XCUHKSwosdASAWztKOIRa8qfJwYVRuV3jSmAVG0E3+MiNL66P9nLwI/D1e3pd+Yk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1768814230; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Owner:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Subject:Subject:To:To:Message-Id:Cc; bh=gQMtwpgIWS1pgfKlfpivB6TcfY4azndI7ZhCDOm2Od4=; b=YyZRQ2ym76xZzWuhcxmYWG5YXLZWOogqQ/LXtEkkwVygCQVUSwV++PH354H7URfpkzBFkG/3KzIHoJ39xhZ2TxLQjeKXK4IvNq/LgcNg8THjf141q57E66IdIIbQ3R3A7kJlMS9QD1TcCpUrBB3J7AP1K2wNnz3iUUDfCWSzheE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 176881423072096.27957304071106; Mon, 19 Jan 2026 01:17:10 -0800 (PST) Received: by lists.libvirt.org (Postfix, from userid 993) id 897A141B97; Mon, 19 Jan 2026 04:17:09 -0500 (EST) Received: from [172.19.199.3] (lists.libvirt.org [8.43.85.245]) by lists.libvirt.org (Postfix) with ESMTP id 8155743E6B; Mon, 19 Jan 2026 04:13:02 -0500 (EST) Received: by lists.libvirt.org (Postfix, from userid 993) id 4E19F4199B; Mon, 19 Jan 2026 04:12:56 -0500 (EST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (3072 bits) server-digest SHA256) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id DCBC83FB95 for ; Mon, 19 Jan 2026 04:12:51 -0500 (EST) Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-607-Gjmj2c8VNtawUv9yNm0AsA-1; Mon, 19 Jan 2026 04:12:49 -0500 Received: from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 30A98180034A for ; Mon, 19 Jan 2026 09:12:49 +0000 (UTC) Received: from speedmetal.lan (unknown [10.44.22.5]) by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 767D319560A7 for ; Mon, 19 Jan 2026 09:12:48 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-3.4 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_LOW, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_PASS autolearn=unavailable autolearn_force=no version=4.0.1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1768813971; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=gQMtwpgIWS1pgfKlfpivB6TcfY4azndI7ZhCDOm2Od4=; b=DBi5AYn5Huhwcz2RLjNPP3pTg7g1G/FQkE7AroF1TnWSLF6ds98fumBCXEwgrq57Tzseay pepakQFQcm65YHu0fZNOqlCsdzfQEbrXbsN+gGDmYQjrsXhfzd3Dt18jDbX+Kky1dNhUAU KR3qUDoH7oMWz2f1tWp3/BOA2DnpL4k= X-MC-Unique: Gjmj2c8VNtawUv9yNm0AsA-1 X-Mimecast-MFC-AGG-ID: Gjmj2c8VNtawUv9yNm0AsA_1768813969 To: devel@lists.libvirt.org Subject: [PATCH 2/4] qemuDomainSetBlockIoTuneField: Move setting of 'group_name' out of the loop Date: Mon, 19 Jan 2026 10:12:42 +0100 Message-ID: <91b6c5c584bdc5c5d19091f15e80423067808c36.1768813932.git.pkrempa@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.12 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: H8leT1BHy5AVXmTkPaE4eyBpn6xnDq0HgoYrkkur5ik_1768813969 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: C54S74Z2OQL6OXQALTSJ3FSXWN54NGB6 X-Message-ID-Hash: C54S74Z2OQL6OXQALTSJ3FSXWN54NGB6 X-MailFrom: pkrempa@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-devel.lists.libvirt.org-0; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: Peter Krempa via Devel Reply-To: Peter Krempa X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1768814231572158500 Content-Type: text/plain; charset="utf-8" From: Peter Krempa The refactor will simplify further change which will introduce another source for the group name. Signed-off-by: Peter Krempa --- src/qemu/qemu_driver.c | 20 ++++++++++++-------- 1 file changed, 12 insertions(+), 8 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index bed60d1ca7..8c7a2e9fe2 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -15182,6 +15182,7 @@ qemuDomainSetBlockIoTuneFields(virDomainBlockIoTune= Info *info, int *eventNparams, int *eventMaxparams) { + const char *param_group_name =3D NULL; size_t i; #define SET_IOTUNE_FIELD(FIELD, BOOL, CONST) \ @@ -15227,15 +15228,8 @@ qemuDomainSetBlockIoTuneFields(virDomainBlockIoTun= eInfo *info, WRITE_IOPS_SEC_MAX); SET_IOTUNE_FIELD(size_iops_sec, SIZE_IOPS, SIZE_IOPS_SEC); - /* NB: Cannot use macro since this is a value.s not a value.ul */ if (STREQ(param->field, VIR_DOMAIN_BLOCK_IOTUNE_GROUP_NAME)) { - info->group_name =3D g_strdup(param->value.s); - *set_fields |=3D QEMU_BLOCK_IOTUNE_SET_GROUP_NAME; - if (virTypedParamsAddString(eventParams, eventNparams, - eventMaxparams, - VIR_DOMAIN_TUNABLE_BLKDEV_GROUP_NA= ME, - param->value.s) < 0) - return -1; + param_group_name =3D param->value.s; continue; } @@ -15253,6 +15247,16 @@ qemuDomainSetBlockIoTuneFields(virDomainBlockIoTun= eInfo *info, WRITE_IOPS_SEC_MAX_LENGTH); } + if (param_group_name) { + info->group_name =3D g_strdup(param_group_name); + *set_fields |=3D QEMU_BLOCK_IOTUNE_SET_GROUP_NAME; + if (virTypedParamsAddString(eventParams, eventNparams, + eventMaxparams, + VIR_DOMAIN_TUNABLE_BLKDEV_GROUP_NAME, + param_group_name) < 0) + return -1; + } + #undef SET_IOTUNE_FIELD return 0; --=20 2.52.0