From nobody Mon Feb 9 09:08:36 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1629976951; cv=none; d=zohomail.com; s=zohoarc; b=RVvsqduTt1NfrXbUbmTZJNmouulcnb080+oYYXWTOzxFX+NFmQITpSDnWT2WzUUv8RJeGX9rvL2Wtuy3Mb4I3jqLJgvbR3tJfUrK28tEQGKzra5YTM+kwUw/zeUwA2Y0Ph7wfQ1w/6trRL04u/rzL2KpiP1g+dBZ6HWVLpeJrPI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1629976951; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=qHdcRN8RH7+GkUYEiYOtRw/FJ4p2beWgNvAzw9gurRw=; b=VajZ9oSBKnRdjCc7ACFe1OH0ZSKVEtDU3kfsDGlh6fl9fRdG9SBO0FPnMpm2j6xVZgeQDXcxhg1CJIRx61b24VfFja4iVCxWvVS02MAeZGnZVKRaXZneO+Zpj8o1n6ds1KtTDc4e+H6oueM9Aw0EUdOh90Jt60GR3vcTASDmdas= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1629976951972368.02759675290486; Thu, 26 Aug 2021 04:22:31 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-374-DCnF9ZNnOzGYsHNQGo231Q-1; Thu, 26 Aug 2021 07:22:29 -0400 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 5FF57108292A; Thu, 26 Aug 2021 11:22:24 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 3275B60583; Thu, 26 Aug 2021 11:22:24 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 026E0181A1D3; Thu, 26 Aug 2021 11:22:24 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 17QBM3nZ005579 for ; Thu, 26 Aug 2021 07:22:03 -0400 Received: by smtp.corp.redhat.com (Postfix) id 41AFC19D9F; Thu, 26 Aug 2021 11:22:03 +0000 (UTC) Received: from localhost.localdomain.com (unknown [10.43.2.2]) by smtp.corp.redhat.com (Postfix) with ESMTP id BF32819C59 for ; Thu, 26 Aug 2021 11:22:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1629976951; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=qHdcRN8RH7+GkUYEiYOtRw/FJ4p2beWgNvAzw9gurRw=; b=HuPflA9V51WzbkfSNM4eLG7/drtodm6DU+TFow3G/Jj4JO0EvJwlrhgt/OWSkZDJ5ZjokF Lpx1xmzSi0RKhvrjxjQa727JubGYFGfmeI9W4yeDchjCcRphBzZxi/Ow5NpgGrj/xt4KTT m9Eq9OcHK8T+FTgS3x4uObQI9c26qIA= X-MC-Unique: DCnF9ZNnOzGYsHNQGo231Q-1 From: Kristina Hanicova To: libvir-list@redhat.com Subject: [PATCH 5/6] network: allow VIR_NETWORK_CREATE_VALIDATE flag Date: Thu, 26 Aug 2021 13:21:43 +0200 Message-Id: <90a54b0e36708a5d09c0f83a1871ae2466ef09bb.1629976821.git.khanicov@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1629976952759100001 Content-Type: text/plain; charset="utf-8" Signed-off-by: Kristina Hanicova --- src/network/bridge_driver.c | 4 ++-- src/test/test_driver.c | 4 ++-- src/vbox/vbox_network.c | 3 ++- 3 files changed, 6 insertions(+), 5 deletions(-) diff --git a/src/network/bridge_driver.c b/src/network/bridge_driver.c index 32b37de030..57f4ce21b7 100644 --- a/src/network/bridge_driver.c +++ b/src/network/bridge_driver.c @@ -3475,9 +3475,9 @@ networkCreateXMLFlags(virConnectPtr conn, virNetworkPtr net =3D NULL; virObjectEvent *event =3D NULL; =20 - virCheckFlags(0, NULL); + virCheckFlags(VIR_NETWORK_CREATE_VALIDATE, NULL); =20 - if (!(newDef =3D virNetworkDefParseString(xml, network_driver->xmlopt,= 0))) + if (!(newDef =3D virNetworkDefParseString(xml, network_driver->xmlopt,= flags))) goto cleanup; =20 if (virNetworkCreateXMLFlagsEnsureACL(conn, newDef) < 0) diff --git a/src/test/test_driver.c b/src/test/test_driver.c index 4ab03019e1..b5ed2555d8 100644 --- a/src/test/test_driver.c +++ b/src/test/test_driver.c @@ -5582,9 +5582,9 @@ testNetworkCreateXMLFlags(virConnectPtr conn, const c= har *xml, virNetworkPtr net =3D NULL; virObjectEvent *event =3D NULL; =20 - virCheckFlags(0, NULL); + virCheckFlags(VIR_NETWORK_CREATE_VALIDATE, NULL); =20 - if ((newDef =3D virNetworkDefParseString(xml, NULL, 0)) =3D=3D NULL) + if ((newDef =3D virNetworkDefParseString(xml, NULL, flags)) =3D=3D NUL= L) goto cleanup; =20 if (!(obj =3D virNetworkObjAssignDef(privconn->networks, newDef, diff --git a/src/vbox/vbox_network.c b/src/vbox/vbox_network.c index 2826937f81..d9402eff42 100644 --- a/src/vbox/vbox_network.c +++ b/src/vbox/vbox_network.c @@ -386,7 +386,8 @@ vboxNetworkDefineCreateXML(virConnectPtr conn, const ch= ar *xml, bool start, virNetworkPtr ret =3D NULL; nsresult rc; =20 - virCheckFlags(VIR_NETWORK_DEFINE_VALIDATE, NULL); + virCheckFlags(VIR_NETWORK_DEFINE_VALIDATE | + VIR_NETWORK_CREATE_VALIDATE, NULL); =20 if (!data->vboxObj) return ret; --=20 2.31.1