From nobody Mon Feb 9 09:39:50 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=reject dis=none) header.from=lists.libvirt.org ARC-Seal: i=1; a=rsa-sha256; t=1747667937; cv=none; d=zohomail.com; s=zohoarc; b=FJL+R3frK97nfHvlbIg9E/EA17ykOwoMJNXLN1n/lyHQfpkiM0JUAlgUxeYp4d4HnyTmBvITisWinS2TfKQSbMh24SOWiCrqX4+Z279uI5jv2UOT0FF9Ef1pb6+c5NyIGfmBihWtRQJQR4kZdV3DPJRIAurztvC2ig73gY/lcdE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1747667937; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Subject:Subject:To:To:Message-Id:Cc; bh=FglzbT/jiuL/FdvVncAWvbE17navhTANycQf40VHpw0=; b=SVXiczTs7TcaFt/J7zjm6QSqRmk/3UJMFFRHMQRgGm9mI9GZNx3Pk17XeuF0v4R7AmJWCdmhG+PdlnNtlbWozuwznBe6ywnOsZ4c9GvxcsIosPG18jZdKGa9vjtZGfVM4l/8rWjR08q2RHn0bc1NNZ/MeIsAWaGJLDjIkcECMX4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1747667937916924.022816252242; Mon, 19 May 2025 08:18:57 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 996) id E4C6215C7; Mon, 19 May 2025 11:18:56 -0400 (EDT) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id 0890F16B0; Mon, 19 May 2025 11:18:24 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 996) id 1586B1292; Mon, 19 May 2025 11:18:20 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id AAA0913FD for ; Mon, 19 May 2025 11:18:19 -0400 (EDT) Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-610-w2GmCGSwOj2p4sdquwpQ_A-1; Mon, 19 May 2025 11:18:18 -0400 Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 4B5A11801A10 for ; Mon, 19 May 2025 15:18:17 +0000 (UTC) Received: from speedmetal.lan (unknown [10.44.22.37]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 7EA1618003FC for ; Mon, 19 May 2025 15:18:16 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-1.8 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_HELO_NONE autolearn=unavailable autolearn_force=no version=3.4.4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1747667899; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=I/c+q7n5XT2Yh5sK/pOCE0WndqFFIOdDpERQqxzG0kU=; b=YPXcLltA0TFKWlbPwRP+Vj7hRkkKdaZ6pZKuqZKXZw116baKkvALROLhWICqCbOC3R5qTZ 4jeS0GfPjKspwk1VPx9u0c4AY0bTHKL9EAn7Fc/Hu2cI0IMOO4oNecKBxJCvQeURFiGqJj 92+Ild8iK+5HTF+72mCGaXkpyqiCbCo= X-MC-Unique: w2GmCGSwOj2p4sdquwpQ_A-1 X-Mimecast-MFC-AGG-ID: w2GmCGSwOj2p4sdquwpQ_A_1747667897 To: devel@lists.libvirt.org Subject: [PATCH 1/3] qemuBackupPrepare: Actually allow 'VIR_STORAGE_NET_HOST_TRANS_FD' Date: Mon, 19 May 2025 17:18:11 +0200 Message-ID: <908a48b002646328bcbca28af5a22c06a9ae7a40.1747667845.git.pkrempa@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: MOwHybSeNSfy5O2_iR8iMnMzkSghnFoxlXFTv9fo5Hk_1747667897 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: PPQDUJ5E4JRV6ZW3KIZIRDSXBAGRVQ24 X-Message-ID-Hash: PPQDUJ5E4JRV6ZW3KIZIRDSXBAGRVQ24 X-MailFrom: pkrempa@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: From: Peter Krempa via Devel Reply-To: Peter Krempa X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1747667939368116600 Content-Type: text/plain; charset="utf-8" From: Peter Krempa While I've actually implemented support for FD passing the NBD server socket in eb768a556db I managed to misplace the hunk allowing the 'FD' transport in the validation code, rendering the whole feature useless. Fix the validation logic to make the feature useful. Fixes: eb768a556db75040f7b518d198a18bd0f5d6faad Signed-off-by: Peter Krempa Reviewed-by: J=C3=A1n Tomko --- src/qemu/qemu_backup.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/qemu/qemu_backup.c b/src/qemu/qemu_backup.c index f6ee31dc2a..fb3558d280 100644 --- a/src/qemu/qemu_backup.c +++ b/src/qemu/qemu_backup.c @@ -86,8 +86,10 @@ qemuBackupPrepare(virDomainBackupDef *def) /* TODO: Do we need to mess with selinux? */ break; - case VIR_STORAGE_NET_HOST_TRANS_RDMA: case VIR_STORAGE_NET_HOST_TRANS_FD: + break; + + case VIR_STORAGE_NET_HOST_TRANS_RDMA: case VIR_STORAGE_NET_HOST_TRANS_LAST: virReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("unexpected transport in ")); --=20 2.49.0