From nobody Thu Dec 18 00:23:16 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1571415137; cv=none; d=zoho.com; s=zohoarc; b=BufkR9L2Q2oajkpWE4d5Xgjf0OO9SqjL0/p2MpkN5q4qUj+z3Puy/4wKdb2zcT5mFojZyBmKVK01jonfyBBKwYp/53IGlxQWdBq6gWMY9cAOtteWbQsDzV6qlefnrXmX6o/hDREyAymMJRHJDJoEdQi0QWD11LutGH6ed6bpoGY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1571415137; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=GRL7UMFRtV7CROLD6XMpSWEH1eRrKcnmbC489omE8xA=; b=VxhmJRbBGPQagmWyZRbFIrtY/4qbkYiyqWUzuZ+0fx2klDPZWaRkeLo3njQG1goduzvrQ7/d6of36KDL2wd3LmaG6z6zUeaWkcqH04VJWa3uwt4m42gPhfDaBM7kI/0H41Zeqlo7mH2FlvYajQJeHo1riWkcLZdUvc/3quI/4XQ= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1571415137467781.4394514737879; Fri, 18 Oct 2019 09:12:17 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id C831F315C000; Fri, 18 Oct 2019 16:12:15 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 9BF105C290; Fri, 18 Oct 2019 16:12:15 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 411C53FB4D; Fri, 18 Oct 2019 16:12:15 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id x9IGBxrT004863 for ; Fri, 18 Oct 2019 12:11:59 -0400 Received: by smtp.corp.redhat.com (Postfix) id 4A28A600C8; Fri, 18 Oct 2019 16:11:59 +0000 (UTC) Received: from angien.brq.redhat.com (unknown [10.43.2.229]) by smtp.corp.redhat.com (Postfix) with ESMTP id A1862600C1; Fri, 18 Oct 2019 16:11:58 +0000 (UTC) From: Peter Krempa To: libvir-list@redhat.com Date: Fri, 18 Oct 2019 18:11:11 +0200 Message-Id: <9081b5150aa7e0d0588b30e418e5ca595d2eb53a.1571414890.git.pkrempa@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-loop: libvir-list@redhat.com Subject: [libvirt] [PATCH RFC 26/40] qemu: checkpoint: Use qemuMonitorTransactionBitmapMergeSourceAddBitmap X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.41]); Fri, 18 Oct 2019 16:12:16 +0000 (UTC) Content-Type: text/plain; charset="utf-8" Use the new helper in qemuCheckpointDiscard rather than constructing the array manually. Signed-off-by: Peter Krempa Reviewed-by: J=C3=A1n Tomko --- src/qemu/qemu_checkpoint.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/qemu/qemu_checkpoint.c b/src/qemu/qemu_checkpoint.c index 6a272f9dab..937d9d6b3e 100644 --- a/src/qemu/qemu_checkpoint.c +++ b/src/qemu/qemu_checkpoint.c @@ -173,7 +173,7 @@ qemuCheckpointDiscard(virQEMUDriverPtr driver, if (!(arr =3D virJSONValueNewArray())) return -1; - if (virJSONValueArrayAppendString(arr, disk->bitmap) <= 0) + if (qemuMonitorTransactionBitmapMergeSourceAddBitmap(a= rr, node, disk->bitmap) < 0) return -1; if (chk =3D=3D virDomainCheckpointGetCurrent(vm->check= points)) { --=20 2.21.0 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list